Stream: hapi
Topic: hapi-fhir: pull request 251: Server with Jax-Rs
Zulip HAPI Bot (Nov 25 2015 at 14:35):
petervanhoute synchronized pull request 251
Zulip HAPI Bot (Nov 27 2015 at 20:03):
jamesagnew closed pull request 251
Zulip HAPI Bot (Nov 27 2015 at 20:07):
jamesagnew commented on pull request 251
Hi @petervanhoute ,
I've merged this now. Looks amazing! I've also added you in as a committer so you can do any maintenance to it you need.
In merging, I made one change to it. I don't think paging was working correctly as the patch stood. It required the URL to have the name of the resource in it, e.g.
http://example.com/Patient?_getpages=foo
instead of
http://example.com?_getpages=fooA bunch of other things depend on the paging requests working from the root of the server so I fixed that.. but would you be able to look at what I did and see if it makes sense?
Zulip HAPI Bot (Dec 01 2015 at 09:30):
petervanhoute commented on pull request 251
Hello @James Agnew ,
I'm glad you like it! Thanks for merging and adding me as a commiter.
I was struggling with the paging and the URL's (self, next, resource references, ..). It's good you found an elegant, working solution for the paging and the url's.
You can remove the commented line 389 in Dstu2BundleFactory.java:
// theServerBase = theCompleteUrl.contains("?") ? theCompleteUrl.substring(0, theCompleteUrl.indexOf("?")) : theCompleteUrl;Kind regards,
Peter
Last updated: Apr 12 2022 at 19:14 UTC
