Stream: hapi
Topic: Hapi community
Patrick Werner (Feb 02 2022 at 13:05):
The releases stopped after 5.4.0. I think we should release a new starter with/after each new hapi release.
Patrick Werner (Feb 02 2022 at 13:06):
For 5.6.0 i think this would be the commit which should get tagged and released: https://github.com/hapifhir/hapi-fhir-jpaserver-starter/commit/e077091db42555d1e588d20fdbc34a0781ebd643
Jens Villadsen (Feb 02 2022 at 14:06):
@Patrick Werner we/(I) make tags - not releases: See https://github.com/hapifhir/hapi-fhir-jpaserver-starter/tags
Jens Villadsen (Feb 02 2022 at 14:07):
The same applies for https://hub.docker.com/r/hapiproject/hapi/tags
Jens Villadsen (Feb 02 2022 at 14:08):
We can easily make the 'Github Releases' - as they are 'just' syntactical sugar on top
Patrick Werner (Feb 02 2022 at 14:10):
i was confused because the releases ended after 5.4
+1 for GH releases.
Patrick Werner (Feb 02 2022 at 14:15):
The 5.6.0 tag is on a commit without the ValueSetOperationProvider.
Patrick Werner (Feb 02 2022 at 14:15):
I'd like to remove the tag, move it to: https://github.com/hapifhir/hapi-fhir-jpaserver-starter/commit/e077091db42555d1e588d20fdbc34a0781ebd643
Patrick Werner (Feb 02 2022 at 14:16):
and also create a gh release (to get people like me less confused)
Joe Flack (Feb 02 2022 at 19:14):
"Failed to load API definition". I have a short and to the point GitHub issue I made for this: https://github.com/hapifhir/hapi-fhir-jpaserver-starter/issues/310
Joe Flack (Feb 02 2022 at 19:15):
Is there anyone who could take a look at that and my application.yaml and verify that I'm going about the right way to correct this issue?
James Agnew (Feb 02 2022 at 23:25):
Sorry- this is obviously something we missed in our process. We have a new release manager these days and it's taken a lot of work nailing down all of the steps I was previously doing to do a release (which is typically a few days of work each quarter).
Jens Villadsen (Feb 03 2022 at 11:22):
FYI - @James Agnew Github has a nice "auto-generate release" that takes the commits and puts them into the notes. Should we coordinate with you guys or how? The current governance is VERY ad-hoc
Jens Villadsen (Feb 03 2022 at 11:23):
@Patrick Werner - feel free to move the tag. I don't know if that automatically triggers the docker flow - it might. It will for sure if you remove it first and then add it again. I can't remember what settings we have set up on Docker hub in regards to if we allow overwriting existing images - (which we definitely shouldn't, IMHO)
Jens Villadsen (Feb 03 2022 at 11:24):
and my last two cents - we need to have releases independently of HAPI FHIR as we may add features out-of-hapi-fhir band added.
Jens Villadsen (Feb 03 2022 at 11:26):
maybe we even should take the time to actually schedule a meeting (I've heard thats a thing ...)
Patrick Werner (Feb 03 2022 at 11:26):
Jens Villadsen said:
and my last two cents - we need to have releases independently of HAPI FHIR as we may add features out-of-hapi-fhir band added.
Yes. I like, that you can conclude from the jpastarter version to the hapi fhir version. But we need additional releases for the JPA starter if we are fixing stuff/ adding features.
Patrick Werner (Feb 03 2022 at 11:27):
Jens Villadsen said:
maybe we even should take the time to actually schedule a meeting (I've heard thats a thing ...)
I 100% agree.
@James Agnew i already wrote you an email about the hapi community/ how we could define rules for hapi and jpastarter.
Patrick Werner (Feb 03 2022 at 11:28):
Who is allowed to merge PRs, state some guidelines/rules for PRs, etc..
Patrick Werner (Feb 03 2022 at 11:29):
I also like the idea of a monthly? community meeting.
Patrick Werner (Feb 03 2022 at 11:29):
I think @Oliver Egger would be probably interested as well.
Oliver Egger (Feb 03 2022 at 11:52):
@Patrick Werner, yes i would be very interested
James Agnew (Feb 03 2022 at 13:32):
I like the idea of getting a regular community call going a lot. We're in feature freeze right now for 5.7.0 and there's a lot of work going on finishing that off, but I am definitely into the idea of getting that going as soon as we have this out the door. Agree we need to put some work into the process and people for the starter project in order to avoid it turning into a wild west.
I will say that it's very important to me that we stick to the HAPI FHIR release cadence of quarterly releases on the starter project, and stability between those times. Lots and lots of people use the project by forking it and working in their forks, and I want it to be predictable.
Patrick Werner (Feb 03 2022 at 15:15):
+1 for being alligned. Maybe we could introduce a 4th digit to the version of the jpastarter for bugfixes regarding the jpastarter.
Jens Villadsen (Feb 03 2022 at 15:16):
Patrick Werner said:
+1 for being alligned. Maybe we could introduce a 4th digit to the version of the jpastarter for bugfixes regarding the jpastarter.
I gest the idea bit a a fourth digit could cause confusion unless there is some manifest somewhere that describes such usage
Patrick Werner (Feb 03 2022 at 15:36):
yes, 4th digit would break semver :disappointed:
James Agnew (Feb 03 2022 at 17:18):
We probably need to beef up the branching strategy for this project - As long as master is stable, we could iterate on a working branch for the next release over the quarter.
Re the "extra point" thing, people may have noticed we've actually started doing that in the hapi-fhir repo. The current master is numbered 6.0.0-PRE1-SNAPSHOT and we increment the PREx part occasionally until we release. Could do the same for the starter project, and the PREs certainly don't have to be tied to the corresponding hapi fhir one.
Last updated: Apr 12 2022 at 19:14 UTC
