Stream: hapi
Topic: Documentation Bug
Alexander Kiel (Jul 10 2019 at 09:30):
I'm not sure whether I should file a GitHub issue. On page http://hapifhir.io/doc_jpa.html under "Disable Paging at the Request Level", the Cache-Control header directive needs to be no-store and not nostore. Also tested this with v3.8.0. no-store works and nostore doesn't.
Patrick Werner (Jul 10 2019 at 14:32):
you are right, the doc was wrong, i fixed it in: https://github.com/jamesagnew/hapi-fhir/commit/9b938262e6081f536541f003e0589c93d5c6e61f
@James Agnew does the doc update automatically?
James Agnew (Jul 10 2019 at 15:21):
Ah thanks!! It doesn't automatically update, but I can redeploy it.
Alexander Kiel (Jul 10 2019 at 18:49):
Thanks! Another related thing: If I specify max-results using Cache-Control, Bundle.total is set to it. I see that the query optimization makes this happen. But wouldn't it be better to skip Bundle.total in this case? Should I file an issue?
James Agnew (Jul 10 2019 at 19:31):
Interesting... yeah, I guess i'd agree that's a bug!
Alexander Kiel (Jul 11 2019 at 13:38):
For Reference: https://github.com/jamesagnew/hapi-fhir/issues/1377
Last updated: Apr 12 2022 at 19:14 UTC
