FHIR Chat · Core Issue 70 · hapi

Stream: hapi

Topic: Core Issue 70


view this post on Zulip Grahame Grieve (Apr 07 2020 at 20:42):

This is a breaking change:

https://github.com/hapifhir/org.hl7.fhir.core/issues/70

@James Agnew @Mark Iantorno and I intend to fix this as part of the HAPI R5 release. If you think that this is a problem, let us know

view this post on Zulip Michael Lawley (Apr 07 2020 at 20:47):

It doesn't need to be breaking does it? Keep the non-standard setStatus(String) methods but flagged as @deprecated

view this post on Zulip Grahame Grieve (Apr 07 2020 at 20:59):

well, that would force the normal method to have a different name

view this post on Zulip Grahame Grieve (Apr 07 2020 at 20:59):

which is much more complex for the validator

view this post on Zulip Keith Boone (Apr 07 2020 at 20:59):

How would it force the normal method to have a different name?

view this post on Zulip Michael Lawley (Apr 07 2020 at 21:00):

Why? Should be able to overload on Enum and String parameter types

view this post on Zulip Grahame Grieve (Apr 07 2020 at 21:00):

not the get

view this post on Zulip Grahame Grieve (Apr 07 2020 at 21:00):

public String getStatus()
public MedicationDispenseStatus getStatus()

view this post on Zulip Keith Boone (Apr 07 2020 at 21:01):

Ah, I was thinking about the set. You are so right.

view this post on Zulip Michael Lawley (Apr 07 2020 at 21:01):

Ah, the issue only mentioned the set. I had assumed the get was ok


Last updated: Apr 12 2022 at 19:14 UTC