FHIR Chat · Bug in POJOs · hapi

Stream: hapi

Topic: Bug in POJOs


view this post on Zulip Grahame Grieve (Nov 06 2018 at 22:18):

@James Agnew I am just fixing a bug in the POJO code. The bug is in this line:

  @Override
  public StringType copy() {
     return new StringType(getValue());
  }

view this post on Zulip Grahame Grieve (Nov 06 2018 at 22:19):

the fix is to change to

view this post on Zulip Grahame Grieve (Nov 06 2018 at 22:19):

  @Override
  public StringType copy() {
    StringType ret = new StringType(getValue());
    copyValues(ret);
    return ret;
  }

view this post on Zulip Grahame Grieve (Nov 06 2018 at 22:20):

so that id and extensions are copied

view this post on Zulip Grahame Grieve (Nov 06 2018 at 22:26):

I am making this change in R4 . I don't know whether we should also make it in the other versions?

view this post on Zulip Richard Ettema (Nov 07 2018 at 17:48):

Just did a check of the other FHIR data type POJOs and this correction looks like it needs to be made in all of the following POJO classes:

Base64BinaryType.java
BooleanType.java
CanonicalType.java
CodeType.java
DateTimeType.java
DateType.java
DecimalType.java
Enumeration.java
IdType.java
InstantType.java
IntegerType.java
MarkdownType.java
OidType.java
PositiveIntType.java
StringType.java
TimeType.java
UnsignedIntType.java
UriType.java
UrlType.java
UuidType.java

view this post on Zulip Grahame Grieve (Nov 07 2018 at 19:35):

that's the ones I changed in the R4 master source

view this post on Zulip Richard Ettema (Nov 07 2018 at 20:04):

Ok. Thanks.


Last updated: Apr 12 2022 at 19:14 UTC