Stream: implementers
Topic: java validator bug
Patrick Werner (Jan 24 2021 at 14:17):
The current version of the validator seems to be broken:
Terminology server http://tx.fhir.orgException in thread "main" java.lang.NoClassDefFoundError: okhttp3/Request$Builder
workaround: -tx n/a
Jens Villadsen (Jan 24 2021 at 14:18):
Looks like a fried dependency
Patrick Werner (Jan 24 2021 at 14:56):
fix: https://github.com/hapifhir/org.hl7.fhir.core/pull/422
@fyi @Mark Iantorno @Grahame Grieve
Mark Iantorno (Jan 24 2021 at 14:57):
That will break hapi fhir
Mark Iantorno (Jan 24 2021 at 14:58):
The dependency needs to be marked as optional. The original okhttp dependency in the r5 library was changed to optional a day or two ago, and that's what is causing the issue right now
Mark Iantorno (Jan 24 2021 at 14:59):
Let me take a quick look at how to properly fix the dependencies such that no other downstream projects get borked
Mark Iantorno (Jan 24 2021 at 15:04):
I left a comment, please just add the optional tag to the dependency
Mark Iantorno (Jan 24 2021 at 15:04):
that will fix it for now
Mark Iantorno (Jan 24 2021 at 15:05):
@Patrick Werner
Patrick Werner (Jan 24 2021 at 15:07):
thanks for the fast response, added the optional tag
Mark Iantorno (Jan 24 2021 at 15:09):
eh, no problem, I have to add a test that actually runs the validator on a test file
Mark Iantorno (Jan 24 2021 at 15:09):
to make sure changes don't break it
Mark Iantorno (Jan 24 2021 at 15:10):
might do that this week if I have time
Mark Iantorno (Jan 24 2021 at 17:06):
The fixed build is now live
Mark Iantorno (Jan 24 2021 at 17:06):
@Patrick Werner please let me know if there are any issues
Patrick Werner (Jan 24 2021 at 18:44):
hmmm. This fixed the issue for me locally, running it in intelliJ. The new released Version still got the issue. The optional dependency seems to be ignored while building the CLI Validator.
Patrick Werner (Jan 24 2021 at 18:46):
Testing also adding it directly into the cli pom, non optional.
Patrick Werner (Jan 24 2021 at 18:46):
*currently
Patrick Werner (Jan 24 2021 at 18:47):
ok, seems to be the fix. Will Push in a sec
Patrick Werner (Jan 24 2021 at 19:01):
https://github.com/hapifhir/org.hl7.fhir.core/pull/425
Patrick Werner (Jan 24 2021 at 19:03):
I also found another issue in the validator logic: Validation Addresses with pattern on them always caused a wrong validation error on the line.size (in pattern line.size can be >= compared to the pattern line size).
I applied the same logic as in the CodingCheck.
Patrick Werner (Jan 24 2021 at 19:04):
length validation of line now works on addresses with pattern on Address.
Patrick Werner (Jan 24 2021 at 19:05):
PR here: https://github.com/hapifhir/org.hl7.fhir.core/pull/424
@Mark Iantorno @Grahame Grieve
Mark Iantorno (Jan 25 2021 at 14:51):
@Patrick Werner I merged it in and it will be in 5.2.20
Mark Iantorno (Jan 25 2021 at 14:51):
should be available soon
Patrick Werner (Jan 25 2021 at 15:33):
works thanks!
Patrick Werner (Jan 27 2021 at 12:11):
@Mark Iantorno is there a chance of merging this PR: https://github.com/hapifhir/org.hl7.fhir.core/pull/424 soon as well?
Currently the validator always throws Errors on Address.line cardindality if you specify a pattern on Address.
Mark Iantorno (Jan 27 2021 at 14:44):
Looks good. Just please add a line describing the change to the RELEASE_NOTES.md file
Mark Iantorno (Jan 27 2021 at 14:44):
* Fixed this issue by doing this
Mark Iantorno (Jan 27 2021 at 14:44):
something like that
Mark Iantorno (Jan 27 2021 at 14:44):
with the proper details of course
Last updated: Apr 12 2022 at 19:14 UTC
