Stream: implementers
Topic: IG autobuilder stuck?
Patrick Werner (Apr 20 2021 at 13:36):
I commited a branch to our IG 1h ago and didn't see a notification in the notefication stream yet.
Patrick Werner (Apr 20 2021 at 13:37):
Is the autobuilder stuck? (branch: https://github.com/HL7/genomics-reporting/tree/pw/codedNotes)
Lloyd McKenzie (Apr 20 2021 at 13:52):
@Mark Iantorno
Mark Iantorno (Apr 20 2021 at 14:24):
Let me take a peek and kick it
Mark Iantorno (Apr 20 2021 at 14:24):
Where is the actual PR that is triggering the build
Mark Iantorno (Apr 20 2021 at 14:27):
If you send me the link to the PR I will investigate
Kevin Power (Apr 20 2021 at 14:52):
@Mark Iantorno - In our experience, pushing to a branch like the one @Patrick Werner linked to above was enough to trigger a build. I did just submit a PR to see if that helps:
https://github.com/HL7/genomics-reporting/pull/43
Mark Iantorno (Apr 20 2021 at 15:14):
So, I don't actually control this pipeline?
Mark Iantorno (Apr 20 2021 at 15:15):
Just looked now
Mark Iantorno (Apr 20 2021 at 15:15):
I appears to have run at 10:53 though
Mark Iantorno (Apr 20 2021 at 15:15):
according to the notifications channel
Mark Iantorno (Apr 20 2021 at 15:15):
I will check with Grahame on this today to see if I can bring it under my control with the other pipelines
Patrick Werner (Apr 20 2021 at 18:19):
thanks @Mark Iantorno
Kevin Power (Apr 21 2021 at 13:29):
@Mark Iantorno - Any update?
Mark Iantorno (Apr 21 2021 at 13:31):
I sent Josh a message and I'm going to wait to hear back from him.
Mark Iantorno (Apr 21 2021 at 13:31):
hopefully we can resolve this today/tomorrow
Mark Iantorno (Apr 21 2021 at 15:11):
@Patrick Werner the auto-ig-builder appears to be working as intended? Can you please verify that it is still not working for you?
Mark Iantorno (Apr 21 2021 at 15:11):
You will have to push again
Mark Iantorno (Apr 21 2021 at 15:11):
I checked your webhook, and there is no logged error
Mark Iantorno (Apr 21 2021 at 15:11):
so I am not sure what went wrong
Mark Iantorno (Apr 21 2021 at 15:12):
But I'm seeing that the builder has been triggered and has run successfully many times in the last 24h
Mark Iantorno (Apr 21 2021 at 15:12):
so I'm not convinced it's currently "down"
Mark Iantorno (Apr 21 2021 at 15:12):
@Kevin Power if you could also check that would be helpful
Mark Iantorno (Apr 21 2021 at 15:41):
Let me know when you have tried this, and I will continue my investigation if necessary
David Pyke (Apr 21 2021 at 15:42):
I just pushed a build both to a branch and to master and they both worked fine
Patrick Werner (Apr 21 2021 at 19:05):
it still isnt working for my branch in genomics: https://github.com/HL7/genomics-reporting/commits/pw/codedNotes
Pushed 3 changes today.
Patrick Werner (Apr 21 2021 at 19:05):
i checked the notifications channel: no notifications
Patrick Werner (Apr 21 2021 at 19:06):
checked: http://build.fhir.org/ig/HL7/genomics-reporting/branches/
Patrick Werner (Apr 21 2021 at 19:06):
the branch isn't build.
@Kevin Power @Mark Iantorno
Josh Mandel (Apr 21 2021 at 19:08):
The / in your branch name isn't supported.
Josh Mandel (Apr 21 2021 at 19:10):
I've captured a note in the setup guide for this.
Josh Mandel (Apr 21 2021 at 19:11):
Branch names should be alphanumeric, _, and - (not saying this is a great or helpful behavior -- but the "quick fix" for now would be to rename the branch).
Patrick Werner (Apr 21 2021 at 19:12):
thanks josh!
John Moehrke (Apr 21 2021 at 19:23):
I often forget to change the content-type to application/json when configuring the webhooks... Nothing will happen if you leave it the default.
John Moehrke (Apr 21 2021 at 19:24):
if you look at the webhook config on your github repo, what is the "Recent Deliveries" indicate?
Kevin Power (Apr 21 2021 at 19:34):
I did rename the branch and it built successfully. Thanks everyone.
Josh Mandel (Apr 21 2021 at 19:46):
Thanks, and sorry for the trouble!
Patrick Werner (Apr 21 2021 at 20:13):
thanks for adding this to the documentation of the ig builder.
Lloyd McKenzie (Apr 21 2021 at 22:13):
Does Git have machinery where we could impose constraints on branch names that would prevent people from running into this issue? (Ideally that we could enforce at an organizational level?)
Josh Mandel (Apr 21 2021 at 22:15):
I don't think github has a feature that prevents you from creating branches with legally allowed names. We could detect illegal branch names in our autobuild infrastructure and report a helpful error! I'll talk through this with @Mark Iantorno who I think is going to take over this infrastructure. (Our own restriction comes from naive use of a filesystem hierarchy to represent branches on our build server, but the benefit is that it's easy to navigate structures like http://build.fhir.org/ig/HL7/smart-app-launch/branches/)
Last updated: Apr 12 2022 at 19:14 UTC
