FHIR Chat · GF#16998 - name of Binary.content & Attachment.data · implementers

Stream: implementers

Topic: GF#16998 - name of Binary.content & Attachment.data


view this post on Zulip Grahame Grieve (Jun 13 2018 at 03:10):

GF#16998 asks why Binary.content and Attachment.data don't have the same name. The simple answer is Binary name was driven by 'content-type' alignment where as Attachment.data was driven by alignment with the name used in the V3 data types. Neither of those are great reasons, and it would be nice to align them in a small way. But I don't think alignment justifies the cost of change in this case. Does anyone disagree? (@Elliot Silver )

view this post on Zulip John Moehrke (Jun 13 2018 at 13:18):

It would be good to have one name where similar uses. Because the name .content is used in DocumentReference as a Backbone Element, then to change Attachment.data to Attachment.content; then we will have some strange element names in DocumentReference.content.attachment.content.... Similar issue with Communication, Contract, and Media. --- So I would rather we use .data than .content

view this post on Zulip John Moehrke (Jun 13 2018 at 13:18):

should Signature.blob be renamed to Signature.data given it is a base64binary? The element blob was picked for no good reason at all, hoping someone would be creative and offer a more helpful element name...

view this post on Zulip Grahame Grieve (Jun 13 2018 at 13:32):

well, ok, I agree that .data would be better than .content. but I don't think that renaming is justified here

view this post on Zulip John Moehrke (Jun 13 2018 at 13:36):

I am not strongly for changing... just expressing that little motivation I could bring myself to express...

view this post on Zulip Lloyd McKenzie (Jun 13 2018 at 13:59):

I like consistency, but I'm not incurring any cost - so my opinion doesn't really count...

view this post on Zulip Elliot Silver (Jun 13 2018 at 17:27):

I'd be in favor of content -> data, I'm also not incurring (significant) cost.

view this post on Zulip Elliot Silver (Jun 13 2018 at 17:28):

If we don't make the change, can we add an alias on both elements with the other name?

view this post on Zulip Michael Donnelly (Jun 13 2018 at 17:45):

If there's a way to actually make it consistent across the board, I'd be willing to take on the effort to change. If we'd just be moving misalignment somewhere else, not worth it.

view this post on Zulip Grahame Grieve (Jun 13 2018 at 21:57):

ok. I'm going to propose that we rename Binary.content to Binary.data as a block vote matter. And also Signature.blob -> Signature.data


Last updated: Apr 12 2022 at 19:14 UTC