FHIR Chat · Diff between standalone StructDefs and StructDefs in bundles · implementers

Stream: implementers

Topic: Diff between standalone StructDefs and StructDefs in bundles


view this post on Zulip Nick George (May 15 2019 at 20:50):

Minor complaint - the structure definitions in standalone files (e.g., StructureDefinition-CodeableConcept.json) are not identical to the ones in the bundles like Bundle-types.json, due to formatting in the div. E.g.,
<div xmlns=\"http://www.w3.org/1999/xhtml\"><table ...
vs
<div xmlns=\"http://www.w3.org/1999/xhtml\">\n <table ...

view this post on Zulip Grahame Grieve (May 15 2019 at 23:04):

yay for whitespace issues in xhtml.

view this post on Zulip Grahame Grieve (May 15 2019 at 23:04):

this is a problem because?

view this post on Zulip Nick George (May 15 2019 at 23:19):

(well, it's a string stored in json, not in xhtml.)

Obviously not a huge issue but I'd argue that there should be a single unique structure definition for a given url, across all of the spec. Right now if I asked you "what is the string value of text.div for the structure definition of CodeableConcept?" the answer would be "depends which definition in the spec you're looking at"

view this post on Zulip Vassil Peytchev (May 16 2019 at 16:34):

Is it feasible to convert all xhtml to Cannonical XML before assigning it to the JSON property?

view this post on Zulip Lloyd McKenzie (May 16 2019 at 16:57):

It's feasible. The question is whether the benefit of doing so is worth the cost. Given that the two different strings of XHTML are semantically, canonically and behaviorally identical, I'm not seeing the benefit.

view this post on Zulip Nick George (May 16 2019 at 18:02):

fair enough. I'm just a bit surprised they don't come from the same source - that the string isn't generated by the same process in both cases. then would never be any question of inconsistencies, or needing to do any conversions.

view this post on Zulip Nick George (May 16 2019 at 18:05):

but yeah, probably not worth worrying about

view this post on Zulip Lloyd McKenzie (May 16 2019 at 19:21):

They do come from the same source, but some fluke of the serialization process is causing them to behave differently. We could probably chase it and fix it, but it'd fall pretty far down the priority list.

view this post on Zulip Grahame Grieve (May 16 2019 at 22:33):

I'll add it to my list at some stage


Last updated: Apr 12 2022 at 19:14 UTC