FHIR Chat · Connectathon Conditional Reference Stream

Stream: implementers

Topic: Connectathon Conditional Reference Stream

Grahame Grieve (May 08 2016 at 11:12):

from the example:

<Bundle xmlns="http://hl7.org/fhir">
   <id value="20160113160203" />
   <type value="transaction" />
   <entry>
     <fullUrl value="urn:uuid:c72aa430-2ddc-456e-7a09-dea8264671d8" />
     <resource>
       <Observation>
         <subject>
            <reference value="Patient?identifier=12345"/>
         </subject>
         <--! rest of resource omitted -->
       </Observation>
     </resource>
     <request>
       <method value="CREATE" />
     </request>
   </entry>
 <Bundle>

Grahame Grieve (May 08 2016 at 11:12):

the method is wrong - it should be POST in this case

Richard Ettema (May 08 2016 at 11:49):

The deployed fixtures in Touchstone all have POST as the method. So this is just a correction needed on the proposal page.

Richard Ettema (May 08 2016 at 12:15):

@James Agnew and @Simone Heckmann, I have redeployed the conditional reference test definitions to Touchstone for nomatch and multimatch to error out on a 404 and 412 respectively.

James Agnew (May 08 2016 at 13:03):

@Simone Heckmann I've now redeployed our server too with the correct codes. Do you mind to try testing again?

Simone Heckmann (May 08 2016 at 13:19):

Interesting. How did this ever work!? :D I fixed the Wiki.

Simone Heckmann (May 08 2016 at 13:19):

@James Agnew : I get a 404 on the multimatch. Other than that, HAPI passes all tests.

Richard Ettema (May 08 2016 at 13:21):

When I built the TestScripts and fixtures I fixed the transaction Bundles... and then I forgot to tell you.

Simone Heckmann (May 08 2016 at 13:23):

Ah. That explains it :)
I already suspected James to have some kind of "do what i mean"-algorithm implemented :D :D :D

Simone Heckmann (May 08 2016 at 13:44):

@Grahame Grieve : Grahame's server passed as well, however in his case I get a 202 if the transaction was successful, James returns 200 (and thats also what the test script expects). Which is correct? Should the Test script accept both?

James Agnew (May 08 2016 at 13:56):

In that case, the test script should accept both I would say.

James Agnew (May 08 2016 at 13:59):

2xx codes all indicate success, so 202 and 200 would both be fine

James Agnew (May 08 2016 at 13:59):

However, I can't replicate the 404 for multimatch... I'm seeing 412 when I do it. That's strange!

Simone Heckmann (May 08 2016 at 14:00):

Except, the spec says:
"For a transaction, servers SHALL either accept all actions and return a 200 OK, along with a response bundle (see below), or reject all resources and return an HTTP 400 or 500 type response."

Simone Heckmann (May 08 2016 at 14:01):

@James Agnew : give me a second, I'll run the scipt again...

James Agnew (May 08 2016 at 14:02):

Heh, that's true. Spec should probably be less strict about that....

James Agnew (May 08 2016 at 14:02):

ps, just restarting my server, it will be down for a second

Simone Heckmann (May 08 2016 at 14:06):

Yes. It's not a mix up of the return codes with the 404, it's a problem with our conditional URL:
"diagnostics":"Invalid match URL \"Patient?family=van%20de%20Heuvelcx85ioqWJbI%38given=Pietercx85ioqWJbI\" - No resources match this search"

Simone Heckmann (May 08 2016 at 14:06):

This URL really matches 0 patients, even though the fixtures habe been created successfully

Simone Heckmann (May 08 2016 at 14:07):

The URL /Patient?given=Pietercx85ioqWJbI returns 2 results

Simone Heckmann (May 08 2016 at 14:08):

It's actually %38-Character! If I replace it with "&" the URL is ok.

James Agnew (May 08 2016 at 14:09):

Ah yeah, that makes sense... That & shoudn't be escaped

Simone Heckmann (May 08 2016 at 14:17):

Oh. So this is an issue. XML doesn't allow unescaped & character. It will have to be & in the URL string

Simone Heckmann (May 08 2016 at 14:19):

With HAPI, the JSON version passes now, but the XML Version gives:
"diagnostics":"Failed to parse match URL[Patient?family=van%20de%20Heuvelcx85ioqWJbI&given=Pietercx85ioqWJbI] - Resource type Patient does not have a parameter with name: amp;given"