Stream: committers
Topic: task 10075 extension invariants
Grahame Grieve (Jul 22 2016 at 00:02):
task GF#10075 - I'm not following this one - looks like the information is out of date, and I'm not sure what the source is trying to do. Can @Rob Hausam or @Lloyd McKenzie clarify?
Lloyd McKenzie (Jul 22 2016 at 01:08):
Look at this: http://hl7.org/fhir/extension-allergyintolerance-resolutionage.html
Then look at this: http://hl7-fhir.github.io/extension-allergyintolerance-resolutionage.html
ext-1 is new for STU3. The other two should still exist, but they're not appearing
Rob Hausam (Jul 22 2016 at 01:10):
Yes, I was just about to post the same examples.
Grahame Grieve (Jul 22 2016 at 01:10):
I don't see them in the spreadsheet
Lloyd McKenzie (Jul 22 2016 at 02:05):
allergyintolerance-extensions-spreadsheet, Extensions-Inv tab
Lloyd McKenzie (Jul 22 2016 at 02:05):
"code or substanceExposureRisk"
Grahame Grieve (Jul 22 2016 at 02:40):
and what has that to do with any of the extensions?
Lloyd McKenzie (Jul 22 2016 at 04:30):
"If the substanceExposureRisk extension element is present, the AllergyIntolerance.code element must be omitted."?
Rob Hausam (Jul 22 2016 at 04:31):
question on that?
Rob Hausam (Jul 22 2016 at 04:33):
not sure that the references and the rest of the syntax is all entirely correct (or even allowed), but I tried to get as close as possible, and it didn't complain at me - @Lloyd McKenzie I was actually going to ask you to look at it at some point and see what I needed to tweak
Grahame Grieve (Jul 22 2016 at 05:17):
so this is all confusing. The claim wsa that there is constraints for two extensions which aren't showing, but I don't see them
Grahame Grieve (Jul 22 2016 at 05:17):
there is an invariant but it has no extension as context, so the build ignores it
Lloyd McKenzie (Jul 22 2016 at 09:27):
The build used to not ignore it. If it needs to be updated to have a different context, that's doable. Also, the one from Quantity is gone too.
Grahame Grieve (Jul 22 2016 at 09:30):
which one from quantity?
Lloyd McKenzie (Jul 22 2016 at 09:34):
From STU2:
qty-3: On Extension.valueQuantity: If a code for the unit is present, the system SHALL also be present (xpath on f:Extension/f:valueQuantity: not(exists(f:code)) or exists(f:system))
Grahame Grieve (Jul 22 2016 at 09:44):
umm
Grahame Grieve (Jul 22 2016 at 09:44):
it's still present every where it should be
Lloyd McKenzie (Jul 22 2016 at 09:52):
So it shouldn't show up on extensions with a type of Age?
Grahame Grieve (Jul 22 2016 at 11:08):
it should. that's a snapshot generation problem
Rob Hausam (Jul 22 2016 at 13:53):
yes - if we need to change/add the context, that's fine - just need to know that's what's needed
Grahame Grieve (Jul 22 2016 at 20:47):
the context must be exactly the same as the 'code' for the extension in the spreadsheet, and then the invariant will be added to the extension - otherwise the invariant will be ignored
Rob Hausam (Jul 23 2016 at 04:33):
Thanks for that clarification, @Grahame Grieve It seems that this behavior changed at some point following STU3 candidate, but as long as it's clear and understood (which it obviously wasn't for me), it's not a problem. My invariants are showing up now (only on my local build at the moment), so that's great. Now I just need to verify that the XPath (shouldn't we be using FluentPath now?) is correct so that they actually work as intended - I'm pretty sure that some of the references aren't correct at the moment.
Grahame Grieve (Jul 23 2016 at 04:35):
we are transitioning to XPath. For now, both are required
Rob Hausam (Jul 23 2016 at 04:48):
you mean transitioning to FluentPath?
that's what I thought, but didn't really know both were required - and is that actually true at this point for invariants?
the FHIR Spreadsheet Authoring Wiki page doesn't seem to reflect all of that guidance - and that threw me off
Rob Hausam (Jul 23 2016 at 04:50):
can't say I'm particularly surprised that documentation lags behind - but it's good to find out
Grahame Grieve (Jul 23 2016 at 22:38):
is this resolved, now that I am generating the inherited constraints on Age etc?
Rob Hausam (Jul 25 2016 at 03:35):
I suspect it is resolved, Grahame, but I haven't necessarily been able to verify that yet
Grahame Grieve (Jul 25 2016 at 04:27):
ok
Last updated: Apr 12 2022 at 19:14 UTC
