Stream: committers
Topic: stronger build errors+warnings
Lloyd McKenzie (Dec 16 2016 at 03:30):
Well, some become warnings, some become information
Josh Mandel (Dec 16 2016 at 11:49):
Wait, which suppressedwarnings become informations?
Lloyd McKenzie (Dec 16 2016 at 16:26):
In the spreadsheet if it says "information (was warning)" in the first column and "information" in the second column, then it becomes information. If the second column says "warning", then it becomes a warning. But when we're done, there shouldn't be any suppressed warnings anymore.
Josh Mandel (Dec 16 2016 at 18:31):
When the spreadsheet says "information (was warning)", it looks like the codebase already *uses* the information level, so there's nothing to do.
Lloyd McKenzie (Dec 16 2016 at 21:37):
If the codes says suppressedWarning and we say "information" we should change the call to be explicitly information rather than suppressedWarning - when we're done we don't want any suppressedWarning invokations anymore
Josh Mandel (Dec 16 2016 at 22:27):
Yes, but that's different from what I was asking :-)
Josh Mandel (Dec 16 2016 at 22:27):
You're not saying that suppressedWarning should appear *nowhere* in the code base, right?
Grahame Grieve (Dec 16 2016 at 22:33):
too many double negatives...
Grahame Grieve (Dec 16 2016 at 22:33):
when we're done, suppressedWarning should be gone
Josh Mandel (Dec 16 2016 at 22:49):
suppressedWarning should be gone from everywhere in the code base, or just from the places the spreadsheet has identified?
Josh Mandel (Dec 16 2016 at 23:06):
After implementing the changes from the spreadsheet I see still:
$ grep -ril suppressedwarning .
./tools/java/org.hl7.fhir.tools.core/src/org/hl7/fhir/definitions/validation/ValueSetValidator.java
./tools/java/org.hl7.fhir.tools.core/src/org/hl7/fhir/definitions/validation/ResourceValidator.java
./implementations/java/org.hl7.fhir.validation/src/org/hl7/fhir/dstu2/validation/BaseValidator.java
./implementations/java/org.hl7.fhir.validation/src/org/hl7/fhir/dstu3/validation/BaseValidator.java
Josh Mandel (Dec 16 2016 at 23:17):
Before I commit, here's a list of things that will break. @Grahame Grieve or @Lloyd McKenzie could you review and give the :thumbsup:?
[java] ERROR @ AllergyIntolerance Resource AllergyIntolerance (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ AuditEvent Resource AuditEvent (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Bundle Resource Bundle (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ CapabilityStatement Resource CapabilityStatement (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ CarePlan Resource CarePlan (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Claim Resource Claim (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ClaimResponse Resource ClaimResponse (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Communication Resource Communication (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ CommunicationRequest Resource CommunicationRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Composition Resource Composition (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ConceptMap Resource ConceptMap (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Condition Resource Condition (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Contract Resource Contract (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Coverage Resource Coverage (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DataElement Resource DataElement (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DetectedIssue Resource DetectedIssue (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Device Resource Device (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DeviceComponent Resource DeviceComponent (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DeviceMetric Resource DeviceMetric (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DiagnosticReport Resource DiagnosticReport (FMM=3) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DiagnosticRequest Resource DiagnosticRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DocumentManifest Resource DocumentManifest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ DocumentReference Resource DocumentReference (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ EligibilityRequest Resource EligibilityRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ EligibilityResponse Resource EligibilityResponse (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Encounter Resource Encounter (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ EpisodeOfCare Resource EpisodeOfCare (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ExplanationOfBenefit Resource ExplanationOfBenefit (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ FamilyMemberHistory Resource FamilyMemberHistory (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Flag Resource Flag (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Goal Resource Goal (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Group Resource Group (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ HealthcareService Resource HealthcareService (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ImagingManifest Resource ImagingManifest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ImagingStudy Resource ImagingStudy (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Immunization Resource Immunization (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ImmunizationRecommendation Resource ImmunizationRecommendation (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ List Resource List (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Medication Resource Medication (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ MessageHeader Resource MessageHeader (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ NamingSystem Resource NamingSystem (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Observation Resource Observation (FMM=3) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ OperationDefinition Resource OperationDefinition (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ PaymentNotice Resource PaymentNotice (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ PaymentReconciliation Resource PaymentReconciliation (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Procedure Resource Procedure (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ProcedureRequest Resource ProcedureRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ProcessRequest Resource ProcessRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ProcessResponse Resource ProcessResponse (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Provenance Resource Provenance (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ QuestionnaireResponse Resource QuestionnaireResponse (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ReferralRequest Resource ReferralRequest (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ StructureDefinition Resource StructureDefinition (FMM=2) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Subscription Resource Subscription (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ Substance Resource Substance (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ ValueSet Resource ValueSet (FMM=3) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
[java] ERROR @ VisionPrescription Resource VisionPrescription (FMM=1) cannot have a FMM level >1 if it has warnings (src = ResourceValidator)
Lloyd McKenzie (Dec 16 2016 at 23:24):
I think the plan is to force all of those resoruces to be FMM 0 and then tell the WGs to fix the warnings - so we don't have to wait for everyone to fix before the build works.
Lloyd McKenzie (Dec 16 2016 at 23:24):
If there are issues that weren't dealt with in our list, then those ones will stay as is until the FMG has a chance to revisit this topic.
Josh Mandel (Dec 16 2016 at 23:25):
so do you want me to set all of these resources to FMM0 first?
Josh Mandel (Dec 16 2016 at 23:37):
Also: when I look at the first one (AllergyIntolerance) in source/allergyintolerance/allergyintolerance-spreadsheet.xml I see "fmm 0". Is the levle being set to 1 elsewhere?
Grahame Grieve (Dec 17 2016 at 06:16):
fhir.ini, I believe
Grahame Grieve (Dec 19 2016 at 22:48):
hmm, so now, every resource bar 1 has FMM level = 1 or 0. This is rather a sub-optimal outcome, because people actually use these FMM levels to determine where we are
Lloyd McKenzie (Dec 20 2016 at 00:00):
We definitely need to get the warnings to be taken care of soon. What warnings are causing people the most grief?
Grahame Grieve (Dec 20 2016 at 00:05):
I don't know. I just know that people use those numbers to reflect our status, and they don't do so right now
Melva Peters (Dec 20 2016 at 19:43):
Is the maturity level on the resource supposed to be reflective of the maturity level in the FHIR Resource QA Tracker? If so, I'm not sure the resource maturity in the Current Build is reflecting that.
Grahame Grieve (Dec 20 2016 at 20:07):
it's not. all the FMMs have been downgraded per FMG decision to enforce warnings. If you want to get it back to where it's supposd to be, you have to deal with the warnings
Last updated: Apr 12 2022 at 19:14 UTC
