Stream: committers
Topic: status
Michelle (Moseman) Miller (Oct 27 2018 at 03:39):
I'm trying to apply GF#17756 (which replaces Goal.status with 2 new status elements). I did update status-codes.xml where mappings were possible. I have the following questions:
1-If I have some new status elements that don't align with current columns, should I add new columns or just don't map them?
2-If I removed some values that result in a blank column (e.g. nothing maps to the canonical behind-target anymore), should I remove the column?
3-My local build is failing with a sclist error. If it isn't related to 1 or 2 above, any other tips on what else I should check?
[java] Error: Unable to process sclist (2): Goal.status [java] java.lang.Exception: Unable to process sclist (2): Goal.status
Goal.status is no longer a valid element, but I don't know where sclist is getting Goal.status from.....
Grahame Grieve (Oct 27 2018 at 07:56):
from status-codes.xml?
Grahame Grieve (Oct 27 2018 at 07:56):
if it includes 'status' in the name, it needs to be in status-codes.xml. If you don't have sensible mappings, we should talk about it here
Michelle (Moseman) Miller (Oct 27 2018 at 11:55):
Correct, I had modified status-codes (for both lifecycleCycle and achievementStatus). The new Goal.achievementStatus codes that I didn't find mappings for include:
- improving
- worsening
- no-change (in the trend)
- not-achieved
- no-progress
- not-attainable
In hindsight, should I map all of the last 3 to not-done?
Should I delete the ahead of target and behind target columns since there are no mappings left there?
Michelle (Moseman) Miller (Oct 27 2018 at 12:23):
BTW, I modified status-codes.xml (changing goal.status to lifecycleStatus and achievementStatus) and was still getting the build failure I noted above. Not sure where sclist is getting Goal.status from since it is no longer in status-codes.xml anymore
Grahame Grieve (Oct 27 2018 at 17:09):
improving + worsening + no-change --> active
not-achieved --> abandoned ?
not-attainable --> abandoned
How is no-progress different to no-change?
@Lloyd McKenzie c12, c16, c32 are pretty poorly differentiated to me - can you comment?
Lloyd McKenzie (Oct 27 2018 at 19:21):
Cancelled = never started. Stopped = started, not completed. Both deal with the "request" side. Not done = event side, capturing that the record is a record of something that didn't occur rather than a record of something that did.
Grahame Grieve (Oct 27 2018 at 19:24):
are the definitions and existing mappings consistent with your definitions?
Lloyd McKenzie (Oct 27 2018 at 19:35):
I'd have expected to see "not-done" on Procedure - it only has "aborted", which implies started, but didn't finish. Observation is also missing "not-done". Recording observations that weren't performed is pretty essential in the clinical research space. Not sure how those are expecting to be handled. @Eric Haas? However, in general, the mappings look pretty reasonable. Certainly in the patterns, the definitions are clear.
Grahame Grieve (Oct 27 2018 at 19:42):
but they are not consistent with the definitions here:
Grahame Grieve (Oct 27 2018 at 19:42):
http://build.fhir.org/valueset-resource-status.html
Grahame Grieve (Oct 27 2018 at 19:42):
which is what I was asking about
Lloyd McKenzie (Oct 27 2018 at 19:50):
Agree that the statuses there are not well distinguished. (And not-done isn't even present)
Michelle (Moseman) Miller (Oct 27 2018 at 20:39):
no change = The goal is being sought, but the trend is flat; on-change parent is in-progress
no-progress = The goal has not been met and little to no progress towards target; not really started yet
Michelle (Moseman) Miller (Oct 27 2018 at 20:48):
I agree with your recommendations for
- improving + worsening + no-change --> active
- not-attainable --> abandoned
However, I don't think not-achieved --> abandoned
not-achieved is an achievement status saying the goal is not achieved (yet), but I wouldn't consider not-achieved a terminal status like I think is conveyed with abandoned (e.g. no further action is planned).
Michelle (Moseman) Miller (Oct 27 2018 at 20:54):
I would prefer mapping:
- not-achieved, no-progress --> not-done
I don't see not-done in http://build.fhir.org/valueset-resource-status.html even though it is in the status-codes.xml
Michelle (Moseman) Miller (Oct 27 2018 at 20:57):
What about the build error? I'm still scratching my head about where else I need to reflect that the basic Goal.status is no longer valid. I already removed it from the goal-spreadsheet as well as status-codes.xml
[java] Error: Unable to process sclist (2): Goal.status
[java] java.lang.Exception: Unable to process sclist (2): Goal.status
Grahame Grieve (Oct 27 2018 at 21:02):
<%sclist Goal.status%> in lifecycle.html
Grahame Grieve (Oct 27 2018 at 21:02):
not-done should appear once you map something to it
Eric Haas (Oct 27 2018 at 21:03):
Cancelled => aborted in O and DR
Eric Haas (Oct 27 2018 at 21:04):
cancelled => not-done too
Eric Haas (Oct 27 2018 at 21:07):
See the definition of cancellef
Michelle (Moseman) Miller (Oct 27 2018 at 21:24):
not-done has existing mappings (from other statuses throughout the spec), and it isn't showing up yet.
I'll take a look at lifecycle.html
Last updated: Apr 12 2022 at 19:14 UTC
