Stream: committers
Topic: phd review
Grahame Grieve (Mar 25 2019 at 02:35):
@Brian Reinhold just making last minute checks for publication - can you check the publication review section at the top of https://build.fhir.org/ig/HL7/PHD/qa.html
Brian Reinhold (Mar 25 2019 at 11:49):
Brian Reinhold just making last minute checks for publication - can you check the publication review section at the top of https://build.fhir.org/ig/HL7/PHD/qa.html
@Grahame Grieve I assume you mean these two items:
History Page 'history.html' is wrong (ig.json#paths/history) - must be 'http://hl7.org/fhir/uv/phd/history.html' or 'http://hl7.org/fhir/uv/phd/history.cfml'
package-list.json: file not found in /scratch/ig-build-temp-CTXASE/repo
If so, they are generated by the Framework. I will need to ask Lloyd how to make these modifications.
Brian Reinhold (Mar 25 2019 at 13:43):
Brian Reinhold just making last minute checks for publication - can you check the publication review section at the top of https://build.fhir.org/ig/HL7/PHD/qa.html
@Grahame Grieve Made the package with help and info from David Pyke. Question, what should the version number be? The first two were 0.1.0 and 0.2.0. I assumed 0.3.0 and went with that. Should it be something else?
Grahame Grieve (Mar 25 2019 at 19:01):
yes 0.3.0 is right
Grahame Grieve (Mar 25 2019 at 23:17):
@Brian Reinhold PHD looks like it's all god except for ${ballotstatus} in the header - what's with that?
Brian Reinhold (Mar 25 2019 at 23:28):
Brian Reinhold PHD looks like it's all god except for ${ballotstatus} in the header - what's with that?
I am at a loss ... I don't recall seeing that locally. I am at home now. I will try rebuilding it here locally. What is the source of that text?
Grahame Grieve (Mar 25 2019 at 23:29):
build.xml? I didn't really follow what it was doing.... where did it come from?
Brian Reinhold (Mar 25 2019 at 23:36):
build.xml? I didn't really follow what it was doing.... where did it come from?
Its also in the local build. The changes I made were the package-list.json and the update of an igToConfig.xslt
In fact, I got the xslt from David Pyke. I also got one from Lloyd and I just found they were different. I will try building with Lloyd's and see if that fixes it.
News flash ... it does not
@Lloyd McKenzie How am I getting this in the top row of the PHD IG header (above the red menu bar)?
PhdImplementationGuide 0.3.0 - ${ballotstatus}
THe only changes I made today were the update of the xslt and the addition of the package-list.json file.
Grahame Grieve (Mar 25 2019 at 23:49):
It’s been there for a long time on the ci build
Brian Reinhold (Mar 25 2019 at 23:51):
It’s been there for a long time on the ci build
Oh ... never noticed. Is it looking for some field to be placed in an xml that I did not put in? Not sure where the source of that 'PhdImplementationGuide' is ... there are lots of them!
Lloyd McKenzie (Mar 26 2019 at 00:06):
ballotStatus should be coming from your ini file
Lloyd McKenzie (Mar 26 2019 at 00:07):
You may have deleted the line because you weren't balloting, but you always need something there.
Lloyd McKenzie (Mar 26 2019 at 00:07):
Take a look at SDC for an example of what to say.
Brian Reinhold (Mar 26 2019 at 08:25):
Take a look at SDC for an example of what to say.
That may be the issue ... I don't have an ini file at all (there is one in src-generated but the contents of that are re-directs). There is a properties.txt file in /src which has suspicious items in it. It has no ballot or status entry but it has other entries like version, copyright, license, etc.. I can see I took that file directly from you genomics-reporting project (when I started this one) and changed the contents to match this guide. But I did not add or remove any entries.
Its the properties.txt file I need to add the ballot status line to. That fixed the issue.
Brian Reinhold (Mar 26 2019 at 11:23):
It’s been there for a long time on the ci build
@Grahame Grieve Fixed it
Last updated: Apr 12 2022 at 19:14 UTC
