Stream: committers
Topic: phcp review
Grahame Grieve (Mar 25 2019 at 02:52):
@Rick Geimer can you look at the HL7 publication checks at the top of https://build.fhir.org/ig/HL7/PhCP-r4/qa.html please
Grahame Grieve (Mar 25 2019 at 03:14):
@Rick Geimer this also has issues with regard to publication readiness
Grahame Grieve (Mar 25 2019 at 03:16):
also, the header - "PharmacistServicesAndSummariesPhCP " - we can do better than that. And the footer needs work still
Rick Geimer (Mar 25 2019 at 20:22):
Will fix after FHIR-I
Grahame Grieve (Mar 25 2019 at 23:30):
@Rick Geimer getting close. You have the same name/title problem in the header that @Eric Haas and @Nagesh Bashyam were working on, and your footer needs updating per the changes made for... say patient-reported-outcomes
Grahame Grieve (Mar 25 2019 at 23:31):
otherwise ok
Eric Haas (Mar 25 2019 at 23:50):
replace
'{{ site.data.fhir.igName }}' with '{{site.data.fhir.ig.title}}' in the header file
and that should do it assuming your ig.xml has a title element
Rick Geimer (Mar 26 2019 at 01:08):
@Sean McIlvenna Please see the notes above as we should change this for all Trifolia on FHIR generated output (for today I will hack manually).
Rick Geimer (Mar 26 2019 at 01:56):
@Grahame Grieve I believe I have addressed all the header/footer issues now. Let me know if anything else is needed.
Grahame Grieve (Mar 26 2019 at 04:24):
@Rick Geimer - almost; the build still says 'CI Build' not what ballot it is
Rick Geimer (Mar 26 2019 at 05:52):
Fixed
Last updated: Apr 12 2022 at 19:14 UTC
