Stream: committers
Topic: new template - IG table
John Moehrke (Feb 17 2022 at 12:32):
@Lloyd McKenzie I get the new headers not just on artifact pages, but also my main index.html. this does not seem to happen on the IG build.
John Moehrke (Feb 17 2022 at 12:33):
John Moehrke (Feb 17 2022 at 12:35):
I am not sure that I dislike this, but it does not show up on my other IGs, and this IG built on the ci-build don't have it. Just my local build.
John Moehrke (Feb 17 2022 at 12:35):
e.g,. on the ci-build http://build.fhir.org/ig/IHE/FormatCode/branches/moehrke-patch-Rad/index.html
John Moehrke (Feb 17 2022 at 12:37):
the github repo for this IG is https://github.com/IHE/FormatCode
Do others get this on their local build?
John Moehrke (Feb 17 2022 at 12:40):
ig-extra.png -- with a red highlight on the new headers.
John Moehrke (Feb 17 2022 at 12:40):
they do not show on the other narrative pages. and do show fine on artifiacts.
Lloyd McKenzie (Feb 17 2022 at 15:21):
The metadata for the IG only shows on the home page of the IG. I get it on both local build and CI build...
John Moehrke (Feb 17 2022 at 17:25):
it is not showing up on ci builds.
John Moehrke (Feb 17 2022 at 17:27):
it is not showing up locally on my other projects.
John Moehrke (Feb 17 2022 at 17:28):
so... either you and I are looking at different things (I circled above), or there is something not working consistently.
Lloyd McKenzie (Feb 17 2022 at 19:51):
This is a CI build - and it's showing up: http://build.fhir.org/ig/HL7/sdc/
To get it, you need to be using the #current release.
John Moehrke (Feb 17 2022 at 21:35):
so why does it show this on my computer build, but not on the ci build? is this just a lag?
Lloyd McKenzie (Feb 17 2022 at 23:39):
Dunno. Have you pushed your local build to the CI-build?
John Moehrke (Feb 18 2022 at 00:12):
yup
John Moehrke (Feb 18 2022 at 00:12):
freshly built this after noon -- http://build.fhir.org/ig/IHE/FormatCode/
John Moehrke (Feb 18 2022 at 00:29):
just freshly built again... no version headers on the index page.
John Moehrke (Feb 18 2022 at 00:38):
also don't get it with template fhir.base.template
John Moehrke (Feb 18 2022 at 00:38):
I can't build with hl7.fhir.template, it fails at the end.
John Moehrke (Feb 18 2022 at 00:46):
tried fhir.base.template on the ci builder, and no version headers.
John Moehrke (Feb 18 2022 at 00:47):
to be clear.... I am not seeing the other HL7 IGs have this version thing on index.html... but they are okay on the artifacts (as am I).
John Moehrke (Feb 18 2022 at 00:56):
if I force #current and the ihe template... then I get the index.html page yellow table.. See current ci-build
John Moehrke (Feb 18 2022 at 00:56):
so, is this change to index.html not released, but the artifacts stuff released?
Lloyd McKenzie (Feb 18 2022 at 15:06):
I didn't think any of the table stuff was 'released' yet. It should only be available with #current
Jose Costa Teixeira (Feb 21 2022 at 19:43):
well, IHE template is based on #current
Jose Costa Teixeira (Feb 21 2022 at 19:43):
https://github.com/IHE/ihe-ig-template/blob/master/package/package.json#L10
John Moehrke (Feb 21 2022 at 19:50):
so all of the templates use current, just like IHE does.
Lloyd McKenzie (Feb 21 2022 at 19:52):
A released template can't be based on #current - at least not as far as I'm aware...
John Moehrke (Feb 21 2022 at 21:40):
I think Grahame indicated that he magjic changes those currents to the latest formal release.. but I am not sure
Grahame Grieve (Feb 21 2022 at 23:02):
yes I do.
Grahame Grieve (Feb 21 2022 at 23:02):
there's no reference to current in the released templates, but all the current templates depend on current - though that's not requied
John Moehrke (Feb 22 2022 at 22:30):
@Lloyd McKenzie and I worked on this today, and found the problem. The new template now can add the same header to index that are authored in markdown.... I was seeing it only on IGs with index authored in xml.
John Moehrke (Feb 22 2022 at 22:30):
so, @Lloyd McKenzie the new build of base did work for me.
John Moehrke (Feb 22 2022 at 22:32):
still a mystery as to why your new current release is what my builds take when I am not calling for current.
Templates: ihe.fhir.nonum.template#0.0.1 -> ihe.fhir.template#0.5.0 -> fhir.base.template#0.2.2
John Moehrke (Feb 22 2022 at 22:33):
so your fix is showing up as fhir.base.template 0.2.2
Last updated: Apr 12 2022 at 19:14 UTC
