Stream: committers
Topic: isModifier review
Grahame Grieve (Mar 15 2017 at 22:42):
I've just reviewed all the elements labeled isModifier = true. Here's my findings:
Patient - see task 13064
Knowledge resources - see task 13060
Resource.implicitRules - added "This element is labelled as a modifier because the implicit rules may provide additional knowledge about the resource that modifies it's meaning or interpretation"
.{*}status elements - add "This element is labeled as a modifier because the status contains [list of relevant codes] that mark an account as not currently valid'
Basic.code - add "This element is labeled as a modifier because the it defines the meaning of the resource and cannot be ignored'
.active - add "This element is labeled as a modifier because it may be used to mark that the {tthing} was created in error'
.intent - add "This element is labeled as a modifier because the intent alters when and how the {thing} is actually applicable'
CarePlan.activity.detail.prohibited - add "This element is labeled as a modifier because it marks an action as an action not to take'
Communication.notDone - add "This element is labeled as a modifier because it marks the communication as a communication that did not occur'
Composition.confidentiality - add "This element is labeled as a modifier because highly confidential documents must not be treated as if they are not'
Composition.section.mode, List.mode - add "This element is labeled as a modifier because a change list must not be mis-understood as a complete list'
ConceptMap.group.element.target.equivalence - add "This element is labeled as a modifier because it may indicate that a target does not apply'
DocumentReference.relatesTo - add "This element is labeled as a modifier because documents that append to other documents are incomplete on their own'
FamilyMemberHistory.notDone - referred to PC for improving documentation
FamilyMemberHistory.estimatedAge - should not be a modifier
*.notGiven + MedicationStatement.taken + Procedure.notDone - add "This element is labeled as a modifier because it indicates that an {title} didn't happen'
List.entry.deleted - add "This element is labeled as a modifier because it indicates that an item is (to be) no longer in the list'
Location.mode - should not be a modifier
MedicationRequest.priority - should not be a modifier
MedicationRequest.substitution.allowed - add "This element is labeled as a modifier because whether substitution is allowed or not cannot be ignored'
MessageHeader.event - should not be a modifier
MessageHeader.response - should not be a modifier
MessageHeader.response.code - should not be a modifier
ProcedureRequest.doNotPerform - add "This element is labeled as a modifier because it indicates that an {title} shouldn't happen, instead of a request for it to happen'
Questionnaire.item.enableWhen - add "This element is labeled as a modifier because it indicates that the item should not be enabled unless the condition is met'
TestReport.result - should not be a modifier
ValueSet.compose.include.filter - should not be a modifier
I will create tasks for the ones that should not be a modifier, and propose to just add the doco for the rest. Please review @Michelle (Moseman) Miller @Rob Hausam @Lloyd McKenzie @Melva Peters @Scott Robertson @Rick Geimer @Bryn Rhodes @Richard Ettema @Anthony(Tony) Julian @Brian Postlethwaite
Melva Peters (Mar 15 2017 at 22:45):
@Grahame Grieve for the ones that should not be modifiers, do we need FMG approval to change? I assume the ones that need additional documentation can be changed without FMG approval?
Grahame Grieve (Mar 15 2017 at 22:46):
yes we can change doco with needing FMG approval. I can change them, or you can change them.
For the ones that should not be modifiers - FMG is discussing whether that's a substantiative change right now
Grahame Grieve (Mar 15 2017 at 22:48):
generic task GF#13065 for adding the documentation note (to the comments field)
Michelle (Moseman) Miller (Mar 15 2017 at 23:08):
Regarding FamilyMemberHistory.estimatedAge - (which you said should not be a modifier) -- I just want to double check....this is a Boolean element that tells you how to interpret another element named age. It was added as part of GF#10008, which @Lloyd McKenzie had commented would be a modifier element.
Rob Hausam (Mar 15 2017 at 23:10):
so you will be letting us know when and if it's OK to remove "Is Modifier" from the "should not be" ones?
Grahame Grieve (Mar 15 2017 at 23:23):
Lloyd disagrees with me on this one. It's in the grey zone. The issues with FamilyMemberhistory.notDone are bigger.
Grahame Grieve (Mar 15 2017 at 23:23):
I've created tasks for all the rest of the 'propose to remove' ones.
Lloyd McKenzie (Mar 15 2017 at 23:42):
For status, I presume you've changed "Account" to the name of the respective resource for each status description?
Grahame Grieve (Mar 15 2017 at 23:43):
i yes I would. overlooked that when I changed it to a template to use
Lloyd McKenzie (Mar 15 2017 at 23:45):
Estimated age can/should change the results of any algorithm that calculates based on the specified age - rather than getting a "definitely had condition at this time" turns into a probabalistic maybe. So you're treating another element differently based on the value of this element
Last updated: Apr 12 2022 at 19:14 UTC
