Stream: committers
Topic: invalid search parameters
Brian Postlethwaite (Dec 05 2018 at 06:17):
I've found 2 invalid search parameters....
Group value and Observation combo-value-quantity
These both have an issue in the expression where the operator precedence in fhir has | ahead of as, hence they shouldn't compile.
Group.characteristic.value as CodeableConcept | Group.characteristic.value as boolean
Brian Postlethwaite (Dec 05 2018 at 06:18):
Relevant part of http://hl7.org/fhirpath/ is section 6.8
If this operator precedence is wrong, then its a fhirpath bug...
Brian Postlethwaite (Dec 05 2018 at 06:21):
(apart from this all the search expressions seem to be valid to the dotnet implementation)
Brian Postlethwaite (Dec 05 2018 at 12:26):
Complete list of invalid search parameter definitions (with this issue)
Group: Value
Observation: combo-value-quantity, component-value-quantity, value-quantity, value-string
@Grahame Grieve , @Bryn Rhodes, @Ewout Kramer is my understanding of the fhirpath here correct?
Eric Haas (Dec 05 2018 at 18:20):
we are we at with the build freeze, I can look at making technical corrections to the Obs SP?
assuming the fix is:
Group.characteristic.value as CodeableConcept | Group.characteristic.value as boolean
to
(Group.characteristic.value as CodeableConcept) | (Group.characteristic.value as boolean)
Grahame Grieve (Dec 05 2018 at 20:00):
I wish it was incorrect but it doesn't look like you are
Grahame Grieve (Dec 05 2018 at 20:00):
yes that is the fix, and please make it
Grahame Grieve (Dec 05 2018 at 20:00):
that's why we're at build freeze - so we find and fix things like this
Brian Postlethwaite (Dec 05 2018 at 20:15):
Thanks. Are you going to do it Eric, otherwise I'll do them all as a single commit.
Eric Haas (Dec 05 2018 at 21:53):
I will do it
Eric Haas (Dec 05 2018 at 22:21):
committed should be in build soon
Brian Postlethwaite (Dec 05 2018 at 22:58):
Lol, we both did it. Mine first though. Sorry.
Good thing is we both did the same change :)
Last updated: Apr 12 2022 at 19:14 UTC
