Stream: committers
Topic: fresh build failed gradelw
Anthony(Tony) Julian (Feb 14 2022 at 17:46):
Did a fresh pull from github.
then build.sh
Running publication process now with args: '-svn -name 'Continuous Integration Build' -url http://build.fhir.org/ -nocheck'
./gradlew: line 186: unexpected EOF while looking for matching `"'
./gradlew: line 187: syntax error: unexpected end of file
Lloyd McKenzie (Feb 14 2022 at 18:08):
@Mark Iantorno
Mark Iantorno (Feb 14 2022 at 18:10):
Can you do a regular build?
Mark Iantorno (Feb 14 2022 at 18:10):
like ./gradlew build
Mark Iantorno (Feb 14 2022 at 18:10):
please try and let me know if there are issues
Anthony(Tony) Julian (Feb 14 2022 at 19:05):
/c/Users/ajj05/GitRepos/fhir (master)
$ ./gradlew build
./gradlew: line 186: unexpected EOF while looking for matching `"'
./gradlew: line 187: syntax error: unexpected end of file
Anthony(Tony) Julian (Feb 14 2022 at 19:16):
added a " to line 157 - now I have to install 64bit java:
Invalid maximum heap size: -Xmx12800M
The specified size exceeds the maximum representable size.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
Grahame Grieve (Feb 14 2022 at 19:32):
yes you'll need 64bit java
Anthony(Tony) Julian (Feb 14 2022 at 19:43):
updated https://confluence.hl7.org/display/FHIR/FHIR+Build+Process to specify 64bit.
Anthony(Tony) Julian (Feb 14 2022 at 19:44):
should JAVA_HOME be the JDK or jre
Anthony(Tony) Julian (Feb 14 2022 at 20:06):
Must not be holding my mouth right: ./gradlew build works fine.
./build.sh returns
Running publication process now with args: '-svn -name 'Continuous Integration Build' -url http://build.fhir.org/ -nocheck'
./gradlew: line 186: unexpected EOF while looking for matching `"'
./gradlew: line 187: syntax error: unexpected end of file
Anthony(Tony) Julian (Feb 14 2022 at 20:10):
I did git checkout gradelw to make sure I had the current version.
Anthony(Tony) Julian (Feb 14 2022 at 20:33):
currently executing publish.bat - been running for a while, so I will wait
Anthony(Tony) Julian (Feb 14 2022 at 22:41):
Now I am getting java heap error. bumping org.gradle.properties from -Xmx12800M to -Xmx25600M
Anthony(Tony) Julian (Feb 15 2022 at 15:05):
Still getting java heap error with Xmx25600M. Will try increasing virtual
David Pyke (Feb 15 2022 at 15:09):
How much memory does your system have?
Anthony(Tony) Julian (Feb 15 2022 at 15:41):
8gb physical, 9296M virtual
It is a vmware vm, so I could request more memory
Lloyd McKenzie (Feb 15 2022 at 15:49):
8 GB is really tight to build the core spec. I'd definitely ask for more memory. (I use 32GB)
Anthony(Tony) Julian (Feb 15 2022 at 15:53):
@Lloyd McKenzie Thanks - I will request it. Hopefully there is not too much red tape!
Anthony(Tony) Julian (Feb 15 2022 at 15:54):
Probably should consider publishing minimum requirements on the FHIR build page.
Anthony(Tony) Julian (Feb 15 2022 at 22:07):
Finally got it to work: According to the log it took
This was a Full Build 0.664 1689sec 1200MB
Grahame Grieve (Feb 15 2022 at 22:42):
that's a little bit slow
Vassil Peytchev (Feb 16 2022 at 05:04):
Seems to be normal for running inside a VMware virtual machine, I am not sure if there is any special tuning that can bring the core build performance closer to native speeds...
Anthony(Tony) Julian (Feb 16 2022 at 15:52):
There is a plan in place to move developer VDI's to a newer rack in the next couple of weeks. Currently using Intel Xeon E5-2690v4@2.6GHZ x 2 processors.
Anthony(Tony) Julian (Feb 16 2022 at 16:26):
probably a stupid question: I had a successful build, so I proceeded to edit messageheader.xlsx. Saved it, re-ran the build, and - presto - my changes are gone. What step did I miss? I followed the directions on https://confluence.hl7.org/display/FHIR/FHIR+Spreadsheet+Authoring
Grahame Grieve (Feb 16 2022 at 16:29):
it should work.
Grahame Grieve (Feb 16 2022 at 16:30):
what does the log say about messageheader.xlsx?
Anthony(Tony) Julian (Feb 16 2022 at 16:35):
looks like I should be changing \fhir\source\messageheader\messageheader-spreadsheet.xlsx instead of messageheader.xlsx?
Anthony(Tony) Julian (Feb 21 2022 at 19:13):
RE:
All commits to the "source" directory must reference a Jira tracker number related to the change being made.
Format is [#123] where 123 is the number of the change tracker item
is the reference in the commit notes, or used as the branch?
Lloyd McKenzie (Feb 21 2022 at 19:16):
Commit notes
Anthony(Tony) Julian (Feb 21 2022 at 19:33):
Are the branch rules documented somewhere
Lloyd McKenzie (Feb 21 2022 at 19:37):
Not sure we have a whole lot of 'rules' other than you can't commit directly to master.
Anthony(Tony) Julian (Feb 21 2022 at 20:06):
...resource QuestionnaireResponse 2.572 678sec 1680MB
Error generating narrative for example Lifelines: Cannot invoke "java.util.List.size()" because "answers" is null
Error generating narrative for example Glasgow Coma Score: Cannot invoke "java.io.File.mkdirs()" because the return value of "java.io.File.getParentFile()" is null
Error generating narrative for example LOINC USSG Family History Response: Cannot invoke "java.util.List.size()" because "answers" is null
java.lang.NullPointerException: Cannot invoke "java.util.List.size()" because "answers" is null
Anthony(Tony) Julian (Feb 23 2022 at 19:22):
Anybody else seen "C:\Users\AJJ05.MFAD\Documents\GitRepos\fhir\source\messageheader\messageheader-spreadsheet.xlsx not updated - open in excel"
I rebooted, and didnt launch excel , excel does not show open in task manager- and still get this.
On two separate hosts
Lloyd McKenzie (Feb 23 2022 at 19:48):
Try copying the file, then deleting the original, then renaming the copy back. If you can't delete, then something is holding it open...
Anthony(Tony) Julian (Feb 24 2022 at 20:03):
Is there a reason that *.xlsx is in the .gitignore? With that in there how do I update messageheader-spreadsheet.xlsx?
Grahame Grieve (Feb 24 2022 at 20:11):
yes you never commit the spreadsheet to git. it's built on the fly from the resources, or if it's date is more recent than the resources. the resources are updated from the spreadsheet
Anthony(Tony) Julian (Feb 24 2022 at 20:15):
so after modify the spreadsheet, and do a build, what do I commit to git
Grahame Grieve (Feb 24 2022 at 20:19):
whatever other files changed
Anthony(Tony) Julian (Feb 24 2022 at 20:21):
Thanks - that is what I get for not building for a while.
Last updated: Apr 12 2022 at 19:14 UTC
