FHIR Chat · examples-json.zip · committers

Stream: committers

Topic: examples-json.zip

Brian Postlethwaite (Aug 21 2018 at 01:13):

Umm, the generation of the json examples.zip is creating invalid content. It tacks the following meta onto all the files. (what's a label? Should that be a tag?)

  "meta": {
    "label": [
      {
        "system": "http://hl7.org/fhir/v3/ActReason",
        "code": "HTEST",
        "display": "test health data"
      }
    ]
  }

Brian Postlethwaite (Aug 21 2018 at 01:14):

The XML version of the file has it as a security tag

Brian Postlethwaite (Aug 21 2018 at 01:53):

And that security tag is not added in the correct place, it puts the meta property in before the id property. This is what is causing all the .net round trip unit tests to fail.
(ok, the change to permit exponents in decimal also needed fixing, but that's done now too)

Grahame Grieve (Aug 21 2018 at 01:54):

if the round trip is failing because of order issues, the round trip test is in error

Grahame Grieve (Aug 21 2018 at 01:55):

agree it should be 'tag' - will post an update

Brian Postlethwaite (Aug 21 2018 at 01:58):

Isn't the XML intended to be order specific?

Grahame Grieve (Aug 21 2018 at 01:58):

yes the xml is but you're asking about the json

Brian Postlethwaite (Aug 21 2018 at 01:58):

2 different issues.
The order issue is in the XML examples source. the tag is in the json examples source

Brian Postlethwaite (Aug 21 2018 at 01:59):

(I should have been more clear on that)

Grahame Grieve (Aug 21 2018 at 02:02):

hmm I thought I got that right.

Brian Postlethwaite (Aug 21 2018 at 03:23):

The json examples has the edge cases file, I can update that one.

Brian Postlethwaite (Aug 21 2018 at 03:23):

the binary property rename issue: content -> data

Brian Postlethwaite (Aug 21 2018 at 03:30):

Hmm, example observation decimal resource for the exponent format testing...
'-1.000000000000000000E+245'
Do others handle this level of granularity? that's a pretty big weight in grams

Brian Postlethwaite (Aug 21 2018 at 03:32):

The dotnet decimal type is only able to handle 28 decimal places... not 245!
http://csharpindepth.com/articles/general/decimal.aspx

Brian Postlethwaite (Aug 21 2018 at 03:48):

I grabbed the updated examples-json.zip and now all round trips with that work
(had to exclude: backbone-elements.jzon, json-edge-cases.json, observation-decimal.json and package-min-ver.json)

Grahame Grieve (Aug 21 2018 at 23:17):

both should be fixed in the 2018Sep publication now (and in build)

Brian Postlethwaite (Aug 21 2018 at 23:58):

Thanks, I'll check later.

Last updated: Apr 12 2022 at 19:14 UTC