Stream: committers
Topic: Warnings really warning?
Jean Duteau (Jun 26 2019 at 14:49):
The intention is that info and warning messages that haven't been suppressed should be paid the same attention as error. Every single one of them needs to be dealt with - whether that's by fixing the source or by saying "yeah, that's fine" and putting it into the suppression file. (Note: Don't suppress messages that are caused by tooling issues - or no one will ever get around to fixing them.)
After Rob's ICD-10 fix, my build finally ran to completion. I'm suppressing all of the warning and information messages just so I can see the details, but the two summary lines were eye-opening:
Errors=0, Warnings=34082, Information messages=5544
Errors: 0 Warnings: 1004 Hints: 1087
Basically, if I take what @Lloyd McKenzie at face value that every message needs to be treated as an error, that means we have a woefully poor quality build right now with over 35k warninsg and 6500 information messages. As well, there are a bunch of miscellaneous error-like messages spit out throughout the build, eg. Missing IsModifierReason on AppointmentResponse.participantStatus, Unresolved value set reference: http://www.rsna.org/RadLex_Playbook.aspx, No value set at Group.code, etc.
Do we have a plan on fixing all of these or reviewing the error check to see if it is something that we really care about?
Lloyd McKenzie (Jun 26 2019 at 14:54):
Even more exciting, some of the information and warning messages really should be treated as error messages. The challenge we've had is that there's never a good time to strictly enforce the rules and break the build until everyone goes through and fixes their stuff. There's always an upcoming connectathon or IG publication or something that trumps getting stuff fixed - which is a problem. (Spitting stuff out to the console rather than raising trackable errors/warnings/etc. is also a problem and is easier to address. We do also have problems where on occasion some of the messages can be spurious - as @Andy Stechishin mentioned. I do agree that we really need to get these things fixed.
Lloyd McKenzie (Jun 26 2019 at 14:55):
But no, there currently isn't a plan.
Last updated: Apr 12 2022 at 19:14 UTC
