Stream: committers
Topic: ValueSet.description
Rick Geimer (Mar 28 2016 at 05:12):
FYI, the build fails with an ungraceful null pointer exception when ValueSet resources lack a description even though ValueSet.description is 0..1. The problem starts in ValueSetValidator.VSDuplicateList() at line 44 with the call to splitByCamelCase(vs.getDescription()). I tried fixing splitByCamelCase() to gracefully handle null strings and just return a zero length string, which got past the initial error, but then other things broke downstream so the description dependency runs deeper that I thought.
Anyway, I just added a description element to the value set in question and all went well, but we should probably decide to either a) fix the build or b) make ValueSet.description required. If the decision is to fix the build I don't mind taking a stab at it after Monday's Connectathon deadline, but figured it best not to rock the boat beforehand.
Grahame Grieve (Mar 28 2016 at 06:06):
it doesn't follow that since description is 0..1, the build should allow value sets without description, nor that because the build requires description, it should be 1..1
Grahame Grieve (Mar 28 2016 at 06:07):
my solution would be to add an explicit validation rule that valuesets must have a description
Rick Geimer (Mar 28 2016 at 14:46):
Grahame: Fair enough, at least then implementers would get a better error message than null pointer.
Last updated: Apr 12 2022 at 19:14 UTC
