Stream: committers
Topic: Summary
Grahame Grieve (Mar 25 2019 at 03:32):
As at this moment, the following IGs are still not ready to publish:
Grahame Grieve (Mar 25 2019 at 03:34):
- Bidirectional Services eReferrals (BSeR), Release 1 - US Realm
- Women’s Health Technology Coordinated Registry Network (CRN), Release 1 - US Realm
- Patient Reported Outcomes (PRO), Release 1 - US Realm
- Structured Data Capture (SDC), Release 2
- Personal Health Device (PHD), Release 1
- Common Data Model Harmonization for Research (CDMH), Release 1 - US Realm
- Documentation Templates and Payer Rules (DTR), Release 1- US Realm
- Pharmacist Care Plan Document, Release 1 - US Realm
Also FHIRPath & FHIRCast which are special cases
Nagesh Bashyam (Mar 25 2019 at 04:07):
@Grahame Grieve
Patient Reported Outcomes , Common Data Model Harmonization are good to go per the QA.html on build.fhir.org.
I updated Women's Health Technology CRN also but I am not receiving commit notifications since 11:45 pm on that project.
My local build says everything is ok.
Nagesh Bashyam (Mar 25 2019 at 04:15):
@Grahame Grieve
These show up as being "All OK" on QA.html for publishing.
Patient Reported Outcomes
Common Data Model Harmonization
Women's Health Technology Coordinated Registry Network
Let me know if there are any further changes required.
Grahame Grieve (Mar 25 2019 at 07:44):
@Nagesh Bashyam with respect to all 4: the header - can we take the underscores out? looks silly to me, and not consistent with everything else. And the footer: can we match this footer:
https://build.fhir.org/ig/HL7/sdc/
Grahame Grieve (Mar 25 2019 at 07:47):
@Rick Geimer and @Brian Reinhold - waiting to hear from both of you
Nagesh Bashyam (Mar 25 2019 at 16:05):
Fixed.
Nagesh Bashyam (Mar 25 2019 at 16:18):
Fixed PRO, CRN and CDMH Headers and Footers.
Grahame Grieve (Mar 25 2019 at 18:57):
well, better. You don't like humans? spaces were introduced just recently and I feel as though we should take advantage of them: WomensHealthTechnologyCoordinatedRegistryNetwork ?
Eric Haas (Mar 25 2019 at 19:09):
That is because the variable name is coming from the ig.xml name element. for some reason there is no title element for Implementation Guide in STU3 so is a legacy thing from STU3 in my framework. I 'll need to update that one.
Grahame Grieve (Mar 25 2019 at 19:30):
an extension?
Grahame Grieve (Mar 25 2019 at 19:31):
or can we just get it from somewhere else/
Lloyd McKenzie (Mar 25 2019 at 20:46):
We should have a backwards compatibility extension for that. I could update the framework to look for it if we can agree on what it should be.
Eric Haas (Mar 25 2019 at 21:30):
its coming from {{ site.data.fhir.igName }}
Eric Haas (Mar 25 2019 at 21:31):
(deleted)
Rick Geimer (Mar 25 2019 at 21:46):
@Grahame Grieve I believe PhCP is all good now. I fixed those issues you pointed out with history.cfml and package-list.json. It is showing up as "all ok" for publishing stuff now.
Eric Haas (Mar 25 2019 at 21:48):
(deleted)
Lloyd McKenzie (Mar 25 2019 at 22:05):
There's now a {{site.data.fhir.ig.title}} element
Lloyd McKenzie (Mar 25 2019 at 22:05):
But that only gets populated if the IG has a title...
Eric Haas (Mar 25 2019 at 22:21):
@Nagesh Bashyam in the file framework/_includes/header.html replace
'{{ site.data.fhir.igName }}' with '{{site.data.fhir.ig.title}}'
and that should do it.
Eric Haas (Mar 25 2019 at 22:21):
thanks Lloyd
Nagesh Bashyam (Mar 26 2019 at 03:44):
Updated the Headers to use ig.title instead of igName for PRO, CRN and CDMH.
Thanks all.
Grahame Grieve (Mar 26 2019 at 04:26):
ok. I'm at last call. Is anyone still working on their IG? (@Lloyd McKenzie )
Lloyd McKenzie (Mar 26 2019 at 04:29):
Perfect timing. Just finished spell checking everything :)
Grahame Grieve (Mar 26 2019 at 04:30):
great. let me know when you're done. I have one outstanding item right now - the claim in the PHCP header
Lloyd McKenzie (Mar 26 2019 at 04:30):
Committed
Grahame Grieve (Mar 27 2019 at 03:54):
ok I have posted the following IGs:
- http://hl7.org/fhir/us/eltss/2019May
- http://hl7.org/fhir/us/hai/2019May
- http://hl7.org/fhir/us/patient-reported-outcomes/2019May
- http://hl7.org/fhir/us/phcp/2019May
- http://hl7.org/fhir/us/vrdr/2019May
- http://hl7.org/fhir/us/womens-health-registries/2019May
- http://hl7.org/fhir/us/bser/2019May
- http://hl7.org/fhir/us/bulkdata/2019May
- http://hl7.org/fhir/us/cdmh/2019May
- http://hl7.org/fhir/us/cqfmeasures/2019May
- http://hl7.org/fhir/us/davinci-crd/2019May
- http://hl7.org/fhir/us/davinci-deqm/2019May
- http://hl7.org/fhir/us/davinci-dtr/2019May
Please review @Sarah Gaunt @Rick Geimer @AbdulMalik Shakir @Adam Holmes @Ricky Sahu @David Pyke @Nagesh Bashyam @Bryn Rhodes @Eric Haas
Grahame Grieve (Mar 27 2019 at 03:54):
uv ones to come...
Bryn Rhodes (Mar 27 2019 at 04:01):
CQF Measures looks great, thank you!
Sarah Gaunt (Mar 27 2019 at 04:19):
Awesome - looks good @Grahame Grieve - thanks!
Lloyd McKenzie (Mar 27 2019 at 06:31):
You didn't list me, but I checked CRD anyhow. Looks good. I presume SDC is still coming? Also, let us know when the freeze is considered to be 'off'.
Grahame Grieve (Mar 27 2019 at 07:08):
I'll process uv as soon as I can. I nearly have US done. I found a number of issues in the history for several of the IGs. please check the history
Grahame Grieve (Mar 27 2019 at 07:09):
(for all guides)
Nagesh Bashyam (Mar 27 2019 at 14:12):
@Grahame Grieve - CDMH is good. Thanks.
Nagesh Bashyam (Mar 27 2019 at 14:14):
@Grahame Grieve
For both PRO and WHT CRN:
US Core links has to reference R4 which is what is present in the dependency, but the links are going back to R3.
SDC links have to point to the latest version, we will have to fix that once SDC gets published.
For PRO : The history.cfml does not exist and is a 404 error. Need to correct that.
Eric Haas (Mar 27 2019 at 14:51):
@Grahame Grieve For DEQM there are several issues in the history file
- The introduction is from CRD
- The Current link points to the last ballot's R4 ig
- The change-notes link is bad: good - http://hl7.org/fhir/us/davinci-deqm/2019May/STU3/change-notes.html vs bad - http://hl7.org/fhir/us/davinci-deqm/2019May/change-notes.html
Lloyd McKenzie (Mar 27 2019 at 15:26):
CRD has a history of "TBD"...
Grahame Grieve (Mar 27 2019 at 18:53):
@Nagesh Bashyam the description of this ballot on http://www.hl7.org/fhir/us/patient-reported-outcomes/history.cfml is screwy
Nagesh Bashyam (Mar 27 2019 at 18:58):
@Grahame Grieve - Where did you get that from ? Should i change it ?
Grahame Grieve (Mar 27 2019 at 18:59):
ok all reported issues are fixed, and uv guides are posted as well:
Grahame Grieve (Mar 27 2019 at 19:00):
and freeze is off. Please update your CI builds so they no longer claim to be ballot, and instead claim to be the CI build
Eric Haas (Mar 27 2019 at 19:10):
thank you Grahame.
Grahame Grieve (Mar 27 2019 at 19:17):
@Bryn Rhodes I have updated FHIRPath, but the entry for "TBD" here is weird: http://hl7.org/fhirpath/history.html
Grahame Grieve (Mar 27 2019 at 19:46):
@Sarah Gaunt @Rick Geimer @AbdulMalik Shakir @Adam Holmes @Ricky Sahu @David Pyke @Nagesh Bashyam @Bryn Rhodes @Eric Haas @Lloyd McKenzie @Brian Reinhold please prompt your relevant co-chairs to send confirmation of your content being ready for ballot to @Lynn Laakso
Grahame Grieve (Mar 27 2019 at 19:46):
@Nagesh Bashyam I do not see any matching ballot for cdmh
Lloyd McKenzie (Mar 27 2019 at 19:46):
Do we create tags in Git somehow first?
Lloyd McKenzie (Mar 27 2019 at 19:47):
Also, looks like I messed up the history date for this ballot in SDC - do I fix that or do you?
Lloyd McKenzie (Mar 27 2019 at 19:47):
(Should be May, not Sept.)
Grahame Grieve (Mar 27 2019 at 19:51):
I don't tag the releases- can just sort it out later with git.
Grahame Grieve (Mar 27 2019 at 19:51):
where's the error?
Bryn Rhodes (Mar 27 2019 at 19:51):
On FHIRPath, oops, missed that entry, I had added that when we were prepping to publish last round. Just comitted a fix and verified that entry is not in the package-list.
Grahame Grieve (Mar 27 2019 at 20:02):
does anyone know how to take a single file and use it to update (overwrite) 100s of files? (on windows, new version of the hL7 icon)
Bryn Rhodes (Mar 27 2019 at 20:07):
I have a scripting environment that could do it pretty quickly.
Grahame Grieve (Mar 27 2019 at 20:08):
check my update to FHIRPath history - I've forked from git now
Grahame Grieve (Mar 27 2019 at 20:09):
I guess I can write script too
Bryn Rhodes (Mar 27 2019 at 20:10):
FHIRPath update looks good
Brian Reinhold (Mar 27 2019 at 20:25):
- Bidirectional Services eReferrals (BSeR), Release 1 - US Realm
- Women’s Health Technology Coordinated Registry Network (CRN), Release 1 - US Realm
- Patient Reported Outcomes (PRO), Release 1 - US Realm
- Structured Data Capture (SDC), Release 2
- Personal Health Device (PHD), Release 1
- Common Data Model Harmonization for Research (CDMH), Release 1 - US Realm
- Documentation Templates and Payer Rules (DTR), Release 1- US Realm
- Pharmacist Care Plan Document, Release 1 - US Realm
Also FHIRPath & FHIRCast which are special cases
@Grahame Grieve What is it that I still need to do? (PHD IG)
Lloyd McKenzie (Mar 27 2019 at 20:30):
Error: Date is listed as 2019-09-29 instead of 2019-03-29
Lloyd McKenzie (Mar 27 2019 at 20:36):
Actually, date for CRD is wrong too. It says 2019-03-01
Brian Reinhold (Mar 27 2019 at 20:52):
Error: Date is listed as 2019-09-29 instead of 2019-03-29
@Lloyd McKenzie The dates I see in the PHD are 2019-03-27. Where is the 2019-09-29 located?
Lloyd McKenzie (Mar 27 2019 at 21:02):
Wasn't pointing out an issue with PHD. 2019-09-29 is SDC and 2019-03-01 is CRD.
Brian Reinhold (Mar 27 2019 at 21:03):
Wasn't pointing out an issue with PHD. 2019-09-29 is SDC and 2019-03-01 is CRD.
ok
Grahame Grieve (Mar 27 2019 at 21:24):
@Brian Reinhold - still for you to do: check the PHD representatino as published for any errors, and then get the relevant co-chairs to tell Lynn that it's good to go
Brian Reinhold (Mar 27 2019 at 21:25):
Brian Reinhold - still for you to do: check the PHD representatino as published for any errors, and then get the relevant co-chairs to tell Lynn that it's good to go
So review the IG that you pointed to in a link in this thread http://hl7.org/fhir/uv/phd/2019May/ earlier?
Grahame Grieve (Mar 27 2019 at 21:28):
y
Brian Reinhold (Mar 27 2019 at 21:28):
y
on it
Lloyd McKenzie (Mar 27 2019 at 21:31):
@Grahame Grieve, re: SDC & CRD - do you want me to fix the package-list.json files or will you?
Grahame Grieve (Mar 27 2019 at 22:18):
I need to
Grahame Grieve (Mar 27 2019 at 22:22):
don't see the problem with crd. fixed sdc
Lloyd McKenzie (Mar 27 2019 at 22:26):
Published CRD looks good. Source is wrong. I'll fix the source, commit, tag and then change back to CI build.
Grahame Grieve (Mar 27 2019 at 22:27):
I don't care about the source anymore ;-)
Lloyd McKenzie (Mar 27 2019 at 22:33):
You will when it's the basis for the release next time :)
Grahame Grieve (Mar 27 2019 at 22:42):
have to start with cloning the published one next time.
Lloyd McKenzie (Mar 28 2019 at 00:42):
That's going to be next to impossible to enforce and will be unnatural given that the files are already checked in and in the right location. I think the process should be that if you make any edits, you commit them back to the source folders so they're ready to go for the next time.
Brian Reinhold (Mar 28 2019 at 00:53):
y
on it
@Grahame Grieve I have finished the review. I read through all the text and checked the majority of links. Found a few things in the text and a link that wasn't made into a link (arrg). I am building locally and will commit.
Upload done.
Grahame Grieve (Mar 28 2019 at 02:58):
are any of these critical? because I now have to manually clone these changes into my fork
Brian Reinhold (Mar 28 2019 at 09:33):
are any of these critical? because I now have to manually clone these changes into my fork
@Grahame Grieve Not really. Typos, two or three clumsy sentences, a link that was not made into a hyperlink so people could click on it. There was only one sentence that says something wrong (which I thought I had fixed ... could have been merged out by git commits from two different sources). Nothing in any of the xml resources or json examples, all changes were all in the free-text *.md pages. Nothing would result in substantive changes so if it is a lot of work don't bother, they can be fixed in the next ballot. I can submit comments. You have enough to do.
In any case, the complete read-through was a good exercise. In order for it to be even effective, it has to be done after one has put aside the IG for a while; otherwise it is too familiar.
Last updated: Apr 12 2022 at 19:14 UTC
