Stream: committers
Topic: Showing release on IG commit notifications
Lloyd McKenzie (Mar 07 2019 at 20:41):
@Josh Mandel In the IG build reports that show up in committers/notification, is it possible to include in the body of the notification the Git hash associated with the build? That would tell us what we should be embedding in gForge to link the tracker items to the commit.
Grahame Grieve (Mar 07 2019 at 23:33):
you should get the git hash when you commit in the first place
Lloyd McKenzie (Mar 07 2019 at 23:39):
I get two - one for my local commit and one for my push and it's not obvious which is the one from the central repository.
Grahame Grieve (Mar 07 2019 at 23:47):
local commit is the actual changes.
Josh Mandel (Mar 07 2019 at 23:47):
Hmm, this is possible, but aren't you tagging GF issues in the git commit message?
Josh Mandel (Mar 07 2019 at 23:48):
And yes, your commit hash shouldn't be changing when you push...
Grahame Grieve (Mar 07 2019 at 23:48):
you get an extra one.
Josh Mandel (Mar 07 2019 at 23:49):
can you walk me through this?
Josh Mandel (Mar 07 2019 at 23:49):
I'm probably just missing something basic.
Grahame Grieve (Mar 08 2019 at 00:06):
ah no you only get the extra hash for the merge on the main build. AFAIK we're not using merging on any IGs
Grahame Grieve (Mar 08 2019 at 00:07):
you can see the double hashes on any commit logged in committers/notification under fhir / master but the IG build notifications don't include the single hash
Josh Mandel (Mar 08 2019 at 00:09):
"double hash" meaning "merge commit", yes. But the initial commit is still a fine thing to reference from a GH issue.
Josh Mandel (Mar 08 2019 at 00:10):
I'm just thinking that as far as GF issues/updates are concerned, you can do this all based on information you have locally at the time you make a commit. We can definitely include more in the notification messages; I just want to understand what problem it solves.
Josh Mandel (Mar 08 2019 at 00:10):
Like, if you implement a fix to solve a GF issue, then push and your build fails...
Josh Mandel (Mar 08 2019 at 00:11):
and then you make a tiny tweak to add a quotation mark or whatever, and then push, and then your build succeeds...
Josh Mandel (Mar 08 2019 at 00:11):
You'd still want to link from a GF issue to the commit that actually solved the GF issue (I think).
Grahame Grieve (Mar 08 2019 at 00:12):
based on information you have locally at the time you make a commit
which is what I said above. Occasionally, if I screw up a commit and add more, I register it on the task too if it's significant. But usually it's trivial and I don't bother
Last updated: Apr 12 2022 at 19:14 UTC
