FHIR Chat · Renaming Sequence resource · committers

Stream: committers

Topic: Renaming Sequence resource


view this post on Zulip Kevin Power (Oct 31 2018 at 16:50):

The CG workgroup decided to rename the Sequence resource to MolecularSequence. While I wish it would have been sooner than now, I have committed the changes to a branch and here is the compare and welcome anyone to review. As you might expect, it is a wide but fairly shallow set of changes, except directly in the resource itself of course. Probably the next biggest impact was Observation, so wanted to specifically call out to @Eric Haas and @Rob Hausam - Hopefully I won't interfere with you.
I am reviewing this now in the Clinical Reasoning module as well. I plan to do the same sort of 'search/replace' here, but wanted to ask @Bryn Rhodes for input.

view this post on Zulip Bryn Rhodes (Oct 31 2018 at 16:59):

@Kevin Power , that is a FHIR model info that I will update once the substantive changes are complete, so if your resource name change is in, it will be updated when I regen that content.

view this post on Zulip Kevin Power (Oct 31 2018 at 17:00):

Great, thanks @Bryn Rhodes

view this post on Zulip Rob Hausam (Oct 31 2018 at 17:25):

Thanks for letting us know, @Kevin Power. Yes, there are a lot of Observation-related changes, but as it is primarily a change to the resource name that should be straightforward. I've started to look but haven't reviewed it all yet, and we'll see what @Eric Haas thinks.

view this post on Zulip Eric Haas (Oct 31 2018 at 17:42):

you will need to update the references in about 4 places. I have no more commits for Observation.

view this post on Zulip Kevin Power (Oct 31 2018 at 18:13):

Yes, I think I caught all of them. Working with @Patrick Werner now to see about an odd build error we are seeing on the pull request that doesn't seem related to our changes. Seems to error validating a capabilitystatement example.

view this post on Zulip Patrick Werner (Oct 31 2018 at 18:14):

merged master in our branch again, as the master branch was failing today as well.

view this post on Zulip Kevin Power (Oct 31 2018 at 18:26):

@Lloyd McKenzie - would you mind reviewing the diff of fhir.ini?

view this post on Zulip Lloyd McKenzie (Oct 31 2018 at 18:30):

Looks ok to me...


Last updated: Apr 12 2022 at 19:14 UTC