Stream: committers
Topic: R4B
Grahame Grieve (Feb 04 2021 at 20:41):
ok, we're pretty much there. You can now clone the R4B branch, make your changes, and then commit and make PRs against the R4B branch. Once you merge your PRs into R4B, you'll see the output at https://build.fhir.org/branches/R4B/
Grahame Grieve (Feb 04 2021 at 20:41):
you may note that https://build.fhir.org/branches/R4B/ claims to be R5 preview #3 - I need to work on this and other things now
Mark Iantorno (Feb 04 2021 at 21:21):
If there are any build issues with the branch please message me.
Mark Iantorno (Feb 04 2021 at 21:26):
Also, one thing to keep in mind is that the pipelines that build the spec are currently using my home computer as the build agent, as the free Azure tier doesn't give us access to machines with enough memory. This will be solved hopefully tomorrow, but if the build does go down at any point, it might be because I'm having internet issues (which has been occurring lately). If your build fails, wait 30 min and try again, then message me if it still doesn't work. Like I said, this is hopefully something I can fix tomorrow.
Bryn Rhodes (Feb 04 2021 at 23:12):
publish.bat in the R4B branch needs the arg handling from the master branch, I have that locally, am I okay to commit that directly to the R4B branch?
Bryn Rhodes (Feb 04 2021 at 23:13):
https://github.com/HL7/fhir/blob/master/publish.bat
Bryn Rhodes (Feb 04 2021 at 23:13):
vs:
Bryn Rhodes (Feb 04 2021 at 23:13):
https://github.com/HL7/fhir/blob/R4B/publish.bat
Bryn Rhodes (Feb 04 2021 at 23:31):
n/m, protected branch :) PR submitted, I'll merge as soon as it validates
Mark Iantorno (Feb 05 2021 at 03:42):
I have no idea why the commit I put to update that file got rolled back.. that is puzzling to me
Mark Iantorno (Feb 05 2021 at 03:42):
on a side note @Bryn Rhodes try running it with the gradle command
Mark Iantorno (Feb 05 2021 at 03:42):
it'll change your life
Mark Iantorno (Feb 05 2021 at 03:42):
./gradlew publish
Bryn Rhodes (Feb 05 2021 at 03:47):
Fantastic.
Mark Iantorno (Feb 05 2021 at 14:35):
Build server is going down for a short period while I switch over to GCP
Rik Smithies (Feb 09 2021 at 12:23):
is the idea that all the changes between R4 and the R5 build need to be re-applied to R4B by each workgroup?
Lloyd McKenzie (Feb 09 2021 at 14:36):
No. Only those changes specifically approved for inclusion in R4B should be applied. For resources outside the medication governance and EBM space, that means technical corrections that affect tools, new extensions and approved extensions to resource targets
Rik Smithies (Feb 09 2021 at 14:44):
Ok well that is sort of what I meant. My point is that they all need to be reapplied, which I was not expecting, though it does make sense. How do we deal with things like CodeableReference? Is there a list of what's in and out? Or is it just see what breaks the build...
Lloyd McKenzie (Feb 09 2021 at 14:48):
@Grahame Grieve on the CodeableReference question. I believe it should be out?
Chris Moesel (Feb 09 2021 at 16:47):
Might as well answer that question for integer64 as well while you're at it. ;-)
Mark Iantorno (Feb 09 2021 at 17:11):
Resetting build server for build.fhir.org
Mark Iantorno (Feb 09 2021 at 17:12):
will be back in 5min
Mark Iantorno (Feb 09 2021 at 17:19):
It's back up
Grahame Grieve (Feb 09 2021 at 19:46):
we can add datatypes to R4B
Rik Smithies (Feb 22 2021 at 17:40):
I've done most of my changes for R4B. Do I need to manually request a review of my pull request?
Lloyd McKenzie (Feb 22 2021 at 18:41):
@Grahame Grieve
Grahame Grieve (Feb 24 2021 at 02:50):
usual process is that editors approve their own PRs on core
Rik Smithies (Feb 24 2021 at 10:51):
I assume I don't have permission, or it wouldn't have been blocked.
Review required At least 1 approving review is required by reviewers with write access.
That doesn't happen on the main build. Do I need to be assigned write access?
Josh Mandel (Feb 24 2021 at 14:12):
https://github.com/HL7/fhir/settings/branches shows an extra protection applied to r4b, that isn't applied to master: "Require pull request reviews before merging". We should probably uncheck this @Grahame Grieve
Mark Iantorno (Feb 24 2021 at 14:32):
I will fix that
Mark Iantorno (Feb 24 2021 at 14:32):
That's on me
Mark Iantorno (Feb 24 2021 at 14:33):
Pull request review requirement has been removed from the branch
Mark Iantorno (Feb 24 2021 at 14:34):
@Rik Smithies you should be able to merge any branch that passes the build. Let me know if you are still having issues
Rik Smithies (Feb 24 2021 at 16:48):
thanks @Mark Iantorno the status of my pull request did change (it no longer says it needs a review), but it still seems stuck for a few hours on other checks. Is the build pipeline just catching up or do I need to re-do something?
https://github.com/HL7/fhir/pull/1097
Mark Iantorno (Feb 24 2021 at 16:59):
can you pull the main R4B branch back into your branch
Mark Iantorno (Feb 24 2021 at 16:59):
there was a change with the pipeline file that is not being picked up
Mark Iantorno (Feb 24 2021 at 17:00):
so you need to pull R4B into your branch to get it
Mark Iantorno (Feb 24 2021 at 17:00):
it will build then
Jean Duteau (Feb 24 2021 at 17:04):
@Mark Iantorno does this have to be done with everyone's paused branches?
Rik Smithies (Feb 24 2021 at 17:09):
@Mark Iantorno I can try, any clues how? Do I need to do a git pull on my local machine then push again? Or can I I do it via here somehow?
https://github.com/HL7/fhir/tree/rikr4b2. On the main build I now keep seeing a button that forces me to pull main into my branch when I do a pull request (which is also a recent change it seems), but that's not appearing here.
Mark Iantorno (Feb 24 2021 at 17:27):
if you pulled before yesterday, yes
Mark Iantorno (Feb 24 2021 at 17:28):
@Jean Duteau
Mark Iantorno (Feb 24 2021 at 17:28):
@Rik Smithies doing it locally is easiest
Mark Iantorno (Feb 24 2021 at 17:28):
then if you push, the PR will update
David Pyke (Feb 24 2021 at 17:32):
Okay, I did a git pull and a git push on my R4B branch copy, nothing seemed to change. Is there specific changes I need to make?
Mark Iantorno (Feb 24 2021 at 17:33):
send me the link to the pr please
David Pyke (Feb 24 2021 at 17:34):
https://github.com/HL7/fhir/pull/1093
Mark Iantorno (Feb 24 2021 at 17:37):
I just checked and the branch Consent-for-R4B did not have the latest from R4B merged into it
Mark Iantorno (Feb 24 2021 at 17:37):
you will need to git pull R4B into the branch
Mark Iantorno (Feb 24 2021 at 17:37):
then git push origin <your branch>
Mark Iantorno (Feb 24 2021 at 17:37):
this will update the PR
Mark Iantorno (Feb 24 2021 at 17:40):
Same with your pull request @Rik Smithies
Mark Iantorno (Feb 24 2021 at 17:41):
@David Pyke let me know if there are any issues
David Pyke (Feb 24 2021 at 17:45):
Okay I did:
git pull origin R4B
git pull
git push
and that seemed to make things happen
Mark Iantorno (Feb 24 2021 at 17:47):
yup
Mark Iantorno (Feb 24 2021 at 17:47):
good stuff
Rik Smithies (Feb 24 2021 at 17:48):
what is the second pull for?
Mark Iantorno (Feb 24 2021 at 17:48):
You only need git pull origin R4B, not both git pull origin R4B and git pull
Rik Smithies (Feb 24 2021 at 17:48):
right
David Pyke (Feb 24 2021 at 17:49):
Didn't work until I did both. Not sure why but until I did that and waved the chicken from right to left, it didn't like my push
Yunwei Wang (Feb 24 2021 at 17:55):
If a JIRA ticket has Grouping R4B, then I should create PR for R4B branch, otherwise PR for master branch. Is that correct? @Lloyd McKenzie
Rik Smithies (Feb 24 2021 at 17:58):
@David Pyke if I am on my own branch of R4B, then I would assume that when I did "git pull" it would know the branch (or origin?) was R4B, and just pull that. If it doesn't do that then I would hope it doesn't pull the main branch in.
David Pyke (Feb 24 2021 at 17:58):
If you pulled a --single-branch R4B, it should. I would still use the commands that I did, just in case
Rik Smithies (Feb 24 2021 at 18:02):
when I "git pull" it mentions a lot of stuff from the main branch... But I guess it has just downloaded that and not merged it into my R4B branch...
Rik Smithies (Feb 24 2021 at 18:38):
should I be doing "git push" or something like "git push origin R4B"
David Pyke (Feb 24 2021 at 18:38):
just git push
Rik Smithies (Feb 24 2021 at 18:39):
on command line that says "fatal: The current branch rikr4b2 has no upstream branch."
Rik Smithies (Feb 24 2021 at 18:40):
I normally push from Tortoise, and that seemed to do something but I am not sure where it pushed to. It hasn't unlocked my earlier pull request.
Rik Smithies (Feb 24 2021 at 18:42):
though it may just be taking its time...
David Pyke (Feb 24 2021 at 18:42):
you have two pull requests. you should delete the one you don't need
Jean Duteau (Feb 24 2021 at 18:42):
@Mark Iantorno We are seeing the following in the pull request pipeline:
chmod: cannot access '/home/markiantorno/azure-pipelines/_work/_temp/deploy.rsa': No such file or directory
Publishing to target r4b-vocab-naming-system
/home/markiantorno/azure-pipelines/_work/_temp/9cd9f4c0-d1ae-45df-8ada-4161fc55697d.sh: line 5: BUILD_FHIR_ORG_USERNAME: command not found
Warning: Identity file /home/markiantorno/azure-pipelines/_work/_temp/deploy.rsa not accessible: No such file or directory.
Rik Smithies (Feb 24 2021 at 18:42):
yeah. I am just ignoring the old one because I think it is also locked. Maybe not though now...
David Pyke (Feb 24 2021 at 18:43):
No, you should remove it.
Rik Smithies (Feb 24 2021 at 18:45):
ok I closed the old one thanks
David Pyke (Feb 24 2021 at 18:45):
The remaining one is against master, not R4B. Move it to be against R4B
Rik Smithies (Feb 24 2021 at 18:47):
hmm I probably closed the wrong one.
Rik Smithies (Feb 24 2021 at 18:48):
starting again...
Rik Smithies (Feb 24 2021 at 18:50):
when I grow up I want to understand git
David Pyke (Feb 24 2021 at 18:53):
We all do
Peter Jordan (Feb 24 2021 at 19:00):
"Becoming an Old Git - Source Code Repositories I Have Known" - available from all good booksellers.
Mark Iantorno (Feb 24 2021 at 19:09):
@Jean Duteau send me a link to where you are seeing that please
Jean Duteau (Feb 24 2021 at 19:12):
@Mark Iantorno https://github.com/HL7/fhir/pull/1107
Rik Smithies (Feb 24 2021 at 19:49):
@Mark Iantorno similarly maybe I am getting Error: The process '/home/markiantorno/azure-pipelines/_work/2/s/gradlew' failed with exit code 1
from https://github.com/HL7/fhir/pull/1112
Mark Iantorno (Feb 24 2021 at 19:49):
Your error is different than @Jean's
Mark Iantorno (Feb 24 2021 at 19:49):
your branch is in a bad state
Mark Iantorno (Feb 24 2021 at 19:49):
I just made a fix and am re-running Jeans
Mark Iantorno (Feb 24 2021 at 19:50):
git cannot find your branch to do a pull and build
Mark Iantorno (Feb 24 2021 at 19:51):
please just create a new branch and a new PR from that branch to R4b
Mark Iantorno (Feb 24 2021 at 19:51):
That *should solve the issue
Mark Iantorno (Feb 24 2021 at 19:51):
Something went wrong during your merge and push that caused it to not resolve correctly
Mark Iantorno (Feb 24 2021 at 19:52):
That's why both your runs failed in under 4 min
Mark Iantorno (Feb 24 2021 at 19:52):
the way its's supposed to work is <Environment Setup> -> <Clone changes> -> <Build Changes> -> <init variables and secure key for upload> -> <upload>
Mark Iantorno (Feb 24 2021 at 19:53):
your run doesn't even make it to the build state
Mark Iantorno (Feb 24 2021 at 19:53):
Jean's was failing because the security in Azure was not allowing the branch to access the key to upload the build branch for build.fhir.org
Mark Iantorno (Feb 24 2021 at 19:54):
I _think_ I have fixed this
Mark Iantorno (Feb 24 2021 at 19:54):
I changed the permissions and reran the branch for R4B successfully, and am now rerunning for Jeans branch
Mark Iantorno (Feb 24 2021 at 19:59):
The whole reason this is happening is because I made a change to the pipeline file such that builds would trigger for both PRs and full builds in the same way for master and R4B branches. The way this would work traditionally is that I would just change the file on master (which already has security permissions and I know works 100%) and then pull the changes into any branches necessary. However, because we're doing this 2 master approach, I needed to clone the same build pipeline in the R4B branch that existed already in master, which while almost identical to the PR pipeline in master, is treated as a separate pipeline in Azure. I neglected to enable secure file sharing for that pipeline at the time I created it. Also, the changes needed to be pulled into any live pull request for the build to actually trigger. To solve this I have 1. enabled access to the secure key file for the pipeline (this should solve the problem, although I'm puzzled as to why it didn't recognize the variables when it ran, those are shared...but my test run appeared to work so let's see how Jean's build goes) and 2. asked all of you to pull the latest from R4B into your branches.
Mark Iantorno (Feb 24 2021 at 20:22):
@Jean Duteau your build works now
Mark Iantorno (Feb 24 2021 at 20:23):
@Rik Smithies once you have recreated your pulls please let me know
Mark Iantorno (Feb 24 2021 at 20:23):
they should also work (if git can find your branch)
Mark Iantorno (Feb 24 2021 at 20:25):
@Jean Duteau you will have to wait for it to build again, so github detects the run
Rik Smithies (Feb 24 2021 at 21:09):
@Mark Iantorno thanks I made a new branch, pushed, created a pull request, went to merge. Same error.
https://github.com/HL7/fhir/pull/1113
strangely on that page it says the new branch at top of page (rikr4b3) but the old one half way down (rikr4b2). Is the new merge stuck behind the old?
Mark Iantorno (Feb 24 2021 at 21:10):
You are getting a different error now
Mark Iantorno (Feb 24 2021 at 21:10):
have you tried building locally
Mark Iantorno (Feb 24 2021 at 21:10):
Unable to find image file basic-product-structure.png in /home/markiantorno/azure-pipelines/_work/2/s/images/
Unable to find image file packages-for-products-1.png in /home/markiantorno/azure-pipelines/_work/2/s/images/
Unable to find image file complex-pack-2(mix-and-device).png in /home/markiantorno/azure-pipelines/_work/2/s/images/
Unable to find image file complex-pack-3(tablet-and-cream).png in /home/markiantorno/azure-pipelines/_work/2/s/images/
Unable to find image file basic-product-structure-simpler.png in /home/markiantorno/azure-pipelines/_work/2/s/images/
Unable to find image file basic-product-structure-simplest.png in /home/markiantorno/azure-pipelines/_work/2/s/images/
WARNING: Unable to create warnings file - one or more profiles-* files unavailable or invalid
To determine the cause of the build failure, look in the log prior to the warning and information messages immediately above
Error on line 14
XTTE0570: An empty sequence is not allowed as the value of variable $groups
in variable groups```
Rik Smithies (Feb 24 2021 at 21:16):
Hmm I did a full build both before and after the last pull. All I did then was a new branch. Didnt expect to need to build again after no changes.
Mark Iantorno (Feb 24 2021 at 21:17):
Please build locally on the new branch
Mark Iantorno (Feb 24 2021 at 21:17):
If it works locally, and you push and still get those errors I will manually do the build and look into it
Mark Iantorno (Feb 24 2021 at 21:29):
Jean, I have no clue why your branch is not building, I literally just built it on the same pipeline to test
Mark Iantorno (Feb 24 2021 at 21:29):
I'm getting a friend to open a pr on the repo and test right now
Rik Smithies (Feb 24 2021 at 22:02):
It built ok locally and there was nothing to commit after. Did another push but I don't think that make any changes.
Mark Iantorno (Feb 24 2021 at 22:03):
it's getting the same error
Mark Iantorno (Feb 24 2021 at 22:03):
let me pull
Mark Iantorno (Feb 24 2021 at 22:14):
I just cloned your branch and tried to build locally and it failed with the same error that azure is showing
Mark Iantorno (Feb 24 2021 at 22:14):
@Rik Smithies how are you running the build
Mark Iantorno (Feb 24 2021 at 22:15):
Unable to find image file basic-product-structure.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file packages-for-products-1.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file complex-pack-2(mix-and-device).png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file complex-pack-3(tablet-and-cream).png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file basic-product-structure-simpler.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file basic-product-structure-simplest.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Mark Iantorno (Feb 24 2021 at 22:15):
:point_up: those are the errors I'm getting
Mark Iantorno (Feb 24 2021 at 22:17):
I think that during your multiple merges and pulls something has gone wrong in your committed code and the files it needs to build are not there
Mark Iantorno (Feb 24 2021 at 22:18):
the pipeline is triggering as it should, but it's throwing errors, and I'm able to replicate those errors on my machine locally
Rik Smithies (Feb 24 2021 at 22:20):
Those files were committed recently, but a few days ago. I am running the build using "publish" on the command line.
Rik Smithies (Feb 24 2021 at 22:21):
how can I reproduce this? image.png
Mark Iantorno (Feb 24 2021 at 22:22):
run the command ./gradlew clean publish
Mark Iantorno (Feb 24 2021 at 22:23):
If you need those files, please ensure they are committed to your branch
Mark Iantorno (Feb 24 2021 at 22:23):
also please run a git status
Mark Iantorno (Feb 24 2021 at 22:24):
and see if there are any files listed as outstanding commits
Rik Smithies (Feb 24 2021 at 22:56):
Rik Smithies (Feb 24 2021 at 22:56):
it build ok, and git status shows no files need committing
Mark Iantorno (Feb 24 2021 at 22:56):
please run git reset hard
Mark Iantorno (Feb 24 2021 at 22:57):
git reset --hard
Rik Smithies (Feb 24 2021 at 22:57):
that will trash my branch though?
Rik Smithies (Feb 24 2021 at 22:58):
not that that matters, I will make a copy
Mark Iantorno (Feb 24 2021 at 23:10):
if you could just clone your branch in an entirely new directory and try and build it, i guarantee it will fail
Mark Iantorno (Feb 24 2021 at 23:10):
there are dependencies on your computer currently that are different from the ones that are actually committed
Mark Iantorno (Feb 24 2021 at 23:10):
I just am unsure what they are or how it got into that state
Mark Iantorno (Feb 24 2021 at 23:13):
like in a new directory on your computer with nothing else in itL
Mark Iantorno (Feb 24 2021 at 23:13):
git clone https://github.com/HL7/fhir.git
git fetch origin <your branch name>
git checkout <your branch name>
./gradlew clean publish
Mark Iantorno (Feb 24 2021 at 23:17):
:point_up: If you run those commands in a new folder with nothing else in it and it runs, I'll buy you a beer
Mark Iantorno (Feb 24 2021 at 23:17):
or coffee or whatever your treat of choice is
Lloyd McKenzie (Feb 24 2021 at 23:58):
Yunwei Wang said:
If a JIRA ticket has Grouping R4B, then I should create PR for R4B branch, otherwise PR for master branch. Is that correct? Lloyd McKenzie
Correct. And also keep a list of the R4B commits so we can cherry-pick the changes and migrate them to R5. (I have no idea how that's done, but @Josh Mandel said it, so it must be true :>)
Lloyd McKenzie (Feb 24 2021 at 23:58):
@Yunwei Wang
Josh Mandel (Feb 24 2021 at 23:58):
It's true but I didn't say it'd be easy or smooth!
Gino Canessa (Feb 25 2021 at 00:01):
Mark Iantorno said:
please run git reset hard
You can also run git status to see if there are untracked files in that tree
Mark Iantorno (Feb 25 2021 at 03:33):
(deleted)
Rik Smithies (Feb 25 2021 at 12:06):
@Mark Iantorno so the fresh copy did show the error (so, me to buy the beer!). And adding back those missing files fixed the error. Local build now fine again. However when I try to commit, it shows nothing is needed. So how do I get those files uploaded into some branch that I can merge? I have tried commit on the exact branch I downloaded, that showed the problem originally, and also made another new branch on top to see if that helped. How do I convince the server that these files really are missing?
Mark Iantorno (Feb 25 2021 at 13:04):
Hrm. It would seem that git has gotten into a weird state. What is the exact filepath in the project of those files you want to add?
Mark Iantorno (Feb 25 2021 at 13:04):
I'll make sure we aren't 'ignoring' that location
Rik Smithies (Feb 25 2021 at 13:11):
they are in the images folder
Rik Smithies (Feb 25 2021 at 13:12):
the list is as you copied above
Unable to find image file basic-product-structure.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file packages-for-products-1.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file complex-pack-2(mix-and-device).png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file complex-pack-3(tablet-and-cream).png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file basic-product-structure-simpler.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Unable to find image file basic-product-structure-simplest.png in /home/mark/Documents/Projects/FHIR/fhir/images/
Mark Iantorno (Feb 25 2021 at 13:16):
hrm
Mark Iantorno (Feb 25 2021 at 13:16):
kk I'm just trying to figure out something else, i'll get back to this at some point today
Rik Smithies (Feb 25 2021 at 13:16):
thanks
Mark Iantorno (Feb 25 2021 at 13:16):
I'm thinking this is just a git issue
Mark Iantorno (Feb 25 2021 at 13:17):
will just need to be poked at a little
Mark Iantorno (Feb 25 2021 at 13:17):
also, could you send me the files you want to add
Mark Iantorno (Feb 25 2021 at 13:17):
Rik Smithies (Feb 25 2021 at 17:28):
sent
Gino Canessa (Feb 25 2021 at 18:57):
Once you've copied those files into the directory, you should be able to git add them to be tracked.
Jean Duteau (Feb 25 2021 at 19:18):
Mark Iantorno said:
Jean, I have no clue why your branch is not building, I literally just built it on the same pipeline to test
@Mark Iantorno I just looked and Yunwei Wang is having the same error. Both pull requests are from a fork as opposed to Khalid-Shahin's which succeeded but was from a branch. Not sure how that would make a difference, but it is a data point you may not have noticed.
Mark Iantorno (Feb 25 2021 at 19:19):
Can you retry with a branch and not a forked repo and let me know please
Jean Duteau (Feb 25 2021 at 19:56):
well, actually no, Marc Duteau is doing that and he doesn't have the ability to create a branch
Mark Iantorno (Feb 25 2021 at 19:57):
I see
Mark Iantorno (Feb 25 2021 at 19:57):
That answers my question then
Mark Iantorno (Feb 25 2021 at 19:57):
the issue does have to do with forking
Jean Duteau (Feb 25 2021 at 19:58):
i do have the ability so I can create a branch with his content and confirm the problem?
Mark Iantorno (Feb 25 2021 at 19:58):
No, I just cloned @Yunwei Wang 's branch and confirmed the issue
Mark Iantorno (Feb 25 2021 at 19:58):
I know what is wrong for you and him
Mark Iantorno (Feb 25 2021 at 20:04):
Forks should now trigger the PR pipeline as required. I have made the necessary changes under the hood. I didn't even realise this was an issue.
Mark Iantorno (Feb 25 2021 at 20:04):
Please close and open your pull request to re-trigger them being picked up
Mark Iantorno (Feb 25 2021 at 20:04):
If there are any further issues, let me know./
Marc Duteau (Feb 25 2021 at 20:56):
@Yunwei Wang 's pull request seems to have gone through now. But mine failed with a new error this time.
/bin/bash --noprofile --norc /home/markiantorno/azure-pipelines/_work/_temp/4eb6f74f-b629-4250-bded-19b7b8df76a4.sh
Publishing to target r4b-vocab-naming-system
495M .
952M .
1.5G .
find: './test': No such file or directory
##[error]Bash exited with code '1'.
Mark Iantorno (Feb 25 2021 at 21:04):
Ah, it would seem you are missing a directory called ./test?
Mark Iantorno (Feb 25 2021 at 21:04):
can you send me the PR
Marc Duteau (Feb 25 2021 at 21:08):
https://github.com/HL7/fhir/pull/1107
Yunwei Wang (Feb 25 2021 at 21:09):
Now my build is done. Who will approve and merge my PR?
Rob Hausam (Feb 25 2021 at 23:34):
@Yunwei Wang If the checks have passed successfully you should be able to approve and merge your own PR.
Yunwei Wang (Feb 26 2021 at 01:57):
@Rob Hausam I cannot. I created PR from my own fork.
You’re not authorized to merge this pull request.
Mark Iantorno (Feb 26 2021 at 02:06):
(deleted)
Rob Hausam (Feb 26 2021 at 05:07):
Looks like that's taken care of now.
Rik Smithies (Feb 26 2021 at 14:37):
@Mark Iantorno any update on my issue please?
Mark Iantorno (Feb 26 2021 at 14:38):
Right now I have 2 issues to look into for Grahame, then you're number 3 on my list. Sorry. I just am behind on many things right now
Rik Smithies (Feb 26 2021 at 14:45):
ok thanks. Time is short on R4b however, and my changes are a good proportion of it
Mark Iantorno (Feb 26 2021 at 19:31):
So, I'm going to give you two options here because it's becoming apparent I won't get to helping you with this for at least another day (ie next week)
Mark Iantorno (Feb 26 2021 at 19:31):
- you can wait
Mark Iantorno (Feb 26 2021 at 19:33):
- Download a fresh copy of the repo, create a new branch and ensure it builds locally, copy just your changes into the new branch (only your changes, try not to just copy the entire contents of the old repo into the new repo, that would just result in us being back here again), and try building and create a new pr
Mark Iantorno (Feb 26 2021 at 19:33):
I just don't have the time currently
Mark Iantorno (Feb 26 2021 at 19:33):
I am sorry
Rik Smithies (Feb 26 2021 at 22:34):
Thanks Mark, I will try #2, though that is exactly what I believe I've done over the last 2+ weeks to get to this point. #1 may not be an option because R4B needs to be completed, reviewed by work groups and voted on by Tuesday :-)
Rik Smithies (Feb 27 2021 at 00:36):
@Mark Iantorno @Grahame Grieve when I put new image files the build, git doesn't seem to allow these to be added. It doesn't include them in the commit. It also ignores spreadsheets - which is to be expected - presumably due to some sort of filter. But is there a filter on *.png also? Even if I add a png within /source (instead of /images) it is not noticed by the commit.
Vassil Peytchev (Feb 27 2021 at 01:58):
Do you add the new files explicitly with git add?
Rik Smithies (Feb 27 2021 at 10:32):
@Vassil Peytchev I get this when I do an explicit git add:
The following paths are ignored by one of your .gitignore files:
images/basic-product-structure.png
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"
.gitignore (which I never looked into before) says:
# Package Files #
*.jar
*.war
*.nar
*.ear
*.zip
*.tar.gz
*.rar
*.png
So that would explain why my "full build, commit/add all, push, pull request" loop has not been working. It has silently ignored some of the necessary files in the commit. Strangely, with the main branch version of .gitignore the list stops and .rar and doesn't have .png.
Jean Duteau (Feb 27 2021 at 17:50):
seems a rather strange thing to ignore, since no other image file formats are ignored.
Mark Iantorno (Mar 01 2021 at 13:33):
let me look at who made that change to the file and ask why they added it
Mark Iantorno (Mar 01 2021 at 13:36):
Mark Iantorno (Mar 01 2021 at 13:36):
Someone with the git name cnanjo did it three years ago
Mark Iantorno (Mar 01 2021 at 13:37):
Mark Iantorno (Mar 01 2021 at 13:37):
I have no idea who this is?
Mark Iantorno (Mar 01 2021 at 13:37):
Based on it being three years ago, and the master branch allowing people to add .png files, I'm going to remove the line from the gitinore file to allow you to proceed
Mark Iantorno (Mar 01 2021 at 13:40):
Change has been made
Mark Iantorno (Mar 01 2021 at 13:40):
https://github.com/HL7/fhir/pull/1128
Rik Smithies (Mar 01 2021 at 13:40):
thanks. I already worked around it and force added the files. It all worked fine as soon as I had done that. What is weird is that this is different in the main and the R4B branch, and that was only created recently I assume.
Mark Iantorno (Mar 01 2021 at 13:41):
R4B is apparently over 3 years old
Mark Iantorno (Mar 01 2021 at 13:41):
I don't pretend to know what's going on
Rik Smithies (Mar 01 2021 at 13:42):
that's truly strange. Even the concept of R4B is not that old. Presumably it was based on an existing branch.
Mark Iantorno (Mar 01 2021 at 13:57):
Ah, maybe the was a divergence in the branches that re-wrote the change from three years ago on one branch, but not the other
Mark Iantorno (Mar 01 2021 at 13:57):
the branch itself isn't three years old
Mark Iantorno (Mar 01 2021 at 13:57):
that's probably what happened
Mark Iantorno (Mar 01 2021 at 13:57):
it's still early for me
Rik Smithies (Mar 01 2021 at 14:04):
anyway no worries, its ok now and I got my changes in, thanks
Rob Hausam (Apr 05 2022 at 15:19):
@Lloyd McKenzie Is it possible to consider more R4B commits - or is that done now?
Notification Bot (Apr 05 2022 at 15:25):
A message was moved here from #committers/announce > R4B by Lloyd McKenzie.
Lloyd McKenzie (Apr 05 2022 at 15:25):
It's still possible, but won't be for long
Rob Hausam (Apr 05 2022 at 16:58):
@Lloyd McKenzie Apologies for posting in the wrong place. So how long do you think "long" is? :)
Gino Canessa (Apr 05 2022 at 16:59):
Hopefully more "short" than "long" ;-)
Lloyd McKenzie (Apr 05 2022 at 20:28):
Days, not weeks
Grahame Grieve (Apr 09 2022 at 23:51):
R4B is ready for QA. There's still changes being made, but as far as I can tell, R4B is ready infrastructurally - all the resources that should be in the package are, and I think they're ready. So time for people to start playing with the R4B package on http://build.fhir.org/branches/R4B/ and testing it out
Jean Duteau (Apr 10 2022 at 05:26):
i have an IG that is based on R4B and gets a bunch of errors due to the 4.3.0-snapshot1 release. Is there a way that I can point at this new version to see if those errors have gone away? That seems a reasonable thing to test?
Grahame Grieve (Apr 10 2022 at 08:14):
not at the moment
Bryn Rhodes (Apr 11 2022 at 19:49):
Related to the media types maxBinding issue (https://jira.hl7.org/browse/FHIR-36705), I've created a branch with a fix for this in R4B. Am I okay to merge that?
Lloyd McKenzie (Apr 11 2022 at 20:56):
Yes. It's a true technical correction
Bryn Rhodes (Apr 11 2022 at 23:03):
The PR appears to be stuck, it's been "queued" for over 2 hours now, which isn't my typical experience with the FHIR build pipeline: https://github.com/HL7/fhir/pull/1857
Bryn Rhodes (Apr 11 2022 at 23:24):
n/m, it just completed
Last updated: Apr 12 2022 at 19:14 UTC
