Stream: committers
Topic: R4B CI Builds
Gino Canessa (Jun 30 2021 at 16:49):
Hi all (and especially @Mark Iantorno =) - was working on some changes for R4B things and wondering if CI builds for R4B are posted anywhere. I cannot find them at build.fhir.org/branches (neither R4B itself nor R4B-gino), and my Zulip searching didn't turn up anything.
Thanks!
Mark Iantorno (Jun 30 2021 at 17:51):
R4B is not set up to publish interim branches in the same way that master is
Mark Iantorno (Jun 30 2021 at 17:51):
That functionality is only done for master branch, which is why you're not seeing it there'
Gino Canessa (Jun 30 2021 at 18:03):
Hmm.. so making changes public/visible is out of band for those branches?
Josh Mandel (Jun 30 2021 at 18:05):
Is this a decision not to publish R4B CI content, or just ... something that doesn't currently work?
Grahame Grieve (Jun 30 2021 at 19:29):
I'm sure that they were posted before. We couldn't have worked without it working - why isn't it happening?
Mark Iantorno (Jul 05 2021 at 20:30):
(deleted)
Mark Iantorno (Jul 05 2021 at 20:30):
(deleted)
Mark Iantorno (Jul 05 2021 at 20:34):
(deleted)
Mark Iantorno (Jul 05 2021 at 20:47):
Forget everything I wrote above, it does do this, I just looked, and I made this change months ago
Mark Iantorno (Jul 05 2021 at 20:48):
@Gino Canessa If you're build isn't publishing on a PR, then it's an issue with the branch name or some other error for that branch
Mark Iantorno (Jul 05 2021 at 20:48):
it should definitely publish a build on fhir.org/branches
Mark Iantorno (Jul 05 2021 at 20:50):
Yeah, on R4B, if you look at the pull-request-pipeline.yml file, it executes this base script:
Mark Iantorno (Jul 05 2021 at 20:50):
# This task takes the successfully built publish directory produced in the 'buildSpecification' job above and pushes it to
# build.fhir.org in a directory named after that branch that triggered this pull request.
- task: Bash@3
inputs:
targetType: 'inline'
script: |
cd publish
chmod 400 $(Agent.TempDirectory)/deploy.rsa
TARGET_DIRECTORY=$(echo "$(System.PullRequest.SourceBranch)" | sed -r 's/\//_/g')
echo "Publishing to target $TARGET_DIRECTORY"
tar czf - * | ssh -i $(Agent.TempDirectory)/deploy.rsa -p 2222 $(BUILD_FHIR_ORG_USERNAME)@build.fhir.org ./publish $TARGET_DIRECTORY
Mark Iantorno (Jul 05 2021 at 20:51):
Which throws it up to the branches directory
Mark Iantorno (Jul 05 2021 at 20:52):
@Gino Canessa next time you encounter the failed upload behavior, tag me and I'll look into it
Gino Canessa (Jul 09 2021 at 20:43):
Hi @Mark Iantorno and happy Friday! Sorry that I just got back to making these changes today, but tagging per your request :-|
So, I pushed up another round of changes and AFAICT everything succeeded: https://github.com/HL7/fhir/pull/1299/checks?check_run_id=3032549858
I also saw the bot post on #committers/notification that it was successful.
But, there is no folder for it on http://build.fhir.org/branches/ .
If there's anything I can do/help with, please let me know. Thanks!
Mark Iantorno (Jul 09 2021 at 22:00):
Interesting, interesting
Mark Iantorno (Jul 09 2021 at 22:00):
Let me take a quick look
Mark Iantorno (Jul 09 2021 at 23:33):
100% something to do with your name
Mark Iantorno (Jul 09 2021 at 23:33):
just got mine to publish no issue
Mark Iantorno (Jul 09 2021 at 23:33):
I am unsure what the exact issue is
Mark Iantorno (Jul 09 2021 at 23:34):
So, I would suggest to change the name to something else like gino-the-dreamo or something like that, and then on Monday, I will try to get around to looking into this.
Mark Iantorno (Jul 09 2021 at 23:35):
I strongly suspect that this has to do with the name containing R4B?
Mark Iantorno (Jul 09 2021 at 23:35):
Like if I had to guess offhand.
Mark Iantorno (Jul 09 2021 at 23:35):
@Gino Canessa
Mark Iantorno (Jul 09 2021 at 23:35):
let me know if changing the name works for you
Gino Canessa (Jul 12 2021 at 16:16):
Morning @Mark Iantorno , hope you had a good weekend =). Unfortunately, doesn't seem to have made any difference: branch is subscription-b. PR is there, checks completed successfully, nothing on build.fhir.org/branches.
Mark Iantorno (Jul 12 2021 at 17:17):
Can you please try just going to the repo, changing the README file online and making a PR for it
Mark Iantorno (Jul 12 2021 at 17:17):
just see if it will work
Gino Canessa (Jul 12 2021 at 17:19):
On the new branch?
edit: ah, create a new branch - PR to master or PR to R4B?
Mark Iantorno (Jul 12 2021 at 17:51):
Ah, do both
Mark Iantorno (Jul 12 2021 at 17:51):
and see if they work
Mark Iantorno (Jul 12 2021 at 17:51):
The repo that you are branching from...is it public?
Mark Iantorno (Jul 12 2021 at 17:51):
or private?
Mark Iantorno (Jul 12 2021 at 17:51):
I remember an issue like this coming up before
Mark Iantorno (Jul 12 2021 at 17:51):
where private repos were not working
Gino Canessa (Jul 12 2021 at 17:52):
It's just a branch on the HL7/fhir repo.
Mark Iantorno (Jul 12 2021 at 17:54):
Where is the PR? Can you link
Gino Canessa (Jul 12 2021 at 17:55):
Yep, it's PR 1310
Gino Canessa (Jul 12 2021 at 17:55):
I started a PR with a Readme change on R4B, it's PR 1311
Mark Iantorno (Jul 12 2021 at 17:56):
yeah I saw that, that's good
Mark Iantorno (Jul 12 2021 at 17:57):
yeah the host key changed, now that I look at it
Mark Iantorno (Jul 12 2021 at 17:57):
@Josh Mandel and I had discussed this before. I just have to remember how I fixed it.
Mark Iantorno (Jul 12 2021 at 18:00):
this is the error fyi
Mark Iantorno (Jul 12 2021 at 18:00):
Publishing to target subscription-b
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@ WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED! @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
IT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that a host key has just been changed.
The fingerprint for the ECDSA key sent by the remote host is
SHA256:LisYQkgqtTm3QMJdGhfiGJRbhG9VkfTloIHJCsuLQFw.
Please contact your system administrator.
Add correct host key in /home/markiantorno/.ssh/known_hosts to get rid of this message.
Offending ECDSA key in /home/markiantorno/.ssh/known_hosts:1
remove with:
ssh-keygen -f "/home/markiantorno/.ssh/known_hosts" -R [build.fhir.org]:2222
ECDSA host key for [build.fhir.org]:2222 has changed and you have requested strict checking.
Host key verification failed.
Mark Iantorno (Jul 12 2021 at 18:04):
ah
Mark Iantorno (Jul 12 2021 at 18:04):
I see
Mark Iantorno (Jul 12 2021 at 18:08):
Alright
Mark Iantorno (Jul 12 2021 at 18:08):
@Gino Canessa I am a dummy. This should be fixed now.
Mark Iantorno (Jul 12 2021 at 18:08):
Could you please pull R4B into your branch
Mark Iantorno (Jul 12 2021 at 18:08):
and try again
Gino Canessa (Jul 12 2021 at 18:09):
Will try in one sec
Mark Iantorno (Jul 12 2021 at 18:10):
It _should_ work now. The issue was that when this bug originally occurred, I made the fix on master, but not on the R4B branch...we technically have to maintain 2 different pipeline files because they are basically treated as two separate repositories.
Mark Iantorno (Jul 12 2021 at 18:11):
Which leads me to question if anyone committing to R4B has actually been verifying their changes before they commit? or if they were just slamming the merge button as soon as the build was successful...
Mark Iantorno (Jul 12 2021 at 18:11):
which is troubling
Josh Mandel (Jul 12 2021 at 18:11):
They may be verifying locally ;-)
Mark Iantorno (Jul 12 2021 at 18:11):
Ah, there you go
Mark Iantorno (Jul 12 2021 at 18:12):
i wish I shared your faith in people
Mark Iantorno (Jul 12 2021 at 18:13):
@Gino Canessa please let me know once it builds, if it succeeds or fails
Gino Canessa (Jul 12 2021 at 18:13):
Will do right after my current meeting
Gino Canessa (Jul 12 2021 at 19:12):
Thanks @Mark Iantorno , the branch is published correctly after the CI build.
Mark Iantorno (Jul 12 2021 at 19:12):
nice
Rik Smithies (Jul 12 2021 at 20:15):
@Mark Iantorno hi, I dont understand this:
been verifying their changes before they commit? or if they were just slamming the merge button as soon as the build was successful...
I don't know of a way to verify online before merge.
I merge as soon as the online build "some checks are needed" is finished.
Obviously I build and check it looks ok locally before committing. If you don't do that you have no idea what your changes look like.
Mark Iantorno (Jul 12 2021 at 21:59):
Yeah that's what I mean. The system was set up to actually post a live version of your PR on build.fhir.org/branches if the PR is successful.
Mark Iantorno (Jul 12 2021 at 22:00):
So I was just wondering if people were actually using this feature of the pipeline, or if they were just merging once the build was successful.
Mark Iantorno (Jul 12 2021 at 22:01):
I didn't think of the third option which was that people were also doing a build locally and viewing the page locally on their computer.
Mark Iantorno (Jul 12 2021 at 22:01):
As it stands, the R4B branches website hosting feature was not working on pull requests, and @Gino Canessa pointed this out to me.
Mark Iantorno (Jul 12 2021 at 22:02):
It has been working on master branch with no issues though.
Gino Canessa (Jul 12 2021 at 22:02):
Yes, I build locally before pushing, but it's harder to collaborate with a group if I have the only copy (asking everyone to build locally isn't a great workflow =)
Mark Iantorno (Jul 12 2021 at 22:02):
Yeah, that's what I figured.
Mark Iantorno (Jul 12 2021 at 22:03):
@Rik Smithies next time you rip a pull request on R4B, let me know, and I can show you what's up if you'd like.
Rik Smithies (Jul 12 2021 at 22:14):
@Mark Iantorno thanks for the info, I had no idea that each branch build had an online output
Gino Canessa (Jul 14 2021 at 16:01):
@Rik Smithies in order to trigger the build/publish you need to have a PR on the branch. I would recommend creating one any time you make a branch so that it just runs any time you push.
Rik Smithies (Jul 20 2021 at 18:01):
thanks @Gino Canessa @Mark Iantorno I now have an R4B build showing up on the server
Mark Iantorno (Jul 20 2021 at 18:12):
Nice :ok:
Last updated: Apr 12 2022 at 19:14 UTC
