Stream: committers
Topic: R3 and R4 upgrades
Grahame Grieve (Nov 01 2019 at 01:05):
The technical part of the R3 and R4 upgrades is complete, and you can now validate and publish IGs again.
Grahame Grieve (Nov 01 2019 at 01:06):
Note: you must upgrade the version of your IG to either 3.0.2 or 4.0.1 in order to publish
Grahame Grieve (Nov 01 2019 at 01:06):
There's no other changes required, and you don't need your dependencies to upgrade- you can use them as is (should work)
Sarah Gaunt (Nov 01 2019 at 02:10):
@Grahame Grieve I've updated fhirVersion in the IG to 4.0.1 (https://github.com/HL7/case-reporting/blob/master/source/resources/implementationguide/hl7-fhir-us-ecr.xml) AND version in ig.json to 4.0.1 (https://github.com/HL7/case-reporting/blob/master/ig.json)
Also replaced all fhirVersions in the resources (because it failed when I just did the above two).
When I had just replaced the versions in the IG and ig.json it was failing with
Error: the IG declares that is based on version 4.0.0 but this IG publisher only supports publishing the following versions: 1.0.2, 1.4.0, 3.0.2, 4.0.1, 4.1.0
After relplacing all the fhirVersion in all the resources it's failing with:
Load USCoreR4 (http://hl7.org/fhir/us/core) from hl7.fhir.us.core#3.0.0 (00:18.0095) Publishing Content Failed: null (00:18.0096)
What am I missing? Or am I jumping the gun and trying too soon?
Grahame Grieve (Nov 01 2019 at 02:43):
@James Agnew I can't debug this because eclipse has started ignoring my source again....
Grahame Grieve (Nov 01 2019 at 02:45):
no. I found the right maven update to run. @Sarah Gaunt new version on the way
Sarah Gaunt (Nov 01 2019 at 03:30):
That fixed it!! Thanks!
Sarah Gaunt (Nov 01 2019 at 03:32):
Well.. apart from the 125 broken links from US Core and FHIR value sets that are now showing up....
So we are supposed to be sending this IG out for work group review before publication over the weekend - will these broken links go away? Are they just because everything hasn't been uploaded/updated yet?
Richard Townley-O'Neill (Nov 01 2019 at 03:39):
My builds of STU3 and R4 are working fine with v0.9.90. :tada:
Sarah Gaunt (Nov 01 2019 at 03:41):
Lucky!! I'm getting a ton of broken links now: https://build.fhir.org/ig/HL7/case-reporting/branches/master/qa.html#internal
But I think they are all US Core based which you are most likely not using...
Richard Townley-O'Neill (Nov 01 2019 at 03:46):
My R4 ig builds fine with 4.0.1 in the ig.json file and 4.0.0 in the implementation guide file.
Maybe there should be a warning.
Richard Townley-O'Neill (Nov 01 2019 at 03:47):
I already had a lot of unresolved links.
Sarah Gaunt (Nov 01 2019 at 03:48):
Mine was broken-link free!! :joy:
Richard Townley-O'Neill (Nov 01 2019 at 03:50):
Congratulations and commiserations.
Grahame Grieve (Nov 01 2019 at 09:33):
it's not broken link free anymore - I count 2 genuine broken links. The others are fixed next release
Sarah Gaunt (Nov 01 2019 at 09:41):
Maybe I shouldn't have said broken link free... Unknown-by-me broken link free would be more accurate. Great about the fixes, will test again tomorrow...
Grahame Grieve (Nov 01 2019 at 09:48):
releasing now
John Moehrke (Nov 01 2019 at 16:31):
My son @ryan moehrke was looking at the HISTORY of changes and noticed that many (all?) of the "Task" links are not properly encoded so that gForge can't find the item
http://hl7.org/fhir/R4/history.html
The problem is that the URL in the href has a "#" in front of the gForge number. e.g.
https://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=#20463
should be
https://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=20463
Lloyd McKenzie (Nov 01 2019 at 16:59):
They'll soon all break when we move to Jira anyhow...
Grahame Grieve (Nov 01 2019 at 20:21):
there's a lot of gForge links in FHIR. And a huge number of external links to gForge. We're not leaving a redirection behind?
Grahame Grieve (Nov 01 2019 at 20:23):
fixed the links
Lloyd McKenzie (Nov 01 2019 at 20:38):
Don't think gforge has any support for redirection
Lloyd McKenzie (Nov 01 2019 at 20:40):
The data will live there for a while as read only, but I expect we'll retire gForge in a year or two at which point nothing will be there. I suppose at that point we could create a custom website in its place full of redirects, but not sure it'd be worth the effort
Grahame Grieve (Nov 01 2019 at 20:44):
well, we have a map of old to new?
Lloyd McKenzie (Nov 01 2019 at 21:20):
Yes. The numbers stay the same, so that part will be straight-forward
Shovan Roy (Nov 04 2019 at 03:06):
Hi @Grahame Grieve , my IG is still broken. I'm using STU3 and getting the following error after updating fhirversion to 3.0.2. Any suggestion will be very helpful?
org.hl7.fhir.exceptions.FHIRException: Problem processing expression (%resource.kind = #39;.logical#39;. or element.first().path = %resource.type) and element.tail().all(path.startsWith(%resource.snapshot.element.first().path&'.')) in profile http://hl7.org/fhir/StructureDefinition/StructureDefinition path StructureDefinition.snapshot: Error in ?? at 1, 3: Found # expecting a token name
at org.hl7.fhir.r5.validation.InstanceValidator.checkInvariant(InstanceValidator.java:4483)
at org.hl7.fhir.r5.validation.InstanceValidator.checkInvariants(InstanceValidator.java:4468)
at org.hl7.fhir.r5.validation.InstanceValidator.checkInvariants(InstanceValidator.java:4357)
at org.hl7.fhir.r5.validation.InstanceValidator.validateElement(InstanceValidator.java:3984)
at org.hl7.fhir.r5.validation.InstanceValidator.checkChild(InstanceValidator.java:4135)
at org.hl7.fhir.r5.validation.InstanceValidator.validateElement(InstanceValidator.java:4007)
at org.hl7.fhir.r5.validation.InstanceValidator.start(InstanceValidator.java:2965)
at org.hl7.fhir.r5.validation.InstanceValidator.validateResource(InstanceValidator.java:4600)
at org.hl7.fhir.r5.validation.InstanceValidator.validate(InstanceValidator.java:835)
at org.hl7.fhir.r5.validation.InstanceValidator.validate(InstanceValidator.java:795)
at org.hl7.fhir.igtools.publisher.Publisher.validate(Publisher.java:3894)
at org.hl7.fhir.igtools.publisher.Publisher.validate(Publisher.java:3136)
at org.hl7.fhir.igtools.publisher.Publisher.loadConformance(Publisher.java:3116)
at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:730)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:618)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6537)
Grahame Grieve (Nov 04 2019 at 09:21):
can I reproduce this?
Shovan Roy (Nov 04 2019 at 11:08):
Thanks @Grahame Grieve , I've finally identified few profiles in my IG which are causing this error. After excluding those profiles, I'm able to run it successfully, however with this error log, I'm unable to find out the root cause of it. Still troubleshooting..
The profile is available here: https://github.com/hl7au/au-fhir-childhealth. If I add the following entry in the ig.xml, it fails:
<resource>
<example value="false"/>
<sourceReference>
<reference value="StructureDefinition/ncdhc-composition-bloodspot-screen"/>
</sourceReference>
</resource>
Hans van Amstel (Nov 04 2019 at 15:05):
Is it still possible to use version 3.01 and/or 4.0.0 in the validation and IG publishing. As we integrated the tooling in our CI pipeline we would like to make the upgrade on a moment that does not interfere with our releases. Also our profiles have an dependency on SDC and there is no SDC 4.0.0 version this causes the IG publishing to stop working.
Lloyd McKenzie (Nov 04 2019 at 15:08):
You could point to the 'current' version of SDC or the ballot release
Eric Haas (Nov 04 2019 at 17:49):
for IGs based on the FHIR CI build ( defined in ig.json "specification": "http://build.fhir.org/",) {{site.data.fhir.version}} is still 4.0.0 and there is a {{site.data.ig.fhirVersion}} which I defined in ig.json and the implementation guide resource.
{ "path": "http://build.fhir.org/", "canonical": "http://www.fhir.org/guides/test3", "igId": "healthedatainc.ig-template2-0.0.0", "igName": "IGTest3", "packageId": "healthedatainc.ig-template2", "igVer": "0.0.0", "errorCount": 14, "version": "4.0.0", <--- "revision": "a53ec6ee1b", "versionFull": "4.0.0-a53ec6ee1b", <--- "toolingVersion": "4.1.0", "toolingRevision": "3", "toolingVersionFull": "4.1.0 (3)", "totalFiles": 14, "processedFiles": 167, "genDate": "Mon, Nov 4, 2019 09:31-0800", "genDay": "04/11/2019", "ig": { "id": "healthedatainc.ig-template2-0.0.0", "name": "IGTest3", "title": "IG Test3", "url": "http://www.fhir.org/guides/test3/ImplementationGuide/healthedatainc.ig-template2-0.0.0", "version": "0.0.0", "status": "draft", "experimental": false, "publisher": "Health eData Inc", "contact": [ { "telecom": [ "mailto:ehaas@healthedatainc.com" ] }, { "telecom": [ "http://foobar.com" ] } ], "date": "2019-11-04T09:31:08-08:00", "copyright": "Used by permission of Health eData Inc, all rights reserved Creative Commons License", "fhirVersion": "4.0.1" <--- }, "qicore": "https://build.fhir.org/ig/HL7/fhir-qi-core/", "uscore": "https://build.fhir.org/ig/HL7/US-Core/" }
Eric Haas (Nov 04 2019 at 17:52):
I think it should be 4.1.0 which aligns with the package version.
Eric Haas (Nov 04 2019 at 18:32):
when specify 4.1.0 in config file I get this error
org.hl7.fhir.exceptions.FHIRException: Unable to resolve the package 'null'
at org.hl7.fhir.utilities.cache.PackageCacheManager.loadPackage(PackageCacheManager.java:599)
at org.hl7.fhir.igtools.publisher.Publisher.loadCorePackage(Publisher.java:2048)
at org.hl7.fhir.igtools.publisher.Publisher.initializeFromJson(Publisher.java:1672)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:1125)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:612)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6537)
Erics-Air-2:IG-Template2 ehaas$
Grahame Grieve (Nov 04 2019 at 19:18):
@Shovan Roy I think I deployed a fix for this, but you may need to clear your package cache to get the fix
Grahame Grieve (Nov 04 2019 at 19:19):
@Eric Haas this is in github somewhere?
Grahame Grieve (Nov 04 2019 at 19:20):
@Hans van Amstel I don't follow the bit about SDC.. there should be no change to anything there.
Grahame Grieve (Nov 04 2019 at 19:20):
but no, it's not possible to use the old infrastructure
Eric Haas (Nov 04 2019 at 19:25):
@Grahame Grieve {{site.data.fhir.version}} is still 4.0.0 for US Core too and that references http://hl7.org/fhir/R4/ I will commit now....
Eric Haas (Nov 04 2019 at 19:36):
see footer on http://build.fhir.org/ig/HL7/US-Core-R4/branches/master/index.html
repro is here: https://github.com/HL7/US-Core-R4
Hans van Amstel (Nov 06 2019 at 10:46):
@Grahame Grieve We try to publish the IG of profiles that have references to hl7.fhir.uv.sdc. When we use IG publisher, hl7.fhir.r4.core#4.0.1 resolves nicely but then we get the log output:
Publishing Content Failed: Unable to resolve the package 'hl7.fhir.uv.sdc'
When we use an older setup with hl7.fhir.r4.core#4.0.0 the package hl7.fhir/uv/sdc resolves.
@Lloyd McKenzie Thanks for the suggestion this solves it.
Last updated: Apr 12 2022 at 19:14 UTC
