Stream: committers
Topic: QA Issue: Group.value
Grahame Grieve (Nov 12 2018 at 02:45):
@Brian Postlethwaite @Cooper Thompson The search parameter Group.value has the type token, but refers to a polymorphic type which includes quantity and reference- this is a problem
Grahame Grieve (Nov 12 2018 at 02:45):
it needs to follow the same pattern as Observation - has PA considered which types need to be searchable? All of them>
Brian Postlethwaite (Nov 12 2018 at 02:46):
And is a FHIR-I resource ;)
Grahame Grieve (Nov 12 2018 at 02:46):
oh? oops. @Lloyd McKenzie @Ewout Kramer @Rick Geimer @Josh Mandel
Brian Postlethwaite (Nov 12 2018 at 02:46):
It just sits under the Administrative module (but isn't PA) - easy mistake
Josh Mandel (Nov 12 2018 at 02:48):
Oh, good call -- and yes likely all of them
Lloyd McKenzie (Nov 12 2018 at 02:56):
Is fixing it going to cause issues at this point?
Grahame Grieve (Nov 12 2018 at 03:26):
not fixing it is causing me issues. I must at least fix the definition of the existing parameter
Grahame Grieve (Nov 12 2018 at 03:31):
@Brian Postlethwaite I'm going to have a series of these - if they affect the dotnet reference implementation, you might want to wait
Brian Postlethwaite (Nov 12 2018 at 03:32):
Ok, will do. I'll do a quick pass just to see if anything new pops up - thanks.
Grahame Grieve (Nov 12 2018 at 07:06):
so I've change the Group.value parameter to Group.characteristic.value as CodeableConcept | Group.characteristic.value as boolean - I'll leave it to FHIR-I to decide whether to add more parameters or not
Grahame Grieve (Nov 12 2018 at 07:07):
@Brian Postlethwaite I made one other change i nthe IDMP space - all my changes are committed (but not yet in trunk)
Brian Postlethwaite (Nov 12 2018 at 07:09):
Thanks, they are building clean in the dotnet client at the moment, so happy where we stand.
Lloyd McKenzie (Nov 12 2018 at 12:00):
FHIR-I isn't meeting this week. Is it something that can be decided the following week? My leaning would be to make all of the criteria searchable - that's sort of what they're for. We should also look at transferring Group to either PHER or BR&R in R5 as that's who the resource is really for...
Brian Postlethwaite (Nov 12 2018 at 12:06):
You sure that's the appropriate group? Use lots in commity care and other care settings.
Lloyd McKenzie (Nov 12 2018 at 12:24):
The Group resource was defined for that purpose - clinical trials, public health investigations, etc. I know it's getting used a lot for practitioner groups, but that's an "iffy" use to me because Group can't have any responsibility or take any action.
Brian Postlethwaite (Nov 12 2018 at 12:29):
I think those 2 groups are too narrow for its purpose personally. If it was to go anywhere, I would have thought Patient Care or Administration, as its use is mostly core to other activities (like Patient?)
Josh Mandel (Nov 12 2018 at 14:41):
Oh, good call -- and yes likely all of them
Lloyd McKenzie (Nov 12 2018 at 14:58):
I'm ok with PA so long as it retains its original scope
Brian Postlethwaite (Nov 13 2018 at 07:33):
I'm happy with Fhir - I keeping it, and no don't want to change the scope.
Last updated: Apr 12 2022 at 19:14 UTC
