Stream: committers
Topic: QA - Invariant tests
Brian Postlethwaite (Dec 05 2018 at 23:51):
I've tested the core invariants against all the examples in the spec and all compile and run ok.
The only "warnings" that I get are from the "Name should be usable as an identifier for the module by machine processing applications such as code generation" style rules over the conformance resources.
name.matches('[A-Z]([A-Za-z0-9_]){0,254}')
(and same for the invariants defined in profiles-others.xml)
I guess that's a pretty good result, @Grahame Grieve is that what you would expect from all the examples today, does the core validator agree with that?
Grahame Grieve (Dec 06 2018 at 01:41):
yes it does find the same issues
Brian Postlethwaite (Dec 07 2018 at 06:15):
Then I'm happy with the state of things as they are now (from a dotnet code generation and build quality perspective), with the exception of the Consent.source-reference search param, which I'm sure works, but could be better. So not too stressed about it.
John Moehrke (Dec 07 2018 at 13:51):
I am sure the CBCC committee didn't define that query parameter. I am sure it came from Grahame. I think it is simply a query parameter to be tested against Consent.sourceReference. I think the complexity is coming for no intended reason.
John Moehrke (Dec 07 2018 at 13:55):
what happens if the query parameter in the spreadsheet is simplified? (Removing the Target Types, and focusing on sourceReference)?
John Moehrke (Dec 07 2018 at 15:11):
I made that change to Consent locally, and it builds to what seems to me to be functionally the same functionality.
John Moehrke (Dec 08 2018 at 14:37):
I made that change to Consent locally, and it builds to what seems to me to be functionally the same functionality.
@Brian Postlethwaite @Grahame Grieve do you want this change made to Consent?
Grahame Grieve (Dec 08 2018 at 23:20):
no sure, I'll look at it later today
Brian Postlethwaite (Dec 09 2018 at 00:10):
I thought it was code generated thing anyway.
Last updated: Apr 12 2022 at 19:14 UTC
