Stream: committers
Topic: Pull requests fails but isn't wrong
David Pyke (Oct 25 2019 at 14:17):
I put in an update to consent (https://github.com/HL7/fhir/compare/consent-updates-dp-1?expand=1) and the build is failing as it doesn't recognize a change that's actually in the consent-spreadsheet. I changed the status element's list and the description but it thinks the description hasn't changed. Can someone with knowledge of how to address this have a look? THe change is present in the diff (and my local).
Grahame Grieve (Oct 25 2019 at 17:55):
it does think it's changed, it just says you have a syntax error in it
David Pyke (Oct 25 2019 at 18:07):
But it works locally.. Bugger. I'll have a look.
David Pyke (Oct 25 2019 at 18:50):
Okay, I fixed the problem with in my spreadsheet (man is the build server picky about spaces)
But now I get:
[java] ERROR @ Consent.status: Status element code "unknown" not found in status-codes.xml (src = ResourceValidator)
[java] ERROR @ Consent.status: Status element code "proposed" found in status-codes.xml but has no matching code (src = ResourceValidator)
[java] ERROR @ Consent.status: Status element code "rejected" found in status-codes.xml but has no matching code (src = ResourceValidator)
Is this a file I should be editing?
David Pyke (Oct 25 2019 at 18:51):
I've removed proposed and rejected from the spreadsheet and added unknown (for a GF ticket fix).
David Pyke (Oct 25 2019 at 18:53):
The code changes show up in my local version of the file.
Grahame Grieve (Oct 25 2019 at 19:52):
yes you need to edit status-codes.xml
Grahame Grieve (Oct 25 2019 at 19:52):
it's a spreadsheet - open in excel - and maps your status codes to the canonical status codes
David Pyke (Oct 25 2019 at 20:39):
Okay, that was a step I wasn't aware of. Thank you
Sean McIlvenna (Nov 28 2021 at 21:06):
I'm running into the same issue here..
What would be the "canonical" status code for the concept "deprecated"?
Sean McIlvenna (Nov 28 2021 at 21:08):
Currently I have it mapped to "stopped"...
"cancelled" is probably more appropriate, but that is already being used in this case
Grahame Grieve (Nov 28 2021 at 22:00):
what case?
Sean McIlvenna (Nov 28 2021 at 22:27):
adding "deprecated" to CompositionStatus value set
Sean McIlvenna (Nov 28 2021 at 22:28):
which is also used by DocumentReference.docStatus
Grahame Grieve (Nov 29 2021 at 00:45):
where is it already being used in this case?
Last updated: Apr 12 2022 at 19:14 UTC
