Stream: committers
Topic: Pull request accept rights
Patrick Werner (Oct 28 2018 at 17:53):
As i just saw most people merging their PR themselves, i was wondering if everybody is allowed to accept their own PR?
Bryn Rhodes (Oct 28 2018 at 18:07):
Yes, if it passes the build checks, you can merge it.
Lloyd McKenzie (Oct 28 2018 at 19:37):
We were trying to have the merge automatically happen, but the first set of software we tried to make that happen with caused problematic side effects. @Josh Mandel - was that our only option to get merges to happen automatically?
Grahame Grieve (Oct 29 2018 at 06:11):
Patrick is asking the question in the other direction. We considered having people with commit rights but not merge rights, and we might do that in the future, but for now, I prefer that we enforce good behavior with social expectations, not forcing a maintenance nightmare for a few merger approvers
Last updated: Apr 12 2022 at 19:14 UTC
