Stream: committers
Topic: Problem with non-mergeable spreadsheets
Lloyd McKenzie (Aug 14 2018 at 21:20):
Grahame did a lot of work getting the IGPublisher to re-write the spreadsheets so they're actually "mergeable" - i.e. you can look at a diff and understand what changes occurred and actually have a chance of doing a merge and having it work. However, that requires that:
a) you run a local build up to the schema-generation phase before you commit; and
b) you don't have any of the relevent spreadsheets open when you run the build
Right now, we have < 50% compliance to that process. (and I'm one of the ones who messes it up at least half the time). One way to encourage better compliance would be to have the CI build fail if it encounters any spreadsheets that haven't been appropriately reprocessed. Grahame asked me to raise the issue here to see what people think.
Eric Haas (Aug 14 2018 at 21:34):
IG publisher or the Build?
Grahame Grieve (Aug 14 2018 at 21:41):
build. Lloyd asked me to extend the arraaement to the IG publisher, and I said , what's the point? it's not working for the main build... but we will be going to GIT as soon as I and Josh see a chance...
Rob Hausam (Aug 14 2018 at 22:04):
I've certainly forgotten that sometimes (particularly about closing the spreadsheets). I think it would be helpful and would result in less churn in the build if it did fail and also gave a clear and explicit error message about what was wrong and what file(s) were the cause.
Grahame Grieve (Aug 15 2018 at 02:42):
well, we'll try it out
Eric Haas (Aug 15 2018 at 16:40):
for Ig publisher - I don't have a problem interpreting the error messages ( since I have made most of these errors enough times to remember ) and would rather keep the spreadsheets open. So I personally don't see a need.
Lloyd McKenzie (Aug 15 2018 at 18:46):
This is a change for the core spec right now - though the intention is to have it in the IGPublisher too. If you have multiple people working on spreadsheets, the committed spreadsheets need to be mergeable.
Last updated: Apr 12 2022 at 19:14 UTC
