Stream: committers
Topic: Observation Statistics CodeSystem Issue
Richard Ettema (Dec 05 2016 at 00:11):
I just noticed an issue with the Observation resource definition. There is a new bindings worksheet in the observation-spreadsheet.xml named 'observation-statistics'. This binding has two code values defined with a leading '%' character --> '%20' and '%80'. This bindings worksheet generates the Java Enum class 'model/codesystems/ObservationStatistics.java' with those two code values as enum names. That won't compile because the '%' character is illegal in Java variable/identifier names.
Recommendation - change those codes to '20th' and '80th' respectively.
Grahame Grieve (Dec 05 2016 at 00:13):
nah, should fix the Java code generator
Richard Ettema (Dec 05 2016 at 00:16):
Replace the '%' with '_'?
Grahame Grieve (Dec 05 2016 at 00:16):
I'd do "pct"
Richard Ettema (Dec 05 2016 at 00:17):
Do you want a gforge tracker?
Grahame Grieve (Dec 05 2016 at 00:19):
sure
Richard Ettema (Dec 05 2016 at 00:22):
#12427
Richard Ettema (Dec 05 2016 at 03:04):
@Grahame Grieve I added logic to JavaBaseGenerator.makeConst(String cc) to replace '%' with 'pct' and successfully tested locally. The ObservationStatistics.java enum class is now generated with the '%20' and '%80' set to 'PCT20' and 'PCT80' respectively.
Ok if I commit my change?
Grahame Grieve (Dec 05 2016 at 03:05):
yes please
Richard Ettema (Dec 05 2016 at 03:06):
Done.
Brian Postlethwaite (Dec 05 2016 at 07:08):
Hmm, I'll probably hit this one too.
Last updated: Apr 12 2022 at 19:14 UTC
