Stream: committers
Topic: NullPointerException when making ValueSet profile
Marc Duteau (Mar 30 2021 at 19:16):
While making the VSD Profile I ran into a NullPointerException and I'm not exactly sure what's causing it: java.lang.NullPointerException
at org.hl7.fhir.r5.conformance.ProfileUtilities.processElementsIntoTree(ProfileUtilities.java:5285)
at org.hl7.fhir.r5.conformance.ProfileUtilities.processElementsIntoTree(ProfileUtilities.java:5296)
at org.hl7.fhir.r5.conformance.ProfileUtilities.sortDifferential(ProfileUtilities.java:5247)
at org.hl7.fhir.tools.publisher.Publisher.sortProfile(Publisher.java:1096)
at org.hl7.fhir.tools.publisher.Publisher.processProfile(Publisher.java:1062)
at org.hl7.fhir.tools.publisher.Publisher.processProfiles(Publisher.java:910)
at org.hl7.fhir.tools.publisher.Publisher.execute(Publisher.java:609)
at org.hl7.fhir.tools.publisher.Publisher.main(Publisher.java:473)
Grahame Grieve (Mar 30 2021 at 19:22):
weird. how do I reproduce that?
Marc Duteau (Mar 30 2021 at 19:24):
I've uploaded the files to the branch I'd made. https://github.com/HL7/fhir/tree/vocab-vsdalignedprofile-r5
Marc Duteau (Mar 30 2021 at 19:30):
But what I did was I made the vsd-alignedvalueset profile structure definition, an implementationguide-ValueSet-vsdalignedvalueset.xml file for it, like the one for the shareable valueset profile, and then the reference to that file in the list-ValueSet-packs.xml file.
Marc Duteau (Mar 30 2021 at 21:40):
Appears to be solved. My structure definition got very very messed up somehow.
Jean Duteau (Mar 31 2021 at 00:56):
i took over (tag team) and we have an NPE in a different spot:
java.lang.NullPointerException
at org.hl7.fhir.tools.publisher.PageProcessor.produceProfiles(PageProcessor.java:7451)
at org.hl7.fhir.tools.publisher.PageProcessor.processResourceIncludes(PageProcessor.java:6119)
at org.hl7.fhir.tools.publisher.Publisher.produceResource2(Publisher.java:3995)
at org.hl7.fhir.tools.publisher.Publisher.loadValueSets2(Publisher.java:1275)
at org.hl7.fhir.tools.publisher.Publisher.produceSpec(Publisher.java:2339)
at org.hl7.fhir.tools.publisher.Publisher.produceSpecification(Publisher.java:2180)
at org.hl7.fhir.tools.publisher.Publisher.execute(Publisher.java:613)
at org.hl7.fhir.tools.publisher.Publisher.main(Publisher.java:473)
I'm sure this is still something we've done to the structure, but the NPE doesn't help us figure it out.
Jean Duteau (Mar 31 2021 at 01:18):
same branch as above if anyone wants to tell me what the NPE is actually trying to tell us. (@Grahame Grieve @Mark Iantorno)
Mark Iantorno (Mar 31 2021 at 02:14):
Did the pipeline produce this output, or was this local to your computer?
Mark Iantorno (Mar 31 2021 at 02:14):
If produced by the pipeline, can you please link to the build
Jean Duteau (Mar 31 2021 at 02:24):
local. i haven't tried a pull request merge because I get that error on the local build
Jean Duteau (Mar 31 2021 at 02:31):
but i did check everything in, so a clone of that branch should cause the same error
Mark Iantorno (Mar 31 2021 at 12:08):
I'm going to open a pr so I can view the entire logs
Jean Duteau (Mar 31 2021 at 15:17):
yay, you get the same error on CI.
Mark Iantorno (Mar 31 2021 at 17:16):
You are currently 3rd in my queue of issues to look at. FYI
Jean Duteau (Mar 31 2021 at 17:41):
no worries. Marc and I have other issues to work on. i'm just glad that someone else got the error so it's not in our setup.
Mark Iantorno (Mar 31 2021 at 17:42):
In cases like this, I would always advise taking the time to build on the CI by creating a pull request
Mark Iantorno (Mar 31 2021 at 17:43):
The cloud environment is a 'clean' environment that we use as the baseline for testing
Mark Iantorno (Mar 31 2021 at 17:43):
if it is broken on the cloud, that means it's most likely broken everywhere
Jean Duteau (Mar 31 2021 at 17:43):
makes sense
Grahame Grieve (Mar 31 2021 at 19:56):
the profile vsd-alignedvalueset is not registered in an IG
Jean Duteau (Mar 31 2021 at 20:07):
correct, it is a profile that we're defining in FHIR Core
Grahame Grieve (Mar 31 2021 at 20:23):
yes so you need to register it in the core ig
Jean Duteau (Mar 31 2021 at 20:29):
we did create an implementationguide instance in source/valueset. There is the implementationguide-ValueSet-core.xml that previously existed and we created a new implementationguide-ValueSet-vsdalignedvalueset.xml. Are you saying that we should just incorporate our profile and needed extensions in the existing ig resource?
Grahame Grieve (Mar 31 2021 at 20:33):
yes that one should be in core, not a new IG
Jean Duteau (Mar 31 2021 at 20:34):
ok
Grahame Grieve (Mar 31 2021 at 20:34):
adding a new ig is a much bigger thing I would have to do
Jean Duteau (Mar 31 2021 at 20:36):
okay, i'll make that happen
Jean Duteau (Mar 31 2021 at 21:03):
@Mark Iantorno can I take over your PR and actually merge it if the checks pass?
Mark Iantorno (Mar 31 2021 at 21:29):
Yeah, that's not an issue
Mark Iantorno (Mar 31 2021 at 21:30):
It is labelled "DONT MERGE THIS PR", so you might want to close it and open a new one
Last updated: Apr 12 2022 at 19:14 UTC
