Stream: committers
Topic: Not a travis bug
Josh Mandel (Mar 30 2016 at 13:29):
My local build (on linux) fails just the same way Travis does. So it's not a Travis bug at least.
Josh Mandel (Mar 30 2016 at 13:30):
Build fails with:
[java] java.io.FileNotFoundException: /home/jmandel/work/fhir/publish/qicore/allergyintolerance-example.xml (No such file or directory)
And indeed, my pubs dir has no such file. It does have:
$ find publish/qicore/ | grep -i allergyintolerance | grep -i xml
publish/qicore/allergyintolerance-example-refuted.xml
publish/qicore/allergyintolerance-example-refuted.xml.html
publish/qicore/qicore-allergyintolerance-questionnaire.xml.html
publish/qicore/valueset-qicore-allergyintolerance-reason-refuted.xml.html
publish/qicore/qicore-allergyintolerance-questionnaire.canonical.xml
publish/qicore/valueset-qicore-allergyintolerance-reason-refuted.canonical.xml
publish/qicore/qicore-allergyintolerance.profile.xml.html
publish/qicore/qicore-allergyintolerance-questionnaire.xml
publish/qicore/qicore-allergyintolerance.profile.xml
publish/qicore/valueset-qicore-allergyintolerance-reason-refuted.xml
Jason Walonoski (Mar 30 2016 at 13:39):
Yeah, it is in the guides/qicore folder, but I can't tell why it isn't getting copied to the publish/qicore folder.
Jason Walonoski (Mar 30 2016 at 13:39):
In fact, I can't even tell where in the build code it should be getting copied.
Jason Walonoski (Mar 30 2016 at 13:43):
If I rename the example file, it seems to copy over -- I have no idea why -- in a few more minutes I'll see if this fixes the build (still publishing locally....)
Jason Walonoski (Mar 30 2016 at 13:50):
That seems to have fixed that error... but it moves to another file now. I think something in the recent changes is requiring examples to have unique names...
Richard Ettema (Mar 30 2016 at 13:54):
If you look at the uslab examples, they all have "-uslab-" embedded in their names. We could do the same for the qicore example files.
Jason Walonoski (Mar 30 2016 at 13:55):
I'm making those changes now to qicore
Richard Ettema (Mar 30 2016 at 13:56):
You'll also have to update the example references in the qicore.xml file.
Jason Walonoski (Mar 30 2016 at 13:56):
Got it.
Richard Ettema (Mar 30 2016 at 14:07):
I just finished re-reviewing qicore.xml. There's one missing qicore example file that needs to be added - medication-example.xml. Following the new naming pattern it should be "medication-qicore-example.xml".
Richard Ettema (Mar 30 2016 at 14:07):
Hope I caught you before you started another build.
Jason Walonoski (Mar 30 2016 at 14:10):
Got it, thanks.
Jason Walonoski (Mar 30 2016 at 14:11):
Still building locally...
Richard Ettema (Mar 30 2016 at 14:13):
I made the same changes in my local environment and am starting another build as well. Thanks.
Jason Walonoski (Mar 30 2016 at 14:17):
Successful. Pushing to svn.
Richard Ettema (Mar 30 2016 at 14:17):
Cool. Thanks!
Jason Walonoski (Mar 30 2016 at 14:28):
Didn't push all the files...
Jason Walonoski (Mar 30 2016 at 14:38):
And I accidentally changed some .classpath files so I just reverted those.
Richard Ettema (Mar 30 2016 at 14:38):
That medication example file appears to be out of date. It looks like the <name> and <kind> elements need to be removed.
Jason Walonoski (Mar 30 2016 at 14:40):
I'm just removing the reference to the example. The qicore team will have to figure out what to do with that (maybe it wasn't referenced on purpose).
Jason Walonoski (Mar 30 2016 at 14:42):
8130 should fix everything...
Richard Ettema (Mar 30 2016 at 14:45):
fingers crossed :)
Grahame Grieve (Mar 30 2016 at 18:30):
ah it was my bug after all. I just didn't see it locally because I had files left over from a previous build. There was an easier fix, but this one works anyway
Grahame Grieve (Mar 30 2016 at 18:30):
sorry about that guys
Richard Ettema (Mar 30 2016 at 18:31):
No worries. You needed sleep, we needed a challenge. :)
Last updated: Apr 12 2022 at 19:14 UTC
