Stream: committers
Topic: New Milestone
Grahame Grieve (Apr 30 2020 at 00:36):
I'm getting ready to cut a new stable version of FHIR. Does anyone have any last minute submissions to make?
Bryn Rhodes (Apr 30 2020 at 02:04):
I know that the EBM on FHIR group has a draft resource they want to submit for use at the connectathon as part of the COVID-19 accelerator they are working on. @Khalid Shahin ?
Khalid Shahin (Apr 30 2020 at 02:38):
Yes, @Bryn Rhodes , we want to create two new resources and a profile for Composition. I was planning on creating these on Friday, but I can do it sooner if it's needed.
Also I have some cleanup changes for removal of unused resources that I'm ready to commit, but I have a question about one file: https://chat.fhir.org/#narrow/stream/179165-committers/topic/Difficulties.20running.20publish.20on.20new.20installations/near/195692023
Grahame Grieve (Apr 30 2020 at 02:52):
what's not fixed there?
Khalid Shahin (Apr 30 2020 at 03:05):
Grahame Grieve said:
what's not fixed there?
For some reason I copied the wrong link. Here's the correct one: https://chat.fhir.org/#narrow/stream/179165-committers/topic/Handling.20removed.20resources.20in.20resource-name-tracker.2Exml/near/195740164
Rob Hausam (Apr 30 2020 at 05:09):
@Grahame Grieve When are you planning to do this (I don't think you already have)? I should try to get the additional ConcpetMap changes in, if possible.
Jose Costa Teixeira (Apr 30 2020 at 05:26):
I have a few changes to do on Device - depending on when you do release, I can squeeze in a few changes.
the ones I think are more important/feasible:
- Remove URL from DeviceDefinition
- DeviceDefinition to FMM1
- A few simple changes to Device that were requested by @Brian Reinhold and others
Grahame Grieve (Apr 30 2020 at 05:45):
well, you have 20 hours
Jose Costa Teixeira (Apr 30 2020 at 05:47):
thanks
Rob Hausam (Apr 30 2020 at 10:33):
so about 15 now, then?
Grahame Grieve (Apr 30 2020 at 10:34):
y
Jose Costa Teixeira (Apr 30 2020 at 21:10):
I was just reminded of one missing fix, I'm now running the build locally, will commit right away (I hope)
Jose Costa Teixeira (Apr 30 2020 at 21:57):
i just made a PR, I don't think it triggered the build
Jose Costa Teixeira (Apr 30 2020 at 21:58):
do i need to do anything to trigger it?
Jose Costa Teixeira (Apr 30 2020 at 22:00):
https://github.com/HL7/fhir/pull/860
Jose Costa Teixeira (Apr 30 2020 at 22:06):
@Grahame Grieve should I give it some time, or I have to do something?
I don't see anything here https://dev.azure.com/fhir-build/build.fhir.org/_build
Grahame Grieve (Apr 30 2020 at 22:51):
@Josh Mandel ?
Grahame Grieve (Apr 30 2020 at 22:52):
@Jose Costa Teixeira try committing a whitespace change to get it to initiate again
Jose Costa Teixeira (Apr 30 2020 at 22:55):
that seems to have unblocked it
Jose Costa Teixeira (Apr 30 2020 at 23:00):
yes, it's working. thanks
Khalid Shahin (Apr 30 2020 at 23:09):
How much time do we have to submit our changes into the FHIR build?
Grahame Grieve (Apr 30 2020 at 23:13):
a few hours.
Grahame Grieve (Apr 30 2020 at 23:13):
probably 5
Khalid Shahin (May 01 2020 at 00:16):
If I'm making new resources, should I add them in the "resource-name=tracker.xml" under the R4 column?
Grahame Grieve (May 01 2020 at 00:17):
no because you are not adding them to R4
Rob Hausam (May 01 2020 at 00:49):
I have the ConceptMap updates coming.
Khalid Shahin (May 01 2020 at 02:16):
I have two resources working in my local build, and I'm working on the Profile.
Grahame Grieve (May 01 2020 at 02:17):
ok I'm about 2 hours away from needing to commit
Rob Hausam (May 01 2020 at 02:34):
I think I'm (slightly) ahead of that. But checking the build takes a pretty long time.
Khalid Shahin (May 01 2020 at 03:42):
I got the work done, I'm doing a fresh local build of it to make sure there are no errors. A few things were causing problems, one was the resources needed "useContext" and other fixes that didn't show up initially.
Khalid Shahin (May 01 2020 at 04:09):
My local build is process, I estimate 15 more minutes until it's done. And then I'll PR and merge the branch.
Rob Hausam (May 01 2020 at 04:31):
I'm still working on a local build, following the org.hl7.fhir.core updates..
Grahame Grieve (May 01 2020 at 04:39):
ok ar we done now?
Khalid Shahin (May 01 2020 at 04:42):
The local build for me is taking longer than expected, but it should be just a few more minutes. But then there would be the online check before the merge.
Khalid Shahin (May 01 2020 at 04:55):
Unfortunately the build failed late in the process and now I'm getting a NullPointerException on publish.
Grahame Grieve (May 01 2020 at 04:58):
where?
Khalid Shahin (May 01 2020 at 04:59):
On my local computer build.
Grahame Grieve (May 01 2020 at 04:59):
yes but where in the build?
Khalid Shahin (May 01 2020 at 05:00):
profiles-resources and structure definition
Khalid Shahin (May 01 2020 at 05:00):
"validate profiles-resources"
Grahame Grieve (May 01 2020 at 05:02):
did you get a stack dump?
Khalid Shahin (May 01 2020 at 05:02):
I did, but I cleared it.
Khalid Shahin (May 01 2020 at 05:02):
I had to fix one element in the resource. I think it could build now, but the local build will take another 45 minutes. And I don't suppose I can skip that local build step right?
Grahame Grieve (May 01 2020 at 05:03):
you need to get to where it says "Produce Content" before you commit. but then you can
Khalid Shahin (May 01 2020 at 05:10):
Kind of weird. I recloned and reapplied my changes and I get this error early on.
[java] FHIR build failure @ Fri, May 1, 2020 01:08-0400 2.324 27sec 1989MB
[java] Error: null
BUILD FAILED
C:\Users\Khalid\Documents\GitHub\fhir\build.xml:30: The following error occurred while executing this line:
C:\Users\Khalid\Documents\GitHub\fhir\tools\java\org.hl7.fhir.tools.core\build.xml:70: Java returned: 1
Grahame Grieve (May 01 2020 at 05:11):
you're missing a max cardinality on some element you defined
Grahame Grieve (May 01 2020 at 05:14):
something has come up here - you have another hour
Khalid Shahin (May 01 2020 at 05:23):
I got to produce content. Committed the branch and I'm doing the PR merge check at this moment. I will tell you if it's successful and merged.
Khalid Shahin (May 01 2020 at 05:50):
Passed the check, and merged. I made two draft resources and in order for the build to work I had to edit these files to include the names of the resources:
source\fhir.ini
source\hiearchy.xml
source\status-codes.xml
source\compartments.xml
implementations\translations.xml
Is it okay that I changed these files and merged?
(I had two PR merges tonight by the way.)
Rob Hausam (May 01 2020 at 06:16):
I can't build the updates in the fhir build locally right now with the dependency on org.hl7.fhir.core, but I'll create a PR and you can see about it from there. The org.hl7.fhir.core PR failed validation - not sure what that's about, excactly, as it works here.
Rob Hausam (May 01 2020 at 06:58):
Need to update the 'broader' relationship in ConceptMap-cm-address-use-v2.json to 'source-is-narrower-than-target'.
Rob Hausam (May 01 2020 at 06:59):
But didn't locate the source for that yet.
Grahame Grieve (May 01 2020 at 07:02):
that's generated
Rob Hausam (May 01 2020 at 07:03):
right - looked like it was - that's why I couldn't find the source :)
Grahame Grieve (May 01 2020 at 07:03):
updating concept map is very very difficult now.
Grahame Grieve (May 01 2020 at 07:04):
what exactly are the changes?
Rob Hausam (May 01 2020 at 07:06):
I know
it's the two relationships:
'broader' to 'source-is-narrower-than-target'
'narrower' to 'source-is-broader-than-target'
Rob Hausam (May 01 2020 at 07:06):
and some bits of associated documentation
Rob Hausam (May 01 2020 at 07:09):
these are the changes that Vocab approved (again) in Sydney and have been wanting - and would like to review and test in the Connectathon - but if you decide we can't get it in the milestone, then afterward we can keep working on the PRs and get it in the CI build
Rob Hausam (May 01 2020 at 07:18):
Not that I really wanted to do this at all. ;) But had to get it done.
Rob Hausam (May 01 2020 at 07:19):
And I need to get some sleep soon.
Grahame Grieve (May 01 2020 at 07:26):
hmm. well today isn't working out for me at all
Grahame Grieve (May 01 2020 at 07:27):
I've just slipped 24 hours :-(
Rob Hausam (May 01 2020 at 07:29):
There's always something. I'll be back up in maybe 5 hours or so.
Grahame Grieve (May 01 2020 at 07:48):
I'll take over. You can't do that one
Grahame Grieve (May 01 2020 at 13:03):
ok I have it building with no errors, but the validator is broken. Changing this code system is getting really really hard.
Rob Hausam (May 01 2020 at 13:17):
Right, thanks. Yes, it is getting very hard to change - but hopefully we'll be able to stop doing that. I'm not hugely thrilled with this particular change, but it is at least clear what it means, which was the goal.
Grahame Grieve (May 01 2020 at 20:45):
we'll be changing it at least once more because 'source-is-narrower-than-target' is horrible. source-narrower would suffice
Rob Hausam (May 01 2020 at 20:47):
I agree. I tried to persuade them to do something more like that (or 'broader-target' or 'has-broader-target'). :(
Khalid Shahin (May 04 2020 at 12:18):
Oddly enough, the Citation resource page is missing: http://hl7.org/fhir/2020May/citation.html
Grahame Grieve (May 04 2020 at 12:21):
I'll investigate
Last updated: Apr 12 2022 at 19:14 UTC
