Stream: committers
Topic: Missing IsModifierReason
Lloyd McKenzie (Mar 30 2018 at 20:07):
There are still a bunch of places where IsModifierReason is missing:
@Michelle (Moseman) Miller:
Missing IsModifierReason on AllergyIntolerance.clinicalStatus
Missing IsModifierReason on CarePlan.activity.detail.status
Missing IsModifierReason on CarePlan.activity.detail.doNotPerform
Missing IsModifierReason on Condition.clinicalStatus
Missing IsModifierReason on AdverseEvent.actuality
@Brian Postlethwaite
Missing IsModifierReason on Group.characteristic.exclude
Missing IsModifierReason on Patient.deceased[x]
Missing IsModifierReason on Patient.link
@Melva Peters
Missing IsModifierReason on MedicationRequest.substitution.allowed
Missing IsModifierReason on Medication.amount
@David Pyke
Missing IsModifierReason on Consent.scope
@Eric Haas
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/device/device-extensions-spreadsheet.xml, sheet "Extensions", row 3
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/observation/observation-extensions-spreadsheet.xml, sheet "Extensions", row 7
@Craig Newman
Missing IsModifierReason on Immunization.isPotent
Missing IsModifierReason on ImmunizationRecommendation.recommendation.forecastStatus
And a bunch for FHIR-I/Vocab that I'll look after:
Missing IsModifierReason on Basic.code
Missing IsModifierReason on List.mode
Missing IsModifierReason on List.entry.deleted
Missing IsModifierReason on OperationOutcome.issue.severity
Missing IsModifierReason on Questionnaire.item.enableWhen
Missing IsModifierReason on ConceptMap.group.element.target.equivalence
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/capabilitystatement/capabilitystatement-extensions-spreadsheet.xml, sheet "Extensions", row 3
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/questionnaire/questionnaire-extensions-spreadsheet.xml, sheet "Extensions", row 19
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/questionnaire/questionnaire-extensions-spreadsheet.xml, sheet "Extensions", row 22
Missing IsModifierReason on extension @ /home/travis/build/hl7-fhir/fhir-svn/source/codesystem/codesystem-extensions-spreadsheet.xml, sheet "Extensions", row 4
Michelle (Moseman) Miller (Mar 31 2018 at 00:11):
@Lloyd McKenzie PC hasn't voted on GF#15583 yet, but I will go ahead and pre-apply some updates knowing that PC may want to further refine the reasons we resolve the tracker.
Melva Peters (Mar 31 2018 at 00:22):
@Lloyd McKenzie Pharmacy is in the same position as PC. I'll pre-apply some updates that may be refined later
Eric Haas (Mar 31 2018 at 14:45):
I removed OO ismod flags from the extensions and created trackers. Looking forward to what PC and Pharmacy say about isMod and how is applied in the core build. Its definitions is so open to interpretation as to make it useless for me.
Lloyd McKenzie (Mar 31 2018 at 15:19):
"Q:Do you have a pacemaker" - "A: Yes"
"Q:Do you have a pacemaker" - "A: Yes, but it's disabled"
Lloyd McKenzie (Mar 31 2018 at 15:20):
The question is whether a reasonable interpretation of the first answer would be "and it's turned on". If yes, then the status is a modifier.
Lloyd McKenzie (Mar 31 2018 at 15:22):
timeOffset is absolutely a modifier. It changes the effectiveTime. The declared effectiveTime is inaccurate - the event actually occurred x milliseconds later.
Lloyd McKenzie (Mar 31 2018 at 15:22):
(Also, why does time-offset repeat?)
Lloyd McKenzie (Mar 31 2018 at 15:25):
Something is a modifier if looking at the modifier would make you determine that something is untrue about the understanding of the instance you would get if you ignored the modifier element. The modifier reason explains what part(s) of the instance could be made untrue and why.
Melva Peters (Mar 31 2018 at 16:27):
Pharmacy has lots of questions about modifiers now, that's why we haven't made a final decision. Based on Lloyd's comment above we need to add lots of other modifiers in our material.
Lloyd McKenzie (Mar 31 2018 at 17:34):
Examples of ones you think you'd need to add?
Melva Peters (Mar 31 2018 at 23:26):
Not at this point, but will be talking about it over the next few weeks.
Eric Haas (Apr 02 2018 at 04:35):
we have discussed this before and i think Lloyd's explanations above are misleading. Too many isMod will make them irrelevant assuming implementers are even paying attention which i doubt. They may make sense when applied to a profile since there is more context and the party who is interpreting the data is defined.
Eric Haas (Apr 02 2018 at 04:36):
Making us add a reason is a good thing, however, since it does make us question why is flagged and whether it should be.
Lloyd McKenzie (Apr 02 2018 at 04:52):
isModifier is never profile-specific. It's fundamental to the meaning of an element. An element either can change the meaning of other elements or it can't. It's not a question of "too many" - though agree that we should minimize modifiers as much as possible - they're elements that are generally unsafe to ignore, which is something we try to avoid.
Craig Newman (Apr 02 2018 at 16:38):
Immunization resources have been updated
Lloyd McKenzie (Apr 02 2018 at 16:46):
Thanks Craig
Lloyd McKenzie (Apr 02 2018 at 16:47):
Any chance you have time to apply QA to the Immunization or other PHER resource?
Craig Newman (Apr 02 2018 at 16:50):
Probably, depending on what "apply QA" means...
Lloyd McKenzie (Apr 02 2018 at 17:45):
I've emailed you the PHER-related files. Apply as many fixes (that you deem appropriate) and commit in the next 45 minutes or so :)
Craig Newman (Apr 02 2018 at 18:27):
PH QA fixes done - with 4 minutes to spare....
Lloyd McKenzie (Apr 02 2018 at 18:49):
Awesome! Thanks
Last updated: Apr 12 2022 at 19:14 UTC
