Stream: committers
Topic: Lots of FHIR branches that seem old?
Jean Duteau (Feb 01 2022 at 16:25):
Related to the great CI-build purge, I was just looking at the large amount of FHIR core branches that we have. Some of those seem to be old or for a specific purpose. Perhaps we could prune these branches as well?
David Pyke (Feb 01 2022 at 16:31):
So, you're not happy with just breaking the IGs, you want to take down all of fhir?
Jean Duteau (Feb 01 2022 at 16:34):
go big or go home baby!
Jean Duteau (Feb 01 2022 at 16:36):
103 branches and 43 are marked as Merged or Closed. We can certainly delete those? And there are another 20 that are classified as stale because they haven't been touched in a long time.
Lloyd McKenzie (Feb 01 2022 at 17:21):
There may be certain branches we will want to 'protect' from purges (e.g. R4B, though it's not vulnerable yet). But I agree that merged branches and most branches that are untouched in 6+ months are fair game to toast.
Chris Moesel (Feb 01 2022 at 18:02):
If you're not using it already, there is a GitHub setting for "protecting" branches. This lets you set up specific rules for specific branches -- so, for example, you could prevent the R4B from being deleted (or force pushed, or pushed without a PR, etc). Relevant doc: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/about-protected-branches
John Moehrke (Feb 01 2022 at 18:56):
I have been shocked by all the dead pull-requests. Killing them should be caseful, as someone might have moved the Jira ticket to applied, when they had not yet gotten their pull-request merged. This is not likely, but it is not likely that we would have 20 stale branches. so odds are not logical.
Lloyd McKenzie (Feb 01 2022 at 19:55):
Yes, that's definitely something that could have happened. Someone creates the pull request and presumes it'll be handled (and maybe even marks the change as applied.)
Josh Mandel (Feb 01 2022 at 20:22):
If you're not using it already, there is a GitHub setting for "protecting" branches
We do have branch protections on main and R4B. These include prohibition of deletes, as well as requirements on PR build status checks before merges.
Lloyd McKenzie (Feb 01 2022 at 21:16):
Could we do something similar with other CI-build instances that we want to keep alive? (e.g. templates)
Grahame Grieve (Feb 01 2022 at 21:22):
no it's time to move everyone off current
Last updated: Apr 12 2022 at 19:14 UTC
