Stream: committers
Topic: Imaging study DICIM uid
Josh Mandel (Dec 12 2018 at 21:14):
@John Moehrke I just added GF#19765 -- I think https://github.com/HL7/fhir/commit/131af0770aa6467c6907c7f556dfd51b8519f05d#diff-d9577830b4d43d3dfd496e7925c53e08R26 introduced a bug in the example for encoding a DICOM uid as an ImagingStudy.identifier in R4. Do you agree?
John Moehrke (Dec 12 2018 at 21:19):
YES. oops, that should be fixed as a QA technical correction.
John Moehrke (Dec 12 2018 at 21:21):
@Grahame Grieve can this be fixed? Will you do it or should I?
Josh Mandel (Dec 12 2018 at 21:23):
And actually @John Moehrke your commit was right -- it was @Grahame Grieve's https://github.com/HL7/fhir/commit/0df9870cea0a0b10449e9b47e18b49a98e093082#diff-d9577830b4d43d3dfd496e7925c53e08R26 that introduced the discrepancy. Grahame, I assume this was an accident?
Grahame Grieve (Dec 12 2018 at 21:27):
no, it wasn't an accident. I did intend to ask the committee about it, but forgot, so I'm glad it's come up. I reasoned that there was no need to introduce characters urn:oid: which otherwise introduced no value. but I noted somewhere when reviewing this now that the desire was for search to work either way. So prefix is correct, and I'll commit with the prefix
Josh Mandel (Dec 12 2018 at 21:28):
OK! (My main goal is to make sure the descriptive text matches the example, whichever way it goes :-))
Josh Mandel (Dec 12 2018 at 21:31):
(This value: "urn:oid:..." pattern shows up a lot in the spec, so if we don't like it, we'd want to change the advice/examples everywhere I think.)
Grahame Grieve (Dec 12 2018 at 21:32):
it could only be different for urn:dicom:uid
Josh Mandel (Dec 12 2018 at 21:33):
I guess, but would there be a reason to make a special case there?
Grahame Grieve (Dec 12 2018 at 21:33):
well, maybe, but in practice no
John Moehrke (Dec 12 2018 at 21:39):
You also made an uninteded change on the registry http://build.fhir.org/identifier-registry.html
John Moehrke (Dec 12 2018 at 21:39):
dicom does want the urn:oid: prefix
John Moehrke (Dec 12 2018 at 21:41):
right @Elliot Silver ?
Elliot Silver (Dec 12 2018 at 22:02):
Correct, the comment should be "An OID issued under DICOM OID rules. DICOM OIDs are represented with the urn:oid: prefix."
John Moehrke (Dec 12 2018 at 22:08):
thanks @Elliot Silver
Last updated: Apr 12 2022 at 19:14 UTC
