Stream: committers
Topic: IGPublisher Support for R3
Grahame Grieve (Apr 24 2017 at 12:11):
So the IG publisher rolls with the current version - you always get the IG publisher for build.fhir.org (I
Grahame Grieve (Apr 24 2017 at 12:12):
(I'll have to fix the downloads page for this).
Grahame Grieve (Apr 24 2017 at 12:13):
that means that the IG publisher is now running v3.1.0. If you want to publish an R3 guide (e.g. based on 3.0.1), from my next commit you will need to add "version" : "3.0.1" to your ig.json control file
Josh Mandel (Apr 24 2017 at 13:12):
Also the auto-builder will (or may?) need to be aware of this field. Right now it just grabs (hard-coded) http://build.fhir.org/org.hl7.fhir.igpublisher.jar
Grahame Grieve (Apr 24 2017 at 13:14):
that's all it needs to do. It doesn't need to know anything about that the FHIR version of the IG
Josh Mandel (Apr 24 2017 at 13:22):
OK. So one version of the publisher handles builds against all FHIR spec versions? Cool.
Eric Haas (Apr 26 2017 at 01:05):
re: "that means that the IG publisher is now running v3.1.0. If you want to publish an R3 guide (e.g. based on 3.0.1), from my next commit you will need to add "version" : "3.0.1" to your ig.json control file"
I had to change to Version "3.1.0" to get it to work. Did you transpose the numbers in the code?
Grahame Grieve (Apr 26 2017 at 08:14):
no. it should be 3.0.1 - what is the problem?
Eric Haas (Apr 26 2017 at 17:30):
OK let me try again
Eric Haas (Apr 26 2017 at 17:43):
OK I removed the "version" key value pair from my control file and it works. But if you have"version" : "3.0.1", or "version" : "3.0.0" it fails with a
Publishing Content Failed: Unsupported version 3.0.1...
Interestingly "version" : "3.1.0", does not fail.
Eric Haas (Apr 26 2017 at 23:30):
yep ....{{ site.data.fhir.path }}.... yields 3.1.0
Eric Haas (Apr 27 2017 at 00:15):
Separate issue is {{ site.data.fhir.canonical }} not working for <url value="{{ site.data.fhir.canonical }}/blah"/> works in other places in xml at least ( I'm not sure about spreadsheets)
Grahame Grieve (Apr 27 2017 at 05:55):
what happens if you point the IG publisher at tests/ig30?
Eric Haas (Apr 27 2017 at 14:43):
'''
Erics-Air-2:ig30 ehaas$ bash publish.sh
=================================================================
=== Publish test ig30 IG!!! Thu Apr 27 14:42:51 UTC 2017 ===
=================================================================
FHIR Implementation Guide Publisher (3.1.0-11939) @ Thursday, April 27, 2017 7:42:52 AM
Detected Java version: 1.8.0_65 from /Library/Java/JavaVirtualMachines/jdk1.8.0_65.jdk/Contents/Home/jre on x86_64 (64bit). 1820MB available
Load Configuration from /Users/ehaas/Documents/FHIR/build/tests/ig30/test-ig.json (00.0000sec)
File log: /var/folders/_n/bhz7c7qd57d85fvm0g7dzdcw0000gn/T/fhir-ig-publisher-tmp.log
Root directory: /Users/ehaas/Documents/FHIR/build/tests/ig30 (00.0139sec)
Terminology Cache is at /Users/ehaas/Documents/FHIR/build/tests/ig30/txCache. 12 files in cache (00.0179sec)
Publishing Content Failed: Unsupported version 3.0.1 (00.0180sec)
(00.0182sec)
Use -? to get command line help (00.0185sec)
(00.0189sec)
Stack Dump (for debugging): (00.0192sec)
org.hl7.fhir.exceptions.FHIRException: Unsupported version 3.0.1
at org.hl7.fhir.igtools.publisher.Publisher.loadValidationPack(Publisher.java:939)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:739)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:303)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:3593)
Erics-Air-2:ig30 ehaas$
'''
Grahame Grieve (Apr 27 2017 at 21:32):
then you are not using the most recent IG publisher
Eric Haas (Apr 28 2017 at 00:13):
just downloaded IG publisher saem version as above with same result
Grahame Grieve (Apr 28 2017 at 00:48):
alright, wait for 11940 to build, and try that one
Grahame Grieve (Apr 28 2017 at 04:54):
try again with latest - should work this time
Eric Haas (Apr 29 2017 at 17:03):
Ok the latest version of the ig publisher handles the version =3.0.1 in the defintitions files but I think this is still wrong :
Eric Haas (Apr 29 2017 at 17:04):
Jekyll Site Variables
dependency url - e.g. “uscore” : Base url of a dependency implementation Guide (defined in ig.json) - {{ site.data.fhir.uscore }} = http://hl7.org/fhir/us/core/
igName : Title of the implementation Guide (defined in ig.xml) - {{ site.data.fhir.igName }} = Implementation Guide Template
path : path to the main FHIR specification (defined in ig.json)- {{ site.data.fhir.path }} = http://build.fhir.org
canonical : canonical path to this specification (defined in ig.json)- {{ site.data.fhir.canonical }} = http://www.fhir.org/guides/ig-template
errorCount : number of errors in the build file (not including HTML validation errors) - {{ site.data.fhir.errorCount }} = 3
version : version of FHIR - {{ site.data.fhir.version }} = 3.1.0
revision : revision of FHIR - {{ site.data.fhir.revision }} = 11939
versionFull : version-revision - {{ site.data.fhir.versionFull }} = 3.1.0-11939
totalFiles : total number of files found by the build - {{ site.data.fhir.totalFiles }} = 8
processedFiles : number of files genrated by the build - {{ site.data.fhir.processedFiles }} = 108
genDate : date of generation (so date stamps in the pages can match those in the conformance resources) - {{ site.data.fhir.genDate }} = Sat, Apr 29, 2017 09:55-0700
Eric Haas (Apr 29 2017 at 17:05):
The version of the Tool is 3.1.0 but the version of fhir is 3.0.1 so the site variable is off.
Eric Haas (Apr 29 2017 at 17:06):
here is the tool version....
Eric Haas (Apr 29 2017 at 17:06):
Last login: Sat Apr 29 00:22:22 on ttys003 Erics-Air-2:ig30 ehaas$ bash publish.sh ================================================================= === Publish test ig30 IG!!! Sat Apr 29 16:57:38 UTC 2017 === ================================================================= FHIR Implementation Guide Publisher (3.1.0-11939) @ Saturday, April 29, 2017 9:57:38 AM Detected Java version....
Grahame Grieve (Apr 30 2017 at 23:12):
tool version is 3.1.0. yes. That is correct. Some of the other stuff needs my attention - but I'm not sure from that list which you think is wrong.... I think that the path is wrong. And I know it's not converting some of the output back to the specified version.
Grahame Grieve (Apr 30 2017 at 23:12):
anything else?
Eric Haas (May 01 2017 at 02:25):
version : version of FHIR - {{ site.data.fhir.version }} = 3.1.0
revision : revision of FHIR - {{ site.data.fhir.revision }} = 11939
versionFull : version-revision - {{ site.data.fhir.versionFull }} = 3.1.0-11939
This is the tool version and not the FHIR version - that needs to be fixed.
Grahame Grieve (May 01 2017 at 04:49):
fixed
Eric Haas (May 03 2017 at 17:09):
Is there a way in the definitions file to apply a base template for just logical models that the other SD ignore? i.e. if a logical model use base tempate A else use base Template. otherwise I can add the logic in the template
Grahame Grieve (May 04 2017 at 00:16):
there's no way right now. The sense of this doesn't leap out at me?
Eric Haas (May 04 2017 at 02:10):
after thinking about it i'll add logic to the templates
Last updated: Apr 12 2022 at 19:14 UTC