Stream: committers
Topic: IG tests
Grahame Grieve (Oct 09 2018 at 21:31):
@Josh Mandel I am gradually upping the penetration of the tests run as part of the build over the ecosystem. I'm adding tests that check that IGs build today - and the PR failed because Jekyll is not installed in the build machine. See https://fhir-build.visualstudio.com/build.fhir.org/_build/results?buildId=815&view=logs
Grahame Grieve (Oct 09 2018 at 21:31):
can we get it installed?
Grahame Grieve (Oct 09 2018 at 21:33):
also need to decide whether these are CI build only tests, or always run. How many committers who run the main build don't have a need to build IGs?
Josh Mandel (Oct 09 2018 at 21:49):
Hey @Grahame Grieve I'm slightly confused -- we've been using Jekyll to build IGs all along, no? Or do you mean for the IGs that are pre-packed inside the main FHIR build?
Grahame Grieve (Oct 09 2018 at 22:09):
yes, we've been using Jekyll all along for IGs but we haven't used it in the main build. now I want to do that
Josh Mandel (Oct 09 2018 at 23:22):
Okay -- and it's specifically for a set of IGs included in the main build? What are they? And same plugins as for the IG builder?
Grahame Grieve (Oct 09 2018 at 23:33):
they are my test case IGs - if they build, the base feature set of the IG publisher is working.
Grahame Grieve (Oct 09 2018 at 23:33):
I don't know about plug-ins
Grahame Grieve (Oct 09 2018 at 23:33):
not using AsciiDoc, that's for sure
Josh Mandel (Oct 09 2018 at 23:45):
Okay, thanks! Traveling this evening; will get this set up ASAP.
Grahame Grieve (Oct 09 2018 at 23:48):
thx
Josh Mandel (Oct 10 2018 at 19:56):
Added and re-built the PR successfully (https://github.com/HL7/fhir/pull/65)
Grahame Grieve (Oct 10 2018 at 19:57):
awesome thanks
Grahame Grieve (Oct 11 2018 at 03:34):
@Josh Mandel the build is failing again in a new and creative way. I've changed the case of a Java file. The compile is failing:
Grahame Grieve (Oct 11 2018 at 03:34):
[javac] Compiling 398 source files to /home/ubuntu/agents/01/_work/6/s/implementations/java/org.hl7.fhir.r4/bin
2018-10-11T02:59:18.7042080Z [javac] /home/ubuntu/agents/01/_work/6/s/implementations/java/org.hl7.fhir.r4/src/org/hl7/fhir/r4/model/FhirVersion.java:8: error: class FHIRVersion is public, should be declared in a file named FHIRVersion.java
2018-10-11T02:59:18.7042997Z [javac] public enum FHIRVersion {
2018-10-11T02:59:18.7043744Z [javac] ^
Grahame Grieve (Oct 11 2018 at 03:34):
check the case of the file vs the case of the class. It's the right case in the commit...
Grahame Grieve (Oct 11 2018 at 03:36):
no I see it is not. So a git problem itself..
Grahame Grieve (Oct 11 2018 at 03:47):
stupid git. I can't fix the case of a file outside git itself. Sometimes it's just so obstructive...
Josh Mandel (Oct 11 2018 at 12:16):
Wait, so did you figure this or are you stuck? Was the build failing locally or on the server?
Last updated: Apr 12 2022 at 19:14 UTC
