Stream: committers
Topic: Freeze approaching
Grahame Grieve (Mar 05 2018 at 03:59):
hey all - freeze is a few hours off - is there much left to commit?
Bryn Rhodes (Mar 05 2018 at 04:00):
I have a round of changes I'm putting the finishing touches on now.
Bryn Rhodes (Mar 05 2018 at 04:00):
Changed order of elements in the knowledge resources and the approved substantive changes to them.
Bryn Rhodes (Mar 05 2018 at 04:01):
I think the tx server is down too, I keep getting a "running without terminology server error"
Rob Hausam (Mar 05 2018 at 04:05):
I have a few things left, but I don't think will take too long. Nothing should be big other than the ConceptMap.group.element.target.dependsOn change from 'code' to 'value', if we decide to do it - it's ready to go now if we want to pull the trigger.
Lloyd McKenzie (Mar 05 2018 at 04:20):
What did we decide we doing about ImplementationGuide?
Lloyd McKenzie (Mar 05 2018 at 04:20):
Punt it to Sept?
Grahame Grieve (Mar 05 2018 at 04:57):
no we can deal with that this week
Bryn Rhodes (Mar 05 2018 at 05:06):
My local build has been running for over an hour now, and hasn't said anything for the last 30 of that.
Lloyd McKenzie (Mar 05 2018 at 05:10):
That's usually a symptom of an unhappy terminology server - which appears to be the case now.
Grahame Grieve (Mar 05 2018 at 05:12):
We agreed something that's proving impossible for me. We agreed to allow modifier extensions in something that is treated like a data type. I can't deal with that in the java reference model
Lloyd McKenzie (Mar 05 2018 at 05:16):
because?
Grahame Grieve (Mar 05 2018 at 05:18):
the statement that types do not have modifier extensions is baked very deep into the reference implementation
Grahame Grieve (Mar 05 2018 at 05:18):
now we've arbitrarily picked a couple of datatypes and said that they do... but the reference implementation -in fact, all of them - have one base type for all the types and uses it extensively
Lloyd McKenzie (Mar 05 2018 at 05:20):
But wouldn't we make this a subtype of that base type?
Grahame Grieve (Mar 05 2018 at 05:21):
no, because there's a type for BackboneElement. And we don't do multiple inheritance
Grahame Grieve (Mar 05 2018 at 05:24):
and I can't just magically rewrite 1000s of places that would be affected, and completely break HAPI while I'm at it
Lloyd McKenzie (Mar 05 2018 at 05:41):
There's a type for BackboneElement and a type for datatype. I don't see why we can't have a BackboneDatatype that's a specialization of datatype and totally independent of BackboneElement and define modifierExtension on it too. Totally fine if we can't do it for this release, but not clear on why it can't happen in general.
Grahame Grieve (Mar 05 2018 at 05:41):
because all the downstream code expects on or the other. A hybrid means confusion. I tried it
Lloyd McKenzie (Mar 05 2018 at 05:45):
Are there that many places where we're actually looking at modifier?
Grahame Grieve (Mar 05 2018 at 05:46):
yes. You have no idea ....
Bryn Rhodes (Mar 05 2018 at 06:30):
How much time 'til we're frozen?
Grahame Grieve (Mar 05 2018 at 06:32):
a couple of hours. But honestly, after this round of changes... can we go to asking about each change?
Grahame Grieve (Mar 05 2018 at 06:36):
I'm feeling a little bruised right now... it's taken me 3 hours to get everything compiling...
Bryn Rhodes (Mar 05 2018 at 07:01):
Yes, absolutely.
Bryn Rhodes (Mar 05 2018 at 07:43):
Okay, so the change I'm working on is to use canonical rather than Reference for knowledge resources. Almost there (but it did involve a change to RelatedArtifact as well).
Bryn Rhodes (Mar 05 2018 at 07:43):
Am I okay to commit that?
Grahame Grieve (Mar 05 2018 at 07:45):
how many changes is that?
Bryn Rhodes (Mar 05 2018 at 07:47):
Changes in Library, ActivityDefinition, PlanDefinition, Measure, MeasureReport, GuidanceResponse, RequestGroup, and RelatedArtifact.
Grahame Grieve (Mar 05 2018 at 07:58):
sigh. hard work for me, but ok, do it
Bryn Rhodes (Mar 05 2018 at 08:21):
Sorry :(
Bryn Rhodes (Mar 05 2018 at 08:22):
Is it safe to commit while the build is running or do I need to wait for it to finish (because it's doing something to the spreadsheets?)
Grahame Grieve (Mar 05 2018 at 08:23):
as long as the spreadsheets were closed when you ran - it updates them at the start not the end
Bryn Rhodes (Mar 05 2018 at 08:24):
Okay, committed.
Bryn Rhodes (Mar 05 2018 at 08:25):
I think that they are all correct, but I haven't completed the local build yet. I'll keep an eye on it.
Grahame Grieve (Mar 05 2018 at 08:29):
ok that's it - no more structural changes - text changes only know unless check with me first
Bryn Rhodes (Mar 05 2018 at 08:29):
Ack
Rob Hausam (Mar 05 2018 at 09:11):
I had another change to commit, but was waiting for a while with the build issues and then fell asleep. :( I need to make a minor structural change to OccupationalData (FMM=0) to rename 'author' to 'recorder' and add 'informer'. Can I do that?
Grahame Grieve (Mar 05 2018 at 15:16):
yes that's ok
Rob Hausam (Mar 05 2018 at 15:18):
thanks - I'll do it now
Last updated: Apr 12 2022 at 19:14 UTC
