Stream: committers
Topic: Failure on broken links
Lloyd McKenzie (Jan 17 2017 at 22:24):
I'm now getting this message: Halting build because broken links were found
Lloyd McKenzie (Jan 17 2017 at 22:24):
Why is this happening?
Lloyd McKenzie (Jan 17 2017 at 22:24):
It causes my Ant process to fail
Lloyd McKenzie (Jan 17 2017 at 22:25):
My IG will *always* have broken links because some of the links point to zips and other files that get generated after the IG process is run
Lloyd McKenzie (Jan 17 2017 at 22:25):
(And there are some bugs in the IG publisher that are still producing broken links too)
Grahame Grieve (Jan 17 2017 at 22:26):
you will have to fix the IG process actually
Grahame Grieve (Jan 17 2017 at 22:26):
but this code wasn't supposed to be committed yet
Grahame Grieve (Jan 17 2017 at 22:26):
give me a little while to get to it
Lloyd McKenzie (Jan 17 2017 at 22:28):
I've reversed it out
Lloyd McKenzie (Jan 17 2017 at 22:29):
There needs to be a parameter to bypass this rule at a minimum
Grahame Grieve (Jan 17 2017 at 22:30):
there is. it's already documented, but the implementation is not set up.
Grahame Grieve (Jan 17 2017 at 22:30):
but if you want to use the auto-build process, you *will* conform to this
Lloyd McKenzie (Jan 17 2017 at 22:36):
Why?
Grahame Grieve (Jan 17 2017 at 22:39):
hard rules for security: the only html allowed in an auto-build IG is html that the IG publisher has approved. So the hosting environment clears the output directory and then runs the IG publisher as it's last step
Grahame Grieve (Jan 17 2017 at 22:40):
right now there's no support for ant, but if you can convince Josh to add it, it has to run before the publisher runs
Lloyd McKenzie (Jan 17 2017 at 22:43):
My current use-case is generating Excel from CSV files and producing zip files for the same. I don't understand why the IG publisher has to be the last step for security reasons
Grahame Grieve (Jan 17 2017 at 22:44):
you can still do that; just generate the zip files to the temp directory
Grahame Grieve (Jan 17 2017 at 22:45):
it has to be because the ig build process is open to anyone to use , including people how might want to act maliciously. The IG publisher scrbs the xhtml so it's safe
Lloyd McKenzie (Jan 17 2017 at 22:48):
The zip files can't be created until the IG generates its files
Lloyd McKenzie (Jan 17 2017 at 22:49):
(Because we're zipping stuff that's input to the Excel creation process)
Grahame Grieve (Jan 17 2017 at 22:51):
I still don't understand why that's a pronlem
Lloyd McKenzie (Jan 17 2017 at 22:54):
Process is IGPublisher produces CSV; Excel turns CSV into XLS, then produce zip files of all XLS files. HTML files produced by IGPublisher include links to XLS and combined zip files
Lloyd McKenzie (Jan 17 2017 at 22:55):
If IGPublisher dies with broken links to stuff that can't be produced until the IGPublisher is done, that's a bit of a problem
Grahame Grieve (Jan 17 2017 at 22:56):
you can't use excel in a build process
Grahame Grieve (Jan 17 2017 at 22:56):
what are all these xls files?
Lloyd McKenzie (Jan 17 2017 at 22:57):
Prettied up versions of the CSV files
Grahame Grieve (Jan 17 2017 at 22:58):
which csv files?
Lloyd McKenzie (Jan 17 2017 at 22:58):
I could actually produce the Excel files using XSLT instead, it was just easier to use VBA
Lloyd McKenzie (Jan 17 2017 at 22:58):
The IGPublisher can produce CSV files
Lloyd McKenzie (Jan 17 2017 at 22:59):
Contains the information from the table view as separate CSV columns
Grahame Grieve (Jan 17 2017 at 22:59):
well, we can produce xls files too
Lloyd McKenzie (Jan 17 2017 at 23:00):
Sure. But the point is that not everyone is going to want to add their artifacts into the official IGPublisher (and we may not want them to). Post-processing ought to be something that's possible
Grahame Grieve (Jan 17 2017 at 23:01):
sorry. not going to be possible
Grahame Grieve (Jan 17 2017 at 23:02):
right now there's no ant support at all.
Lloyd McKenzie (Jan 17 2017 at 23:03):
I don't understand the security risk posed by post-processing
Grahame Grieve (Jan 17 2017 at 23:03):
can do whatever you want to the html.
Lloyd McKenzie (Jan 17 2017 at 23:04):
Sure
Grahame Grieve (Jan 17 2017 at 23:04):
that's fairly obvious
Lloyd McKenzie (Jan 17 2017 at 23:04):
But what I can do is defined by the build process which is maintained in the project which has limited committer access
Lloyd McKenzie (Jan 17 2017 at 23:05):
I can do all sorts of nasty things in the IGPublisher tool too - as can any other HL7 committer. We trust our committers to not do that and the general public doesn't have commit rights
Grahame Grieve (Jan 17 2017 at 23:07):
any project in the world can use the ig auto-builder.
Grahame Grieve (Jan 17 2017 at 23:07):
not just ours
Grahame Grieve (Jan 17 2017 at 23:08):
so the ig publisher is the last step
Lloyd McKenzie (Jan 17 2017 at 23:14):
So the concern is anyone in the world can put up a website with bad stuff, but we'll make sure that if they use the IGPublisher to put up their website, it can't contain bad stuff??
Lloyd McKenzie (Jan 17 2017 at 23:15):
How does anyone who gets the URL for an IG know it was created with the IGPublisher?
Lloyd McKenzie (Jan 17 2017 at 23:15):
Is the issue that we're going to host things under the HL7 website? And we want to ensure that whatever we host is clean?
Lloyd McKenzie (Jan 17 2017 at 23:15):
If that's the case, then separate the "generate content" from the "prep content for posting" step
Grahame Grieve (Jan 18 2017 at 02:39):
if only it was so easy.
Lloyd McKenzie (Jan 18 2017 at 03:23):
We can chat at some point and you can explain why it isn't
Last updated: Apr 12 2022 at 19:14 UTC
