FHIR Chat · Element name warning

Stream: committers

Topic: Element name warning

Gino Canessa (Nov 06 2020 at 20:08):

I'm receiving the following errors from the ResourceValidator when trying to build - changing them to 'criterion' feels awkward.

     [java] WARNING @ SubscriptionTopic.resourceTrigger.methodCriteria: Element names should be singular (src = ResourceValidator)
     [java] WARNING @ SubscriptionTopic.resourceTrigger.fhirPathCriteria: Element names should be singular (src = ResourceValidator)

Thoughts?

David Pyke (Nov 06 2020 at 20:10):

I would never have guessed they check for plural names on elements. Do you need the word criteri(a|on)? Is it confusing with just method or fhirPath?

Gino Canessa (Nov 06 2020 at 20:20):

In part, I feel like 'method criteria' is the "normal" way of speaking (vs 'method criterion'). Additionally, nobody noticed the requirement and it will be a fair bit of busywork for everyone to rename the fields.

David Pyke (Nov 06 2020 at 20:37):

Then, it's a warning, not an error. Warnings can be handled as needed.

Gino Canessa (Nov 06 2020 at 20:41):

Can't move above FMM0 with warnings though

David Pyke (Nov 06 2020 at 20:42):

You can if you get approval from the Powers That Be(tm) to ignore that warning

Gino Canessa (Nov 06 2020 at 20:42):

Yep, I believe the first step is to ask on Zulip? =)

David Pyke (Nov 06 2020 at 20:44):

Don't do that! Zulip is filled with strange people! Send a self-addressed stamped envelop with a printed picture of the error to Grahame personally. You should get an answer within 4 to 6 weeks

Lloyd McKenzie (Nov 06 2020 at 22:15):

Actually, approval for these exceptions comes from MnM. Given that they repeat, they really should be methodCriterion and fhirPathCriterion. Is there a reason that can't work?

Gino Canessa (Nov 06 2020 at 22:39):

Not can't as much as 'not sure it's better'. Criterion is a far less common word, and criteria is often used as singular. So my (personal) preference would be to leave it.