FHIR Chat · Double prev/next links · committers

Stream: committers

Topic: Double prev/next links


view this post on Zulip Sarah Gaunt (May 17 2021 at 21:06):

So after the changes mentioned here: https://chat.fhir.org/#narrow/stream/179294-committers.2Fannounce/topic/New.20IG.20templates.20-.20needs.20latest.20publisher , I'm getting doubling up of prev/next navigation links:

image.png

Are the old ones something I have control of or is this something that needs to be tweaked in the templte?

view this post on Zulip Lloyd McKenzie (May 17 2021 at 21:07):

@Sean McIlvenna is aware that this is now baked into the template and thus no longer something that Trifolia should be injecting. Hopefully he'll have Trifolia updated to remove the duplication 'soon'.

view this post on Zulip Sarah Gaunt (May 17 2021 at 21:08):

Ok - thanks, will manually remove for now.

view this post on Zulip Sean McIlvenna (May 19 2021 at 18:03):

FYI, this change (removing next/prev page links) to ToF has been committed to the ToF DEV environment (https://trifolia-fhir-dev.lantanagroup.com). It will be included in the next formal release to the production installation. @Sarah Gaunt @Lloyd McKenzie

view this post on Zulip Lloyd McKenzie (May 19 2021 at 18:13):

Ok. There's currently some discussion about whether this change to the global templates should be rolled back. Working to come up with a process where we can gain consensus on whether this is a change that should apply to all HL7 IGs, no IGs (i.e. HL7 IGs should never have next/prev links) or whether there's some criteria for when they should be present and when not.

view this post on Zulip Grahame Grieve (May 20 2021 at 10:30):

should be opt-in

view this post on Zulip Grahame Grieve (May 20 2021 at 10:30):

at least initially. Subject to further discussion to switch to opt-out

view this post on Zulip John Moehrke (May 20 2021 at 11:00):

it is reasonable that new 'features' are not 'on' by default. There should be some way that we do evaluate each feature to determine if it eventually qualifies for on by default. is there a way we can tell what features are being selected? With that we can tell which ones might be good enough to be considered for default, or which ones should be removed completely (don't leave dead code laying around).

view this post on Zulip Lloyd McKenzie (May 20 2021 at 13:05):

I will make it optional, but I think it should be "subject to further discussion to determine appropriate QA rules" - at least for HL7-published guides, the availability of basic navigation features should be determined by criteria other than author preference.


Last updated: Apr 12 2022 at 19:14 UTC