Stream: committers
Topic: Dependence on external code systems
Grahame Grieve (Feb 22 2018 at 23:24):
As of yesterday, it's now possible to add dependency on an external code system to the build. How it works is:
- instead of defining the code system in the build, you add it to [externals] in fhir.ini
- what you add is a literal reference that resolves to the xml or json for the resource
- the first run, the build tool fetches the resource, and makes a copy in \vscache\externals
- then, you behave as if the code system is defined in the spec, but it won't be published, and references are made to the source, not the internal copy
- if you want to update the source, you need to delete the content of \externals and run again (the build keeps a cache so that it can still run off line, I haven't yet decided if I'm going to periodically update the cache, or just do it myself when I rebuild the cache during the QA period each ballot)
Grahame Grieve (Feb 22 2018 at 23:24):
does anyone want to support external value sets?
John Moehrke (Feb 22 2018 at 23:27):
you know I do.... Thanks for doing this
Grahame Grieve (Feb 22 2018 at 23:28):
np. so you have an example value set I can do it on?
John Moehrke (Feb 22 2018 at 23:29):
IHE FormatCode
Grahame Grieve (Feb 22 2018 at 23:36):
so I moved the code system for that one, but the value set remains in FHIR. I'm now looking for where someone wants to bind to a value set that's external
Elliot Silver (Feb 22 2018 at 23:39):
How about DICOM CID 29?
Grahame Grieve (Feb 22 2018 at 23:44):
so can you tell me where the master is, and where it should be used in the FHIR build?
John Moehrke (Feb 22 2018 at 23:44):
why not pull the FormatCode valueSet too?
Grahame Grieve (Feb 22 2018 at 23:45):
because your task said 'the value set includes the IHE code system, and some codes from an HL7 code system'. If it turns out that it doesn't include the HL7 codes, and IHE publishes the value set ready for use, then fine
Elliot Silver (Feb 22 2018 at 23:47):
used at: http://build.fhir.org/valueset-dicom-cid29.html, referenced from: http://build.fhir.org/imagingstudy.html
defined at: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_29.html
Grahame Grieve (Feb 22 2018 at 23:48):
thanks Elliott, but where's the FHIR xml/json source? I can refer to the page, but the build tool needs the actual resource as well
Eric Haas (Feb 22 2018 at 23:48):
how does this work exactly CDC has vaccines codes for example. so they won't expand or be nicely referenced from the valueset. i.e not part of a FHIR term server.
Grahame Grieve (Feb 22 2018 at 23:48):
if CDC publishes them as a code system then we could
Elliot Silver (Feb 22 2018 at 23:48):
ftp://medical.nema.org/medical/dicom/resources/valuesets/fhir/xml/CID_29.xml or ftp://medical.nema.org/medical/dicom/resources/valuesets/fhir/json/CID_29.json
Grahame Grieve (Feb 22 2018 at 23:48):
or if someone else makes one and posts it somewhere
Eric Haas (Feb 22 2018 at 23:48):
Do they need to be FHIR VS resources then?
Grahame Grieve (Feb 22 2018 at 23:49):
ok Elliott, I'll have a go it tonight
Grahame Grieve (Feb 22 2018 at 23:49):
needs FHIR VS or CS yes
Eric Haas (Feb 22 2018 at 23:49):
OK got it
Elliot Silver (Feb 22 2018 at 23:51):
Can you double check that you can actually get those resources? I tried to retrieve them just now , but I'm getting an error, however, I am suspicious of our corporate firewall.
Grahame Grieve (Feb 23 2018 at 01:01):
y works for me
Rob Hausam (Feb 23 2018 at 01:10):
I think it will be good to be able to do this - thanks
Grahame Grieve (Feb 23 2018 at 06:20):
@Elliot Silver I think that's a style question, but this as a canonical URL doesn't quite do it for me: http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_29.html
Grahame Grieve (Feb 23 2018 at 11:55):
Also, it turns out that I can't complete this because the DCM code system doesn't appear to be published. I can't use value sets from DICOM but still use a FHIR published code system (well, technically I could, actually, but it doesn't make sense)
Elliot Silver (Feb 23 2018 at 17:23):
For the canonical URL, you'll have to talk to @David Clunie .
The DCM code system is published (http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_D.html) , but I expect you mean you want a CodeSystem. I'm sure it could be done, but again, that would be an issue for David.
Grahame Grieve (Feb 23 2018 at 22:06):
@David Clunie I think we do need to do that. at present, the DCM coding system codes from http://build.fhir.org/codesystem-dicom-dcim.html and we definitely want it to come from you guys since that copy is already out of date. can you generate it and host it on dicom? and in what kind of timeline?
Last updated: Apr 12 2022 at 19:14 UTC
