Stream: committers
Topic: Connectathon build
Rik Smithies (Aug 10 2020 at 16:35):
What is, or was, the cut off for things for a September Connectathon build. Presumably R5 Preview #3.
Grahame Grieve (Aug 10 2020 at 18:58):
I haven't been thinking about that. Does it matter?
Rik Smithies (Aug 10 2020 at 21:51):
well only if you have changes pending that you want to get into an official build that is going to have software built against it that you are hoping will have that change in it.
Grahame Grieve (Aug 10 2020 at 22:05):
right. Do you? (or anyone else)
Rik Smithies (Aug 10 2020 at 22:47):
:-) yes I do
Khalid Shahin (Aug 13 2020 at 00:44):
I second that. A snapshot would be helpful. :grinning:
Grahame Grieve (Aug 13 2020 at 12:14):
I am going to start the connectathon build in about 72 hours. So last call for changes for the release 4.4....
Grahame Grieve (Aug 15 2020 at 22:08):
I was going to start the build, but it won't build at the moment, and dependent release processes have failed. So it's going to be at least a few days while I sort out the mess
Rob Hausam (Aug 15 2020 at 22:38):
I was assuming the 16th (72 hours), but sounds like it will be a few days past that - correct?
Grahame Grieve (Aug 15 2020 at 22:38):
yes. I was going to start in about 22 hours from now, but there's no way that will be possible
Grahame Grieve (Aug 15 2020 at 22:39):
@Mark Iantorno is fixing the dependent builds but it still won't be on time
Jose Costa Teixeira (Aug 15 2020 at 23:16):
Is it possible to notify when we can submit some PRs? Or we just keep trying?
Grahame Grieve (Aug 16 2020 at 20:36):
I will let you all know when I have sorted it out. Right now, I can't even build a dependency 3 steps away
Josh Mandel (Aug 16 2020 at 22:51):
Just to check: the problem isn't limited to the build server, is it? (I don't want to go down a rabbit hole in reviewing our cloud dev ops infrastructure if that's not where the issue lies.)
Grahame Grieve (Aug 16 2020 at 22:52):
no the problem appears, this time, to be a bug in the pipelines for the HAPI core. Though increasingly the problem is that sonatype itself is unreliable.
Grahame Grieve (Aug 16 2020 at 22:53):
I realised I needed to do a new release to add a single line of code 48 hours ago. Still trying. And now a truck has driven torn down my main internet, so I'm back to the dark ages here
Josh Mandel (Aug 17 2020 at 00:30):
Oh no!
Grahame Grieve (Aug 17 2020 at 03:33):
For your entertainment, here’s my internet cable running through the orchard after a friend who’s an electrician ‘fixed’ it for me:
Grahame Grieve (Aug 17 2020 at 03:39):
Grahame Grieve (Aug 17 2020 at 03:39):
the electrician who's authorised to actually fix it properly is coming tomorrow.
Grahame Grieve (Aug 17 2020 at 03:40):
in the meantime, here's the cable join:
Grahame Grieve (Aug 17 2020 at 03:40):
Jose Costa Teixeira (Aug 17 2020 at 07:45):
I was thinking of this
https://loon.com/solutions/
Grahame Grieve (Aug 17 2020 at 08:35):
I'm hanging out for a low orbit solution for when I'm able to travel again
Grahame Grieve (Aug 17 2020 at 08:35):
That is, in outback Australia
Peter Muir (Aug 17 2020 at 16:02):
Would that qualify as FHIR Slicing ???
Grahame Grieve (Aug 17 2020 at 20:06):
ok. I think I have the build working again.... at least, my latest build worked. I'm not sure whether fixes that I committed to the master become available to your PRs until you do something to make it so. @Josh Mandel ?
Jose Costa Teixeira (Aug 17 2020 at 20:15):
(can i try checking one of my open PRs? )
Grahame Grieve (Aug 17 2020 at 20:18):
sure
Vassil Peytchev (Aug 17 2020 at 20:22):
I'm not sure whether fixes that I committed to the master become available to your PRs until you do something to make it so.
If your local branches are up to date, merging master into your branch will include the changes, and will let you run the build locally with the new fixes. It should be the usual process, I think.
Grahame Grieve (Aug 17 2020 at 20:24):
well, I had hoped otherwise, but no. So you'll all need to do that
Josh Mandel (Aug 17 2020 at 20:30):
Indeed, there is no other way. )Which is kind of by design, although it's inconvenient here.)
John Moehrke (Aug 17 2020 at 20:48):
so, this is with FHIR core builds... right? and from what I read, I will need to merge master into my local branch, build that, before I update my branch? If so, i logically understand, but have not done that before... so any hints on how to actually do that? (with Tortoise Git)...
Gino Canessa (Aug 17 2020 at 20:55):
@John Moehrke The process I use is:
cd <local fhir git repo>
git checkout master
git fetch
git pull
git checkout <your branch>
git rebase master
** fix any conflicts
git pull
** build locally here (left out when typing)
git push
Vassil Peytchev (Aug 17 2020 at 20:58):
Assuming you already have master and PR branch locally
git checkout master
git pull origin master
git checkout <PR branch>
git merge master <PR branch>
Vassil Peytchev (Aug 17 2020 at 20:59):
Then build the PR branch locally, and push it to the CI build to confirm that it builds there.
Gino Canessa (Aug 17 2020 at 21:06):
Related: given how long the CI build takes and how many of us are trying to merge at the same time, let's all try to be careful about clobbering each other.
Grahame Grieve (Aug 17 2020 at 21:07):
how would you be careful?
Gino Canessa (Aug 17 2020 at 21:10):
Pulling master after the checks are done but before hitting the merge button.
Khalid Shahin (Aug 17 2020 at 21:25):
Successfully merged.
Gino Canessa (Aug 17 2020 at 21:48):
Yep. Going back to my earlier comment, Khalid's merge caused conflicts in mine. If you fix locally and push back up, it will restart the CI build, so that's nice.
Grahame Grieve (Aug 18 2020 at 08:07):
some of you might find this PR interesting: https://github.com/HL7/fhir/pull/974 - it's the first phase of removing UTG content from the core build
Grahame Grieve (Aug 18 2020 at 08:07):
it won't build yet - I have work to do in the dependencies yet
John Moehrke (Aug 18 2020 at 12:32):
Grahame Grieve said:
some of you might find this PR interesting: https://github.com/HL7/fhir/pull/974 - it's the first phase of removing UTG content from the core build
better you doing that than me. Having done the equivalent for DICOM codes, I know the joy
John Moehrke (Aug 18 2020 at 13:26):
I got mine updated... would be good to capture that set of git commands for those like me that need a script.. even better if it was written up in tortoise GIT.
Gino Canessa (Aug 18 2020 at 16:26):
Unfortunately, the need to manually address conflicts makes it difficult to create a useful script. That said, there are some good tools that can make it easier. I've been testing Git-Fork and pleased with it so far. On the OSS side, there's Tower and Kraken, which are both well-reviewed.
Grahame Grieve (Aug 19 2020 at 00:50):
ok is there anything outstanding? I want to start processing the connectation build in about 24 hours time...
Rob Hausam (Aug 19 2020 at 14:56):
I have some small Vocab things I would like to try to get in today - before you get started.
Grahame Grieve (Aug 19 2020 at 20:05):
ok well, you have about 4 hours
Rob Hausam (Aug 19 2020 at 21:15):
ok
Rob Hausam (Aug 20 2020 at 00:24):
checks are running on PR#980
Grahame Grieve (Aug 20 2020 at 01:51):
ok I got distracted. I should already have started the build. I'll wait for that one
Rob Hausam (Aug 20 2020 at 01:53):
that one is done - have one last one being checked
I'm checking on a "missing" pclocd.html file right now - it stopped showing up locally for some reason (but should have)
Rob Hausam (Aug 20 2020 at 01:54):
doing a full build
Rob Hausam (Aug 20 2020 at 02:25):
all done - for now
Grahame Grieve (Aug 20 2020 at 02:46):
ok I have started the build. No more submissions
Last updated: Apr 12 2022 at 19:14 UTC
