FHIR Chat · Commit permissions for HL7/fhir · committers

Stream: committers

Topic: Commit permissions for HL7/fhir

Harold Solbrig (Dec 13 2018 at 22:00):

How do you get commit permissions for the FHIR github?

Harold Solbrig (Dec 13 2018 at 22:04):

Or do we use the pull request model?

Grahame Grieve (Dec 13 2018 at 22:25):

use Pulls for now. why?

Harold Solbrig (Dec 13 2018 at 22:25):

Never mind - it is obvious once I take the time to look. :no_mouth:

Harold Solbrig (Dec 13 2018 at 22:26):

Got a tweak to submit to the ShEx emitter.

Harold Solbrig (Dec 13 2018 at 22:26):

Sorry - shorted out on the SVN to git transition...

Grahame Grieve (Dec 13 2018 at 22:30):

while you're here - the last task on my list for today is GF#13595

Grahame Grieve (Dec 13 2018 at 22:31):

looks like this has been overtaken by events:

Grahame Grieve (Dec 13 2018 at 22:31):

fhir:instant  a          owl:Class ;
        rdfs:comment     "An instant in time - known at least to the second" ;
        rdfs:label       "instant" ;
        rdfs:subClassOf  fhir:Primitive ;

Harold Solbrig (Dec 13 2018 at 22:34):

Trying to remember -- been a long time. I think that at the moment the generator uses some sort of table to decide to do this vs. reading it from the model.

Harold Solbrig (Dec 13 2018 at 22:35):

Gimme a sec to look

Harold Solbrig (Dec 13 2018 at 22:37):

        // Primitive isn't in the actual model - added here
        fact.fhir_class("Primitive")
                .addTitle("Types with only a value")
                .addDefinition("Types with only a value and no additional elements as children")
                .restriction(fact.fhir_restriction(value, RDFS.Literal));

Harold Solbrig (Dec 13 2018 at 22:39):

```protected boolean isPrimitive(String name) {
return definitions.hasPrimitiveType(name)
|| (name.endsWith("Type")
&& definitions.getPrimitives().containsKey(name.substring(0, name.length()-4)));
}

Harold Solbrig (Dec 13 2018 at 22:40):

Not exactly resilient, but it works for the time being. I think that the issue was to actually create a top node called "Primitive" but that seems like a lot of work for questionable return...

Grahame Grieve (Dec 13 2018 at 22:42):

ok. in the FHIR build tools, 'primitive' is compiler magic. Each different implementation space (presently: MOF, RDF, XML, JSON, java, pascal, C#, javascript) treats it differently

Harold Solbrig (Dec 13 2018 at 22:53):

So we're consistent. Be happy to sign off on the issue as it sits...

Grahame Grieve (Dec 13 2018 at 22:53):

ok done.

Last updated: Apr 12 2022 at 19:14 UTC