Stream: committers
Topic: Changed Publication Requirement
Grahame Grieve (Mar 19 2019 at 23:42):
Based on implementer feedback, I'm adding a new publication requirement. I'm not sure whether I can require this for this publication cycle, but I'm going to do my best:
- the npm package id must be shown in the toolbar of the implementation guide
Grahame Grieve (Mar 19 2019 at 23:42):
I'm going to fix a guide to show what I mean
Lloyd McKenzie (Mar 19 2019 at 23:43):
Toolbar or footer? Seems like a footer thing to me...
Grahame Grieve (Mar 19 2019 at 23:44):
footer
Grahame Grieve (Mar 19 2019 at 23:44):
that was a typo
David Pyke (Mar 19 2019 at 23:44):
Your keyboard has a really strange layout.
Grahame Grieve (Mar 19 2019 at 23:44):
it was a typo in the head
Grahame Grieve (Mar 20 2019 at 00:15):
ok I added 2 more values to the data file, so that they can go in the footer:
"packageId": "hl7.fhir.uv.phd", "genDay": "20/03/2019",
Grahame Grieve (Mar 20 2019 at 00:15):
so this footer:
© HL7.org {{site.data.info.copyrightyear}} (<a href="http://www.hl7.org/Special/committees/healthcaredevices/index.cfm"/>Devices WG</a>). {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR v{{site.data.fhir.version}}</a> generated {{site.data.fhir.genDay}}.
David Pyke (Mar 20 2019 at 00:18):
Will the values be added automatically?
Eric Haas (Mar 20 2019 at 00:18):
no need to add to the footer templates
David Pyke (Mar 20 2019 at 00:19):
"no need" or "no, need"
Grahame Grieve (Mar 20 2019 at 00:19):
no, you need to add them to the footer template
Grahame Grieve (Mar 20 2019 at 00:20):
generally, review your template footer against my template there. It needs to contain: the copyright statement, the package id and version, the FHIR version and the date. I'd rather it not contain anything else, but that's not a hard rule
Grahame Grieve (Mar 20 2019 at 00:59):
see the footer here: https://build.fhir.org/ig/HL7/PHD/:
Grahame Grieve (Mar 20 2019 at 01:00):
Sarah Gaunt (Mar 20 2019 at 01:08):
So is it actually <npm-name>#<version>?
Eric Haas (Mar 20 2019 at 01:08):
© HL7.org {{site.data.info.copyrightyear}} (<a href="{{site.data.fhir.ig.contact[0].telecom[0]}}"/>{{site.data.fhir.ig.publisher}}</a>). {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR v{{site.data.fhir.version}}</a> generated {{site.data.fhir.genDay}}.
uses all site variables
and I am assuming the HL7.org is only for HL7 ballot products.
Sarah Gaunt (Mar 20 2019 at 01:08):
Thanks @Eric Haas !!
Eric Haas (Mar 20 2019 at 01:12):
assumes the first contact is the one you want
Grahame Grieve (Mar 20 2019 at 01:14):
yes to both Eric
Sarah Gaunt (Mar 20 2019 at 01:14):
yeah, not sure I want my name and number there!! Will change to the workgroup like @Grahame Grieve has done
Grahame Grieve (Mar 20 2019 at 01:14):
@Sarah Gaunt : FHIR STU Release 2 - US Realm Version: 3.0.1 ®© FHIR Version: 3.0.1 (IG Publisher v3.0.1-11917) - can you clarify the versions while you are editing - that sequence is confusing. Let me know and I'll review your updates
Sarah Gaunt (Mar 20 2019 at 01:15):
I am confused by the versions... I will try to fix and let you know.
Grahame Grieve (Mar 20 2019 at 01:16):
and the npm name should be hl7.fhir.us.hai not hl7-fhir-us-hai
Grahame Grieve (Mar 20 2019 at 01:17):
with regard to the versions - you should have 2 versions showing only: the version of the IG (which ig.json says is 3.0.1) and the version of FHIR.
Sarah Gaunt (Mar 20 2019 at 01:18):
Ok thanks, will fix - pretty sure it shouldn't be 3.0.1 - should be 2.0.0
Grahame Grieve (Mar 20 2019 at 01:19):
the version in the header and footer should match the fixed-business-version in the ig.json, and it looks to me like it should be 1.1.0 right now (based on what is in http://www.hl7.org/fhir/us/hai/history.cfml)
Grahame Grieve (Mar 20 2019 at 01:19):
we want it to be 2.0.0 when re publish after reconciliation
Sarah Gaunt (Mar 20 2019 at 01:24):
So I have this in the header "Healthcare Associated Infection Reports, FHIR STU Release 2"
I presume that should actually be : "Healthcare Associated Infection Reports, FHIR STU Release 1.1.0"?
Grahame Grieve (Mar 20 2019 at 01:24):
@Bryn Rhodes / @Eric Haas I think that the DEQM version should not be 2.0.0. The last one was 0.1.0, and this is another ballot, so it should be 0.2.0
Grahame Grieve (Mar 20 2019 at 01:25):
Sarah: I would have the title Healthcare Associated Infection Reports, FHIR STU 2 Ballot
Grahame Grieve (Mar 20 2019 at 01:28):
@Lloyd McKenzie the crd IG, the npm name should be hl7.fhir.us.davinci-crd not hl7.fhir.us.davinci.crd
Grahame Grieve (Mar 20 2019 at 01:30):
- please update the footer
Eric Haas (Mar 20 2019 at 01:35):
@GG did you update the publisher? I do not see "packageId" ? and you don't need genDay just use the filter:
{{site.data.fhir.genDate | date: "%b, %d, %Y"}}
Grahame Grieve (Mar 20 2019 at 01:36):
@AbdulMalik Shakir:
- what is the version for the bser IG? it needs to stated in fixed-business-version in the IG.json file.
- the npm name should be hl7.fhir.us.bser not hl7.fhir.bser
- the footer needs to follow the same pattern as the other IGs - reference to history, license, task creation, nad the same version information as above
- the header should include the ballot sequence (e.g. STU1 ballot #2)
- should you remove the reference to simplifier this time?
Grahame Grieve (Mar 20 2019 at 01:37):
I did update the publisher
Eric Haas (Mar 20 2019 at 01:39):
OK
Grahame Grieve (Mar 20 2019 at 01:43):
@David Pyke eltss comments:
- shouldn't the version be 0.1.0? (why 0.2?)
- the canonical base must be http://hl7.org/fhir/us/eLTSS
- the npm name must be hl7.fhir.us.eltss not hl7.fhir.uv.eltss
- the header should be updated to say ""STU1 Ballot 1" or such like
- the footer should be updated using the template as above
David Pyke (Mar 20 2019 at 01:47):
I'll make the changes
Grahame Grieve (Mar 20 2019 at 01:51):
@Bryn Rhodes what is the right version for FHIRPath this time?
Grahame Grieve (Mar 20 2019 at 01:56):
@Nagesh Bashyam for womens-health-registries, the version should be 0.1.0 not 1.0.0. Also. please update the footer based on the template above
Grahame Grieve (Mar 20 2019 at 01:58):
also, for patient-reported-outcomes, the version should 0.2.0, yes?
Grahame Grieve (Mar 20 2019 at 01:58):
and same for footer. Header should say ballot #2, yes?
Grahame Grieve (Mar 20 2019 at 02:01):
@Lloyd McKenzie SDc - how can the version have reverted to 2.7.0 from 3.5.0? And please update the footer
Eric Haas (Mar 20 2019 at 02:03):
i'm still not seeing site.data.fhir.packageId I 've downloaded the lateset ig-pub twice has anybody else been able to use it?
Grahame Grieve (Mar 20 2019 at 02:03):
the HAI CI build used it
Grahame Grieve (Mar 20 2019 at 02:05):
@Chris Moesel congrats on having the ids and versions correct in the breast cancer IG. can you update the footer please
Sarah Gaunt (Mar 20 2019 at 02:06):
I don't think it did - it only put the version in:
pasted image
Grahame Grieve (Mar 20 2019 at 02:07):
hmm I meant PHD. This html: {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }}
produces hl7.fhir.uv.phd#0.2.0
Sarah Gaunt (Mar 20 2019 at 02:09):
That's what I have and it's missing the packageId: {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }}
Grahame Grieve (Mar 20 2019 at 02:09):
@Brian Reinhold I updated the PHD footer for you, but the header has - ${ballotstatus}""- can we fix that?
Lloyd McKenzie (Mar 20 2019 at 02:09):
The version had made a leap to 3.x with no real justification so I reeled it back. Is it causing a problem?
Grahame Grieve (Mar 20 2019 at 02:10):
@Josh Mandel I don't have any idea why it would not work consistently? Any ideas how to investigate?
Grahame Grieve (Mar 20 2019 at 02:10):
version... well, NPM won't tolerate it, but we could say that we don't mind this time. or I could do a technical correction on the last one to 2.5.0...
Lloyd McKenzie (Mar 20 2019 at 02:14):
If you can, that would be good. That way once we actually publish the third release of SDC, it can be 3.0.0
Grahame Grieve (Mar 20 2019 at 02:14):
I'll sort that out later. 2.7.0 is ok
Eric Haas (Mar 20 2019 at 02:24):
OK I am pushing DEQM with the version 0.2.0 and the footer ready to go when packageId is updated
Eric Haas (Mar 20 2019 at 02:27):
Josh Mandel (Mar 20 2019 at 02:42):
What's the inconsistency you're seeing?
Lloyd McKenzie (Mar 20 2019 at 02:46):
How is site.data.fhir.genDay different from the already existing site.data.fhir.genDate?
Lloyd McKenzie (Mar 20 2019 at 02:48):
My proposed footer is:
Implementation Guide © {{site.data.info.copyrightyear}} <a href="{{site.data.fhir.ig.contact[0].telecom[0]}}"/>{{site.data.fhir.ig.publisher}}</a>. {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR ({{site.data.fhir.version}}</a>). IG generated {{site.data.fhir.genDate}}.
It's not HL7-specific, makes clear what's copyright and doesn't put 'v' in front of R4 or STU3 or whatever.
Eric Haas (Mar 20 2019 at 02:49):
{{site.data.fhir.genDate | date: "%b, %d, %Y"}} == {{site.data.fhir.genDay}}
Eric Haas (Mar 20 2019 at 02:51):
here is mine:
<p>{% if {{site.hl7_ig}} == true %} © HL7.org {{site.data.info.copyrightyear}} (<a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}}</a>). {%- else %} <a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}} </a> {%- endif %} {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR v{{site.data.fhir.version}}</a> generated {{site.data.fhir.genDate | date: "%b %d, %Y"}}. <br/> Links: <a style="color: #81BEF7" href="toc.html">Table of Contents</a> | <a style="color: #81BEF7" href="qa.html">QA Report</a> | <a style="color: #81BEF7" href="{{ site.historypath }}">Version History</a> | <a style="color: #81BEF7" rel="license" href="{{site.data.fhir.path}}license.html"><img style="border-style: none;" alt="CC0" src="cc0.png"/></a> | <a style="color: #81BEF7" href="{{ site.changelink }}" target="_blank">Propose a change</a> </p>
using a site variable flag to determine if is hl7 ig or not.
Sarah Gaunt (Mar 20 2019 at 02:53):
Ok, I think all the HAI versions are correct and footer has been updated - have pushed. Will re-build when packageId updated...
Eric Haas (Mar 20 2019 at 02:55):
@Josh Mandel GG pushed ig-pub update fot the site variable for packageId but is not showing up ( at least I think that is the issue)
here is an example site json:
{ "path": "http://hl7.org/fhir/STU3/", "canonical": "http://fhir.org/guides/argonaut-questionnaire", "igId": "argonaut.us.questionnaire-1.0.0", "igName": "Argonaut Questionnaire", "igVer": "1.0.0", "errorCount": 18, "version": "3.0.1", "revision": "11917", "versionFull": "3.0.1-11917", "toolingVersion": "4.1.0", "toolingRevision": "3", "toolingVersionFull": "4.1.0 (3)", "totalFiles": 47, "processedFiles": 1, "genDate": "Tue, Mar 19, 2019 19:33-0700", "genDay": "19/03/2019", "ig": { "id": "argonaut.us.questionnaire-1.0.0", "name": "Argonaut Questionnaire", "url": "http://fhir.org/guides/argonaut-questionnaire/ImplementationGuide/argonaut.us.questionnaire-1.0.0", "version": "1.0.0", "status": "draft", "experimental": true, "publisher": "Argonaut Project", "contact": [ { "telecom": [ "http://argonautwiki.hl7.org" ] } ] }, "uscore": "http://hl7.org/fhir/us/core/" }
Bryn Rhodes (Mar 20 2019 at 02:57):
@Grahame Grieve , FHIRPath version is 1.3.0
Lloyd McKenzie (Mar 20 2019 at 02:59):
Ah, I see the difference in day vs. date. Challenge is that when you're updating the IG multiple times in a day, there's now no indication which build you're looking at. But with the extra info, it's harder to make it all fit. :(
Lloyd McKenzie (Mar 20 2019 at 03:01):
I think I'm going to keep the full timestamp but move it onto the second line.
Eric Haas (Mar 20 2019 at 03:02):
who looks at that beyond day?
Lloyd McKenzie (Mar 20 2019 at 03:03):
I do when I'm checking to see if the new version is up yet.
Sarah Gaunt (Mar 20 2019 at 03:03):
Me! Like Lloyd said - multiple times in a day updates... I'm going to change back to full time stamp also...
Eric Haas (Mar 20 2019 at 03:04):
I just look for the latest changes :-)
Eric Haas (Mar 20 2019 at 03:04):
too logical to look at a time stamp!
Sarah Gaunt (Mar 20 2019 at 03:04):
I can't remember what changes I've made from one second to the next...
Lloyd McKenzie (Mar 20 2019 at 03:34):
Eventually landed on this:
IG © {{site.data.info.copyrightyear}} <a style="color: #81BEF7" href="{{site.data.fhir.ig.contact[0].telecom[0]}}"/>{{site.data.fhir.ig.publisher}}</a>. Package {{site.data.fhir.packageId}}#{{site.data.fhir.igVer}} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR {{site.data.fhir.version}}</a>. Generated {{site.data.fhir.genDate}}
Bryn Rhodes (Mar 20 2019 at 03:56):
Updated the footer in FHIR Measures IG. The broken link is because the history is linking to the ballot location of 2018May
Grahame Grieve (Mar 20 2019 at 04:00):
day vs date - I want the published IG to just have day, but I understand why the normal CI build has full date
Grahame Grieve (Mar 20 2019 at 04:02):
you should not be posting multiple versions per day now..
Grahame Grieve (Mar 20 2019 at 04:13):
packageId publication problem was not a version issue. I used the wrong variable
Grahame Grieve (Mar 20 2019 at 04:16):
@Nagesh Bashyam can you aslo update the header and footer for cdmh please
Grahame Grieve (Mar 20 2019 at 04:20):
@Andy Gregorowicz the header and footer need updating for davinci-dtr - the header should state the ballot, and the footer should follow the discussion above
Grahame Grieve (Mar 20 2019 at 04:22):
@Rick Geimer the fixed business version for davinci-hrex should be 0.1.0 not 4.0.0. Also, please update the header and footer as above
Grahame Grieve (Mar 20 2019 at 04:48):
@Mark Scrimshire the fixed business version for davinci-hrex should be 0.1.0 not 4.0.0. Also, please update the header and footer as above
Grahame Grieve (Mar 20 2019 at 04:54):
@Rick Geimer same for davinci-ecdx
Grahame Grieve (Mar 20 2019 at 04:57):
and PHCP...
Grahame Grieve (Mar 20 2019 at 04:58):
Also, @Rick Geimer the PHCP version should be 0.2.0?
Grahame Grieve (Mar 20 2019 at 05:01):
@Bryn Rhodes for Quality measures the npm-name us-cqfmeasures is not correct. Is it hl7.fhir.us.cqfmeasures? footer and header need review too
Grahame Grieve (Mar 20 2019 at 05:04):
@AbdulMalik Shakir same comments as above for vrdr
Grahame Grieve (Mar 20 2019 at 05:07):
well, I'm exhausted after that. I'll review all the package-list.json files tomorrow
Bryn Rhodes (Mar 20 2019 at 05:12):
Thanks @Grahame Grieve !
Lloyd McKenzie (Mar 20 2019 at 05:32):
I don't want to tweak the footer when it comes time to publication. And once we move to a framework, we won't be able to tweak the footer when it comes to publication. I strongly prefer to retain timestamp in the footer for all uses. (I can see scenarios where we might push something up, then patch it, then push it up again where the timestamp could be relevant.)
Grahame Grieve (Mar 20 2019 at 05:45):
I can see scenarios where we might push something up, then patch it, then push it up again where the timestamp could be relevant.
not without changing the version
Lloyd McKenzie (Mar 20 2019 at 05:48):
On the first day you post it? You'd tweak the version if there was an error in the publishing process and you fixed and repushed before ballot opened?
Grahame Grieve (Mar 20 2019 at 05:53):
umm no, but when does time get involved there?
Lloyd McKenzie (Mar 20 2019 at 06:10):
If someone has grabbed a copy in the hours between the first post and second post.
Lloyd McKenzie (Mar 20 2019 at 06:10):
I just don't see a good reason to not allow full timestamp. The value of 'shorter' doesn't outweigh the pain of having to change between publication types.
Grahame Grieve (Mar 20 2019 at 06:12):
once a spec is released, any updates must be accompanied by version changes.
Grahame Grieve (Mar 20 2019 at 06:12):
I'll be interested to see other opinions. Lloyd is one end of the spectrum for attention to detail... I'm trying to keep the details down
Eric Haas (Mar 20 2019 at 12:09):
Lloyd we can tweak the date based on whether it is a ci build or ballot item published build. Using site variables. Maybe we need that as an element in R5. Iim sure you do this already for title. And the publish box.
Eric Haas (Mar 20 2019 at 12:11):
@Bryn Rhodes any changes you make to package ids may need to be applied to DEQM dependencies. So let me know.
Eric Haas (Mar 20 2019 at 12:14):
I think day is fine for most cases.
Bryn Rhodes (Mar 20 2019 at 13:08):
Eric, I changed the package name for the FHIR Measures IG to hl7.fhir.us.cqfmeasures
Bryn Rhodes (Mar 20 2019 at 13:08):
I agree day is fine for most cases, but can it use YYYY-MM-DD? It's using DD-MM-YYYY right now, which is confusing for me as a backwards American.
Andy Gregorowicz (Mar 20 2019 at 13:38):
@Grahame Grieve I've updated the header and footer of davinci-dtr. For the footer, I copied what Lloyd had mentioned in the chat. If it should be something different, I'm happy to change it.
Lloyd McKenzie (Mar 20 2019 at 13:53):
+1 on yyyy-mm-dd. I think that's essential for an international standard. As a compromise, how about we display a date with a flyover of full timestamp?
Eric Haas (Mar 20 2019 at 16:07):
OK based on Lloyd's and Bryn's comment here is a plain Jane footer with a hover over the yyyy-mm-dd :
<p> © HL7.org {{site.data.info.copyrightyear}} (<a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}}</a>). <a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}} </a> {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR v{{site.data.fhir.version}}</a> generated <span title="{{site.data.fhir.genDate}}">{{site.data.fhir.genDate | date: "%Y-%m-%d"}}</span>. <br/> Links: <a style="color: #81BEF7" href="toc.html">Table of Contents</a> | <a style="color: #81BEF7" href="qa.html">QA Report</a> | <a style="color: #81BEF7" href="{{ site.historypath }}">Version History</a> | <a style="color: #81BEF7" rel="license" href="{{site.data.fhir.path}}license.html"><img style="border-style: none;" alt="CC0" src="cc0.png"/></a> | <a style="color: #81BEF7" href="{{ site.changelink }}" target="_blank">Propose a change</a> </p>
and here is fancier version which can be used for non hl7 ig by creating a flag in your config.yml file and using bootstraps tooltips for a prettier callout tooltip.
<p>{% if {{site.hl7_ig}} == true %} © HL7.org {{site.data.info.copyrightyear}} (<a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}}</a>). {%- else %} <a href="{{site.data.fhir.ig.contact[0].telecom[0]}}">{{site.data.fhir.ig.publisher}} </a> {%- endif %} {{site.data.fhir.packageId}}#{{site.data.fhir.igVer }} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR v{{site.data.fhir.version}}</a> generated <span href="#" data-toggle="tooltip" data-placement="top" title="{{site.data.fhir.genDate}}">{{site.data.fhir.genDate | date: "%Y-%m-%d"}}</span>. <br/> Links: <a style="color: #81BEF7" href="toc.html">Table of Contents</a> | <a style="color: #81BEF7" href="qa.html">QA Report</a> | <a style="color: #81BEF7" href="{{ site.historypath }}">Version History</a> | <a style="color: #81BEF7" rel="license" href="{{site.data.fhir.path}}license.html"><img style="border-style: none;" alt="CC0" src="cc0.png"/></a> | <a style="color: #81BEF7" href="{{ site.changelink }}" target="_blank">Propose a change</a> </p> + adding this script $(document).ready(function(){ $('[data-toggle="tooltip"]').tooltip(); });
example of this is here: https://healthedata1.github.io/IG-Template2/
Lloyd McKenzie (Mar 20 2019 at 19:06):
I don't understand the reason to hard-code "HL7.org" at all. Technically, it's not copyright "HL7.org", it's copyright "HL7 International" - which is what our naming standards say that the "publisher" must start with. So if you just say (c) {{publisher}}, you should be covered for both HL7 and non-HL7 published IGs.
Lloyd McKenzie (Mar 20 2019 at 19:12):
IG &#169; {{site.data.info.copyrightyear}} <a style="color: #81BEF7" href="{{site.data.fhir.ig.contact[0].telecom[0]}}"/>{{site.data.fhir.ig.publisher}}</a>. Package {{site.data.fhir.packageId}}#{{site.data.fhir.igVer}} based on <a style="color: #81BEF7" href="{{site.data.fhir.path}}">FHIR {{site.data.fhir.version}}</a>. Generated <span title="{{site.data.fhir.genDate}}">{{site.data.fhir.genDate | date: "%Y-%m-%d"}}</span> <br/> <span style="color: #FFFF77"> Links: <a style="color: #81BEF7" href="{{site.data.info.assets}}toc.html">Table of Contents</a> | <a style="color: #81BEF7" href="qa.html">QA Report</a> | <a style="color: #81BEF7" target="_blank" href="{{site.data.fhir.canonical}}/history.html">Version History <img alt="external" style="text-align: baseline" src="external.png"/></a></a> | <a style="color: #81BEF7" rel="license" href="{{site.data.fhir.path}}license.html"><img style="border-style: none;" alt="CC0" src="cc0.png"/></a> | <!--<a style="color: #81BEF7" href="todo.html">Search</a> | --> <a style="color: #81BEF7" target="_blank" href="http://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemAdd&amp;tracker_id=677">Propose a change <img alt="external" style="text-align: baseline" src="external.png"/></a>
Grahame Grieve (Mar 20 2019 at 19:44):
I'm ok with yyyy-mm-dd and with the full date as a fly-over
Eric Haas (Mar 20 2019 at 20:47):
which is what our naming standards say that the "publisher" must start with
can you give an example. because I never have used "HL7 International" for publisher...
Grahame Grieve (Mar 20 2019 at 21:09):
Hey @Josh Mandel - this page: https://hl7-fhir.github.io/auto-ig-builder/builds.html - can we add another button on the right that links to [web]/qa.html - it'll just save me always having to manually add qa.html to the link.. thanks
Grahame Grieve (Mar 20 2019 at 21:09):
p.s I love this page....
Grahame Grieve (Mar 20 2019 at 21:37):
it'd also be cool if the page shows build run duration as well
Grahame Grieve (Mar 20 2019 at 22:38):
alternatively - where is the source for the page in version control?
Grahame Grieve (Mar 21 2019 at 03:00):
@Sarah Gaunt why do you think 3.0.1 is the right version? (given the last published version is 1.0.0)
Grahame Grieve (Mar 21 2019 at 03:01):
(for HAI)
Grahame Grieve (Mar 21 2019 at 03:02):
and there is no new entry in package-list.json
Sarah Gaunt (Mar 21 2019 at 04:42):
@Grahame Grieve I don't think 3.0.1 is the right version - I thought version in the ig.json file was the FHIR version (and fixed-business-version, which I have set to 1.1.0, was the IG version?). Where do you see 3.0.1 as the version of the IG?
Sarah Gaunt (Mar 21 2019 at 04:56):
@Grahame Grieve what would the path for the ballot release be in the package-list.json file?
Grahame Grieve (Mar 21 2019 at 04:59):
ok sorry - 1.1.0 is correct. I'm obviously looking at too many IGs at once
Grahame Grieve (Mar 21 2019 at 04:59):
path will be [canonical]/2019May
Sarah Gaunt (Mar 21 2019 at 05:02):
Np! Updating path now...
Mark Scrimshire (Mar 21 2019 at 20:04):
Mark Scrimshire the fixed business version for davinci-hrex should be 0.1.0 not 4.0.0. Also, please update the header and footer as above
Seems to be a problem with the Trifolia publisher. I had the version set as 0.0.x as we work through very early drafts. I raised the issue with Trifolia.
Rick Geimer (Mar 21 2019 at 20:18):
@Mark Scrimshire I believe the issue is fixed now. We were populating fixed-business-version in ig.json with ImplementationGuide.fhirVersion, but now are correctly (I hope) populating it with the value in ImplementationGuide.version.
Mark Scrimshire (Mar 21 2019 at 20:49):
Mark Scrimshire I believe the issue is fixed now. We were populating fixed-business-version in ig.json with ImplementationGuide.fhirVersion, but now are correctly (I hope) populating it with the value in ImplementationGuide.version.
:+1:
Grahame Grieve (Mar 21 2019 at 20:50):
I'll check
Grahame Grieve (Mar 23 2019 at 02:08):
@Josh Mandel where's the source for the page at https://hl7-fhir.github.io/auto-ig-builder/builds.html - can I make a PR against it?
Josh Mandel (Mar 23 2019 at 02:09):
Of course: https://github.com/hl7-fhir/auto-ig-builder/tree/master/docs
Grahame Grieve (Mar 23 2019 at 02:14):
thx
Grahame Grieve (Mar 23 2019 at 02:16):
k. made a pr - can you review? (I think I understood enough not to debug)
Grahame Grieve (Mar 23 2019 at 06:32):
thx
Last updated: Apr 12 2022 at 19:14 UTC